From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19AE245A7C; Tue, 1 Oct 2024 15:00:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E44424027E; Tue, 1 Oct 2024 15:00:37 +0200 (CEST) Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013030.outbound.protection.outlook.com [52.101.67.30]) by mails.dpdk.org (Postfix) with ESMTP id 9BC934027C for ; Tue, 1 Oct 2024 15:00:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XJT+F3wGpSI3y4oe5gBP6T8Cra0T1yPHJm0GQjVJ+MW7kSk1hPH04Eaw7nVWyPqnMfTtJ0I3WUlvzue3KJULVSkQ5cE3p7hEE4sn7BLdJ8ZNAco1BEbOQgcygJlQz9un4sB2Q7rVvANdyP/Knco1zcvM1z+g3jZ05olIzyJ57bLyCAQSWBd5A7N/4ygRjBMx1eImM1abhAuljk0CaAQeu+s6C8/qgdCvroDz6Mhf1K7F5pYhjRWaUVF3FxFWm5amEgAhGtbFurMv/GZ00P1Z0Cn7J+RJ1PvHyTefL3LDZSq5T4esoGRsH0xDy3nuXntvv4Jam7iZmZuppvsazWg3Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iss/QkT+wQ0BW+Dh1+OZ2UUcsQU8B88XpTuRa7El140=; b=Vamgf0agCndyK+rMj8sopg9VzmYuwqCzeGq5AO2VK8nGimPQSzt9CBg6/lKWf1shINVFB/ftvgT1XrMohGboU7Cu67i9zS1bEtaN1CbYLTSrY4t+Lp487e6VItdVgk+ifNDyryJIs/RPy3qaDmEQmcobluZ+OeopOegcJxjxr6TnSlJwDOAv0QYFBPqYDGbLlzCCJCIjbA2J7WuwK0UUriL7BtMpjXKSMsoB1KDKB00Jsl7qopADRJlGy2l0x4uqu03PDOoqEpsDdcxj/GXf5KiOINz2mniaIQgWuUYiwlTsFn6tzdmFDjulyMYaJb2B50L9Z01HcY5Io9/k73Qheg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iss/QkT+wQ0BW+Dh1+OZ2UUcsQU8B88XpTuRa7El140=; b=lXVMYQ6Xrs2trMJEr7O0G1UvZIMjHlIwJ5txWh/CX98G+EFPwt2JBaQ+10ZOIB4YzbbQ5OR8P7DYLpdT3CxFKjvGGHIfyEY5aJUm+rdYlSx+EZCveTVwy09SuhAqrlMrJ+iY9H3P4qZHouq1CAWsuWuaAZ0aJRTZ5B0RC1SdMniJXu48koKBtqFE9dR2qwlnORTdZ3PxgwM+sEFScLuQrRhtgrot7/ZaflSKIwG2yiF7IvGtH+QihqqawRWRdiVfmOwpaXjEyG1a8ssm7JhnHYr/9LgU3Y7AW/YM0nLRLhOEPuAOVFUVYQi+ZISIgrRqd+wZq2RwwKr9rPeWN/iJbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by AM9PR04MB8650.eurprd04.prod.outlook.com (2603:10a6:20b:43d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.27; Tue, 1 Oct 2024 13:00:34 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%3]) with mapi id 15.20.8005.026; Tue, 1 Oct 2024 13:00:34 +0000 Message-ID: Date: Tue, 1 Oct 2024 18:30:30 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 03/14] net/dpaa: remove broken debug macros Content-Language: en-US To: dev@dpdk.org References: <20240907145433.1479091-1-david.marchand@redhat.com> <20240912082643.1532679-1-david.marchand@redhat.com> <20240912082643.1532679-4-david.marchand@redhat.com> <7782369.EvYhyI6sBW@thomas> From: Hemant Agrawal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:3:17::30) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|AM9PR04MB8650:EE_ X-MS-Office365-Filtering-Correlation-Id: 575ac782-a4ea-4436-91df-08dce2190992 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YkhHbmxyK0xtZi9kemdLanJGTDZ3L2g4L3EvT3J1cjVGVUpvblNJeWRnNUVu?= =?utf-8?B?SHZyR2s1LzBxTEVNeWpJWjVZcUxxR2FDbjY4dkgwc0o3aGFucUQ3U2VhaW8r?= =?utf-8?B?d20xRFBOd3NuNlpPQkUvZXl2WGNBVTJ0OXBvRmtjSGszRnJOWHUxSCswQWtY?= =?utf-8?B?QW5PNzB5WUtvaEtLbEFEV3hwUWFyS0lnQ0RDbjJUdmo1QU1LWTl1YzlsejBa?= =?utf-8?B?N2JxcDhvT0dnU2ZNS2dTTEpjMlFUbGpZMk5jN3plOGNUa09HcTFGVEV4Ulox?= =?utf-8?B?NHBhemlyZTN6Ti9PL0NiTU1sQm1FRHhhUFhGOGh6eFJLOUd5WVRqRHFtdk5t?= =?utf-8?B?cGJDY0RxTlcyOXdMNHpkZk85UGw2MzVDM3A2QndUUER2dkUxcXVpemF5TS9D?= =?utf-8?B?TUFzVC91SmpJd0NpRmRacVkrRkpFcWFYOHpOdUt4bjNhSGkxM0hPdGNSNmpS?= =?utf-8?B?ZkgrKzZUNkM2YTFBM21hSVc3MHJBOXAyckFQYjlUYlBJaGlQNkMwaE51UWNY?= =?utf-8?B?RXRUekVnWjhtb2pLRjVZN3RpdG1LOEtRdjN4L25vMUpoYWJsQlVHcUlRVGFn?= =?utf-8?B?NmxFanpuY0lpNG9rN1dqc21iQ1AyRDRxY3lKR1lkcGg5ak42WnNjMHQyQTBB?= =?utf-8?B?OFhITzlDMTJMMjZ4NUFrb2pOMWphN2JDOXJNNlBFdTFmSlZ6YVFRY2VYYVVG?= =?utf-8?B?K3J0RldOdysxMUdPMmNZcjBaeFNCa1doSWRMUUcxalFJRHhFVHB4b1ppS2d4?= =?utf-8?B?MUhkZGhjbE9EK2hGUHZjNjMxYWZMRjZBckUwVy9RUzViNUpSSndVandzVGxL?= =?utf-8?B?YXA0c201MzBDMERiVGpwTUtvUzVoNksranZmS3F4Mm5mK29HVU4xaGtncys5?= =?utf-8?B?WE1zQ3Vya0hiNHVsWm96b1I5T0t5elFOcjBkZ3hIQjNsWE9pZjJ3M1JLYXJD?= =?utf-8?B?eitDR3EzcEhZYldBb1Q1NUhSS0M3eVNIbW1iY3daVTM0K0RkZHJFYnJ1WUtH?= =?utf-8?B?WXAyQ2pPczFYZWFIMVpjeVpvWDFidmxwMTZWcStja20zdWFFTXZtaWtYWXBF?= =?utf-8?B?N0t5aDExZkM1M05WM0IxTG9pQ0NFQ1Y3U2xiVzFCTGlBSFkwaU5VR0Z0dkgr?= =?utf-8?B?eHdDL0RsSFFPYk94YUk0Tk9YeVZXSmZEVHVuSC9EdUxsYVRVMlZoT2RrR1FF?= =?utf-8?B?Q2QrbGNlS2dJRnF3S0kwUWJ6UDZFRDF1Z0xzVExZRW9vZWU2Sno1cDJiVTBs?= =?utf-8?B?dUgxSUpYWllQU3k0Q252MVRnQ0UwTy9tQ3BoYXFnbm9NWjZpcU0rOW9STFZ3?= =?utf-8?B?eGRadXR0eStacXNGRkFYdUM2Nm1mVjdtS29QVHFlUlJmcUJua0lpeHZZYUxy?= =?utf-8?B?ME1wM1pVMWRmZmJZWEFnN3FxZklUTFlWQmlzZm1pWlhMSU1pSnpUVVhlSFV2?= =?utf-8?B?NzBkLzBWbUduek0ra0NRZkVWTmRTSytnWkEvU244ZWdwK292cFlHYnliZE1I?= =?utf-8?B?Zk9iYWFwWmFlamtJUCtscWlaUzNqdXNMUEt4Wlg0QWlxUEg2bmhtd3ozdno5?= =?utf-8?B?d0tDdys2aHlhTWlIbSt4WGdQNGExNE1yNmRiOU90MXFlMVpESW5xL2k2SWdJ?= =?utf-8?B?VlMxY3NGTjZPNEhUWCszSENVOHJnMkl3TWxhWVFOVmZzY1pXMTMzUlFqc1hJ?= =?utf-8?B?TlQ3cjdsNXpyZlRBTFFTS2M1cmtDa3VqTk9GaEpITjhLWE5KWWYyQ2lBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzI0blpTL1I3TjY5OXZSYzdXMDZiMStIbjY5cmh2dy9PNzVYUGpOU2tUb1hI?= =?utf-8?B?OHh1OGRJOGkrZTdCMU5hMFVZQ0lwR2QweVVsK002Y0NhcTdwSXh1N080b2dw?= =?utf-8?B?NHJZb0ZWelprUEc4eEJkK3Ewem01b09hS1BvK2lGVm1xdVFaMVFGSU9yV1ZT?= =?utf-8?B?c1h1WTJLSmhhQWFPRTlkczJFRzZSL210YTVybFR5UitybFhqajFHYzdTVWF3?= =?utf-8?B?TVd4VmRWblcvMjRuc3NkL1FVUUlhUlhQbC9vN0Z4V0hGWVVLYlVhRm9rckFu?= =?utf-8?B?aCt2SzUwbVVHczFBVVlyZHRvR0l0bm16MmxRSlVDYmNodUlHV0U5VzZxZkll?= =?utf-8?B?UjJ1VUpDc0FKUXBBUTU5LzhEeDFoSFNrMFNuTFF3WTdQK3BMRDVHTDA3WnIz?= =?utf-8?B?dU1YRFJHbGhMWlF4T2laVXNjaUxyZTFDZzVqakhUVmVTdlVTTW5PdXJtSWRL?= =?utf-8?B?SGZEZzF6djlLWk8wR0EwRHpPS0pHQXIxNnhZWkZVdEMyeGU5R3hFd1lPeFU4?= =?utf-8?B?NXYvaklaQitZZC9PVTQvUWxkOEgrbU13S3g5VGNLV2ZhMS91L3hXc2tIZ1RJ?= =?utf-8?B?R3p1akJ4bEF1UVdzQ0p1RlIxVGhDMXp1VFVJMUdIQW9QbHUwSER5NWpqWXJ5?= =?utf-8?B?QkwrVnRrUEpMTGlDek5mVHBKNzk0dlFuZ2s4dW52cXd2OFUrclExZTNXU2o2?= =?utf-8?B?MzhnUUMwanVRbU5HSlNtd3JUaVUyMURrV1V0dUxMOFJGcUppbjBmNUd0SWNC?= =?utf-8?B?QU01UHVqeUd2Z0c1NnJMd1lpdTZPL0lFeXZDc2pRRDA2TjVIRXlQdXhiNU56?= =?utf-8?B?TnBBNXlqdnRpSEFXcGRlWVJmRGhpTjVBdWgzWU50WUpyeU9MdDM3WUx5dU5P?= =?utf-8?B?Z0FLekdlN01vOFUxVTdEK1RVbS9BRVVvVGJZRktqbHduMnNCaHNJV0syR3F0?= =?utf-8?B?OVVyN0xQd1o5c1YwQlZHb2lHRnUzaXVrbUFwTHRzazVFRVovYVN5dlJFVEUy?= =?utf-8?B?eUMzVmlWR2crb0tJVmxoSWVqZ051dkt6VlBGZ2c2ZWlPTUhEa3B3Y2Q2akpP?= =?utf-8?B?S2hNVUhjTHRKNDUvcXBDQjErOWFKNUhINXJvRHIzNnVqV2ZJcHhtKzRpRkRE?= =?utf-8?B?eFRGeitZMjJwSDB2bzdWQmZKaXBsREZ0Y0VRb0pwVzNPTUVqZWVZZ0pTc1U1?= =?utf-8?B?VnNlRTJHdmtpUE9LRmNwdUNUWmEvc1ljNWZnL2hheXhWMGFEcHFSRXdIVDQ2?= =?utf-8?B?cXl4YWtEcXJ2dVAxM05EQXRsT0RNSHNMcnUrVVA0eHQwVnBNVy9yRlNCZ0Nl?= =?utf-8?B?YjhJeWRLbVBvMlRhU0R4aU9maDhDS3JoWGhKVWRPTjhwaDJFR3VmVG15OWxP?= =?utf-8?B?enkzc2JrT2xUVTNoWjYyWWVqQUJLYnpHTklPbWtYdWh6ZllYVlhYQXY5UjV6?= =?utf-8?B?em92L2JrZ01UMkVFTHF6cllBK1c5UStKRWZRcTJQdlNSK3c5MzZnekN3cWhk?= =?utf-8?B?NnVwZE9QYWdLQnpwOCtKdGM3eVZ6d3F5V2JTeDJ6VEhSVno3Vml6ZGYrOXZs?= =?utf-8?B?R0x5cFZLSWtVMHMrWnZ5ditGeTRaR3VTZTBOZnhNMzhPTzZtclFBci93VWVW?= =?utf-8?B?S0hTTVdSMituY281Y1FVcmtsY0tKYWRsTWtwYkdOcTk1MEx4aTlxcmFGZTcy?= =?utf-8?B?U1B5YXE3MGgydUFLV1dsWDJiZDdqOW51ZzE2S3c4V3BnbXIrUGVTSC8rYW9B?= =?utf-8?B?cjV2VzAzTzk1L0toSW03TEJkV3luRUhPU3JXOGtSRjgyaW1KNzNKZkF5cG95?= =?utf-8?B?VTE4ZFhIbTByWENFYjVLTFZvZXVZM3RKWHZLY3kzS2NnalFxazNaak5tSnEw?= =?utf-8?B?Z1ZwTDd2eW5lN0lqcG5NdkdEVjh1VzA1QVVMVyt0M1FKZUs4QTFMZDBEZmFF?= =?utf-8?B?dDBSSkVkNDNMUlQvbUNTZFdsYXhQZTBrL2ZYWW5EbkdxMU9tNVhmWEtTbGsy?= =?utf-8?B?UEZRV2MzUUc5N0lwUEN5dzN6OTJCVVk3WitSTE5hYSthcThzWU4yUlhGdXl4?= =?utf-8?B?NXRNdnhoWnZXd20rd0E4R3RzOVV2Smg1MW5iUWViTWpIZkhqcllDaUFQckdI?= =?utf-8?B?R0pNTXlnUmUvUXc5czEwb3FUYVV1Y3RoUURuOUpGN2hiZmNuMG5CcGpDVU5l?= =?utf-8?B?Ync9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 575ac782-a4ea-4436-91df-08dce2190992 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 13:00:34.7233 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CKbgq3KZUztYRW4uHZpbZz8974dytN4eB2kxDK4OziNMYs58oPKIFZJ2xd18bRsD3Ll+fJdg0JbE4n2lCtWbQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8650 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 01-10-2024 17:38, David Marchand wrote: > On Tue, Oct 1, 2024 at 12:19 PM Thomas Monjalon wrote: >> 12/09/2024 10:26, David Marchand: >>> Those debug macros never worked as existing callers never passed a >>> 'level' argument. >>> Remove them. >>> >>> Signed-off-by: David Marchand >> Why not removing the calls to these macros? > I was unclear if the fmlib enters the "base driver" category. > So I simply removed macros from the header providing wrappers to dpdk API. > > Relooking, I see other changes in this directory, so I agree I may as > well remove those calls. > > Hemant, opinion? > Yes, fmlib is a common base library. So, it is better to not remove the calls.  Otherwise, we have to maintain the changes from base. with that Reviewed-by:  Hemant Agrawal