Re: [PATCH v4 00/18] NXP DPAA ETH driver enhancement and fixes

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 9/30/2024 1:15 PM, Hemant Agrawal wrote:
> v4: fix clan compilation issues
> v3: addressed Ferruh's comments 
>  - dropped Tx rate limit API patch
>  - added one small bug fix
>  - fixed removal/add of fman_offline type
> 
> v2: address review comments
>  - improve commit message
>  - add documentarion for new functions
>  - make IEEE1588 config runtime
> 
> This series adds several enhancement to the NXP DPAA Ethernet driver.
> 
> Primarily:
> 1. timestamp and IEEE 1588 support
> 2. OH and ONIC based virtual port config in DPAA
> 3. frame display and debugging infra
> 
> 
> Gagandeep Singh (3):
>   bus/dpaa: fix PFDRs leaks due to FQRNIs
>   net/dpaa: support mempool debug
>   net/dpaa: improve the dpaa port cleanup
> 
> Hemant Agrawal (5):
>   bus/dpaa: fix VSP for 1G fm1-mac9 and 10
>   bus/dpaa: fix the fman details status
>   bus/dpaa: add port buffer manager stats
>   net/dpaa: implement detailed packet parsing
>   net/dpaa: enhance DPAA frame display
> 
> Jun Yang (2):
>   net/dpaa: share MAC FMC scheme and CC parse
>   net/dpaa: improve dpaa errata A010022 handling
> 
> Rohit Raj (3):
>   net/dpaa: fix typecasting ch ID to u32
>   bus/dpaa: add OH port mode for dpaa eth
>   bus/dpaa: add ONIC port mode for the DPAA eth
> 
> Vanshika Shukla (5):
>   net/dpaa: support Tx confirmation to enable PTP
>   net/dpaa: add support to separate Tx conf queues
>   net/dpaa: support Rx/Tx timestamp read
>   net/dpaa: support IEEE 1588 PTP
>   net/dpaa: fix reallocate_mbuf handling
>

Patch by patch build fails [1] on following patch:

[PATCH v4 14/18] bus/dpaa: add OH port mode for dpaa eth


Also there are some valid checkpatch warnings, can you please fix them:
https://mails.dpdk.org/archives/test-report/2024-September/801309.html

WARNING:TYPO_SPELLING: 'assited' may be misspelled - perhaps 'assisted'?
#8:
This is an hardware assited IPC mechanism for communiting between two
                    ^^^^^^^


[1]
../drivers/net/dpaa/dpaa_flow.c: In function ‘get_rx_port_type’:
../drivers/net/dpaa/dpaa_flow.c:648:30: error: ‘fman_offline_internal’
undeclared (first use in this function)
  648 |         if (fif->mac_type == fman_offline_internal)
      |                              ^~~~~~~~~~~~~~~~~~~~~
../drivers/net/dpaa/dpaa_flow.c:648:30: note: each undeclared identifier
is reported only once for each function it appears in
../drivers/net/dpaa/dpaa_flow.c: In function ‘dpaa_port_vsp_configure’:
../drivers/net/dpaa/dpaa_flow.c:963:30: error: ‘fman_offline_internal’
undeclared (first use in this function)
  963 |         if (fif->mac_type == fman_offline_internal)
      |                              ^~~~~~~~~~~~~~~~~~~~~