From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 30AFC4414A;
	Mon,  3 Jun 2024 18:12:14 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BD96C42E4A;
	Mon,  3 Jun 2024 18:12:13 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 1FFAB42E38
 for <dev@dpdk.org>; Mon,  3 Jun 2024 18:12:13 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0B1C1042
 for <dev@dpdk.org>; Mon,  3 Jun 2024 09:12:36 -0700 (PDT)
Received: from [10.1.36.170] (e132843.arm.com [10.1.36.170])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4374A3F64C
 for <dev@dpdk.org>; Mon,  3 Jun 2024 09:12:12 -0700 (PDT)
Message-ID: <f385e49f-c5f7-4096-b268-f565ef4d462c@foss.arm.com>
Date: Mon, 3 Jun 2024 17:12:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs
To: dev@dpdk.org
References: <20240603160119.1279476-1-jack.bond-preston@foss.arm.com>
 <20240603160119.1279476-2-jack.bond-preston@foss.arm.com>
Content-Language: en-GB
From: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
In-Reply-To: <20240603160119.1279476-2-jack.bond-preston@foss.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 03/06/2024 17:01, Jack Bond-Preston wrote:
> <snip>
> +	EVP_CIPHER_CTX *ctx = EVP_CIPHER_CTX_new();
> +	EVP_CIPHER_CTX_copy(ctx, sess->cipher.ctx);
> +
> <snip>
This, and other patches in the set, are throwing a checkpatch error:
> _coding style issues_
> 
> 
> ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
> #99: FILE: drivers/crypto/openssl/rte_openssl_pmd.c:1593:
> +	EVP_CIPHER_CTX *ctx = EVP_CIPHER_CTX_new();
>  	               ^
> 
> total: 1 errors, 0 warnings, 41 lines checked
Which I believe is a false positive - is it that checkpatch doesn't 
recognise the type EVP_CIPHER_CTX and thinks this is multiplication?