From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1F8BFA0093;
Mon, 18 May 2020 16:53:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id DD2191D174;
Mon, 18 May 2020 16:53:10 +0200 (CEST)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id 634C41D171
for <dev@dpdk.org>; Mon, 18 May 2020 16:53:09 +0200 (CEST)
IronPort-SDR: eP461OJdu17/p7BlNAszqPHXg8Qm8K2oJZCV2kZWvuX7RPY+pm/YgRdFechtDYGLf8Zh1IlxIf
RMnKmXzZt9Yg==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 May 2020 07:53:08 -0700
IronPort-SDR: 62p8Auy5mwTlRLCJcgAat0SU8RRE3I5FnIDFfaUZi2wPL3hFR7c30p3+AR1oqPG1xEMInzHF6u
khzCXIaqEQSA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208";a="465602748"
Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.252.4.195])
([10.252.4.195])
by fmsmga005.fm.intel.com with ESMTP; 18 May 2020 07:53:07 -0700
To: Ciara Power <ciara.power@intel.com>, bruce.richardson@intel.com
Cc: dev@dpdk.org
References: <20200512152902.70211-1-ciara.power@intel.com>
<20200512152902.70211-6-ciara.power@intel.com>
From: "Laatz, Kevin" <kevin.laatz@intel.com>
Message-ID: <f3887a3e-ccb8-aabd-d162-d1e241699f6b@intel.com>
Date: Mon, 18 May 2020 15:53:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200512152902.70211-6-ciara.power@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH 5/5] telemetry: fix buffer overrun if max
bytes read
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 12/05/2020 16:29, Ciara Power wrote:
> If 1024 bytes were received over the socket, this caused
> buffer_recvf[bytes] to overrun the array. The size of the buffer - 1 is
> now passed to the read function.
>
> Coverity issue: 358442
> Fixes: b80fe1805eee ("telemetry: introduce backward compatibility")
> Cc: ciara.power@intel.com
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> lib/librte_telemetry/telemetry_legacy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>