From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4BE73A04BB;
Thu, 24 Sep 2020 23:09:51 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 8DDB31DEF8;
Thu, 24 Sep 2020 23:09:49 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id 2A2AA1DEE2
for <dev@dpdk.org>; Thu, 24 Sep 2020 23:09:46 +0200 (CEST)
IronPort-SDR: 9IiTlYi7SwK10QgLKbkQVZBBHvScHAG8y746JpBRcVUKFqIxrPogQUetJ3w81QM1WC+JAqQpZ0
15IBziZwmCbA==
X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="160618543"
X-IronPort-AV: E=Sophos;i="5.77,299,1596524400"; d="scan'208";a="160618543"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
24 Sep 2020 14:09:46 -0700
IronPort-SDR: DIFdFjPIboe1vh06TPoOkg4IjVBIKiS+Qg+NP5j3lNv5tWECGmB4SeWggvcF1dxhGN++eUOKs4
zatNVCsdJQWw==
X-IronPort-AV: E=Sophos;i="5.77,299,1596524400"; d="scan'208";a="512338073"
Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253])
([10.166.30.253])
by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
24 Sep 2020 14:09:45 -0700
To: Tal Shnaiderman <talshn@nvidia.com>, dev@dpdk.org
Cc: thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,
navasile@linux.microsoft.com, dmitrym@microsoft.com, olivier.matz@6wind.com,
arybchenko@solarflare.com
References: <20200916104204.10432-1-talshn@nvidia.com>
From: Ranjit Menon <ranjit.menon@intel.com>
Message-ID: <f39c8061-2645-562d-edd0-cc4916ecd228@intel.com>
Date: Thu, 24 Sep 2020 14:09:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200916104204.10432-1-talshn@nvidia.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH] mempool/ring: build on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 9/16/2020 3:42 AM, Tal Shnaiderman wrote:
> Build the ring mempool handler for Windows OS.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> drivers/mempool/bucket/meson.build | 5 +++++
> drivers/mempool/meson.build | 4 ----
> drivers/mempool/octeontx/meson.build | 5 +++++
> drivers/mempool/octeontx2/meson.build | 5 +++++
> drivers/mempool/stack/meson.build | 5 +++++
> 5 files changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mempool/bucket/meson.build b/drivers/mempool/bucket/meson.build
> index 618d791283..61de2dc9b9 100644
> --- a/drivers/mempool/bucket/meson.build
> +++ b/drivers/mempool/bucket/meson.build
> @@ -6,4 +6,9 @@
> # This software was jointly developed between OKTET Labs (under contract
> # for Solarflare) and Solarflare Communications, Inc.
>
> +if is_windows
> + build = false
> + reason = 'not supported on Windows'
> +endif
> +
> sources = files('rte_mempool_bucket.c')
> diff --git a/drivers/mempool/meson.build b/drivers/mempool/meson.build
> index c9609f1453..7520e489f4 100644
> --- a/drivers/mempool/meson.build
> +++ b/drivers/mempool/meson.build
> @@ -1,10 +1,6 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
>
> -if is_windows
> - subdir_done()
> -endif
> -
> drivers = ['bucket', 'dpaa', 'dpaa2', 'octeontx', 'octeontx2', 'ring', 'stack']
> std_deps = ['mempool']
> config_flag_fmt = 'RTE_LIBRTE_@0@_MEMPOOL'
> diff --git a/drivers/mempool/octeontx/meson.build b/drivers/mempool/octeontx/meson.build
> index 3baaf7db25..b5695a9329 100644
> --- a/drivers/mempool/octeontx/meson.build
> +++ b/drivers/mempool/octeontx/meson.build
> @@ -1,6 +1,11 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Cavium, Inc
>
> +if is_windows
> + build = false
> + reason = 'not supported on Windows'
> +endif
> +
> sources = files('octeontx_fpavf.c',
> 'rte_mempool_octeontx.c'
> )
> diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build
> index 9fde40f0e9..0226f76d4b 100644
> --- a/drivers/mempool/octeontx2/meson.build
> +++ b/drivers/mempool/octeontx2/meson.build
> @@ -2,6 +2,11 @@
> # Copyright(C) 2019 Marvell International Ltd.
> #
>
> +if is_windows
> + build = false
> + reason = 'not supported on Windows'
> +endif
> +
> sources = files('otx2_mempool_ops.c',
> 'otx2_mempool.c',
> 'otx2_mempool_irq.c',
> diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build
> index 580dde79eb..8425772a42 100644
> --- a/drivers/mempool/stack/meson.build
> +++ b/drivers/mempool/stack/meson.build
> @@ -1,6 +1,11 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017-2019 Intel Corporation
>
> +if is_windows
> + build = false
> + reason = 'not supported on Windows'
> +endif
> +
> sources = files('rte_mempool_stack.c')
>
> deps += ['stack']
Acked-by: Ranjit Menon <ranjit.menon@intel.com