From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D9E3A04A5; Wed, 9 Feb 2022 14:33:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EE8941143; Wed, 9 Feb 2022 14:33:24 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 4F19540140; Wed, 9 Feb 2022 14:33:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644413602; x=1675949602; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=7+QuYwUP5qFP+lq21RjhAQxTe43lr8DaggKdpeS9W1U=; b=kZWQXi/TyZ16UXBot694G2TtnYfybiSsfr75+rYXwmkN0jbAVQcPZIyZ lQcPRSDBEuHGDv/SF8wwgW+IcGcUS4IMICWbh3i6MO9M46EjgkCNawMVf OMesK6AI4PoGCwNSoLJ7p/taKhnoSlcaeTZHiyyp3Vy88SCZxusFzZvaV Pn2FSsaROl3M4puIIPjsZ9z3bBtzcYw/RPIcnWUoTnTJAiLVH9Asdo1/h Eczef6qVQAIQ5zVdMCtdGWBHj1KGOQS+eXbmTf1ke3ztm/ZotctQ5q23f kwEyC9xmwB2Wi17d5ACP/ObszpmJXoMEdrj54Ihw8Bf4Pon38QICKraTk g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="229173119" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="229173119" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 05:33:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="633216828" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 09 Feb 2022 05:33:16 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 05:33:16 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 05:33:16 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 05:33:16 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 05:33:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IopiGY2bc+wI+txoDTwAArWzle1s6uiKo3uEMsQrSe5O93GYRFLJ5QAg4aO4kPkPcNOWp8r2kpV/1Z0mt5RgAjCXvKugZhXUoBEJYCtGkffcHj4aJ/JqJ8ygPKxjnEIz4+//H39DDBYt1jXP97fI8EQFqQDXLfVd8K2/vCbhHlUSB6UNxHfhw7DwpitpSMqFheVqdlNMFSD+wiPF9IivbtnDQfAYTMBs1aOgKmYiVCy8M3YeDjrZnGEjDliYZfXXdtrLICrS19mme8tHHopyce62VIetiOqwc/VPlO2cVPpwA8G6VmohmYoa2keRqBbFy8kzBieh5sriktWQIcs5NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YFkSg7g0g43IERWVBrJ3wjyjFkgOJq2zhVtVaVaHorA=; b=GddcrwvHvOd/4qC1GZl5hthYpeSK8SOeigW1dBOBOKX6MpguIylYy7Uw6cLOljlr2cdINViLNTt91VJ2K8q5m3OtESg+7vZoUgEnQgiqenPLpSsYnWpkyMII8PRAQXZFYhmrBLUM77aMJE7/uNkJSWhSlNxGoT/yugxYrRDc9IjhyxufeILxlbuliMiNcK9iMHMRsspH1z55lImRmZQBsU0eBqhgIx5E/56eNOtfAbUTb3cfu88URPLEQ8qY5rofFZesYPs+W1CMlf/pdKMmIS+BAgOWp5sohQ/q0akAVmi4cD8kPCx1Aq6LcCPbog959bI+cWFIsRnL+Lz78Cfalg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB3414.namprd11.prod.outlook.com (2603:10b6:a03:85::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 13:33:12 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 13:33:11 +0000 Message-ID: Date: Wed, 9 Feb 2022 13:33:05 +0000 Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Content-Language: en-US To: "Wang, Haiyue" , "Daly, Jeff" , Stephen Douthit , =?UTF-8?Q?Morten_Br=c3=b8rup?= , "Lu, Wenzhuo" , "Zhang, Helin" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Wang, Wen" , "stable@dpdk.org" References: <20211206221922.644187-1-stephend@silicom-usa.com> <98CBD80474FA8B44BF855DF32C47DC35D86D8B@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D86D9B@smartserver.smartshare.dk> <0f4a78d5-df1d-fea7-6e5c-15ea07d80886@silicom-usa.com> <323a1ce1-1e0c-5b0b-87ea-a70033b264a3@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0440.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ded9c28-0c00-4e56-995b-08d9ebd0b791 X-MS-TrafficTypeDiagnostic: BYAPR11MB3414:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OCuEq6oRksLvIQmGii1e7HbnR4UC0rOLyswvVLxG7Vm6mPlANQUD/tcDQIYcGLx4DXuOzoJPLRLrbCWx4lxa4zVlfaUzDrEKXE6vCj8BuEVww5qmkR7Ko01oq90VuWhyrOJ++M0/uwyM+SQjjtMAFcFDHltNrL+9zbmzz+xXuoh9iHSmRRKGjy6wIP8hz7BSWqJZILZm1A5dZRU3WEbLe0gJC7ul666XdP7OsYUQXj+XOTAu9A8LiR6pEapIy/x3D50qe3lSicum6MWGKWntfjkU5KmvYyHq7Y5HY2x4+ITqnjOrT3fZsSNU3Njv5GOwrtNnDDhwNl+igRgSArGy9HLr0S3LSlU8z82vlxk2DSDG7IkOwu36UfjUnZEgUGAExKtCj2ylDNYjpptGF4UIv9UL1eFFscNPYWnMzAy2/qHn2VHFLO54rfb6UiQcnIXmpUrAwgNLnoiHvMP1IS99ox06n38+ABWT6KCA2ObKn27iUWpy14PDb1lZ+2oK70y+IQQTxIZfiDl4TmYFKHIrL5b1/LOE+7vokHcc35bAFh9rtw5Mc8kFjy0FDI778804/xa/NV1+Sz9pLdra8rP7HFqJL/85CsThb7bpyGKWgo5SHqOtvUj8gHCaJnmMeGj+pommOKhclfjtvoAtztXPNc9yt83q8KZkymnV4hudg/WxKchwsuTAu4veW2fsMXTgT9x+cHj07nucH19AqUyuUs9A9Da5ufSy7+qFk9aZ90Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(66476007)(66574015)(26005)(186003)(83380400001)(66556008)(66946007)(8936002)(6636002)(8676002)(4326008)(5660300002)(31686004)(36756003)(110136005)(54906003)(2906002)(2616005)(44832011)(6512007)(86362001)(53546011)(55236004)(921005)(6486002)(82960400001)(31696002)(6506007)(38100700002)(508600001)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTVsN1FmdVBLQVpnRWhHVG5QTXhHQzcvNjl5WVNyb3kxUUc5eW1XOXRNcEs5?= =?utf-8?B?ZlZFWGlsMXFBNHY5Q2xlWGRZTjZOd1UrbzhQMnEra2xZb3NXRmI5eWRCb2pk?= =?utf-8?B?QmRPa0dBSnVPWHJHVzdNUHpBejBRdyszVEFLcklmTUgzdlRkakJmcko2OEV1?= =?utf-8?B?SFBNMEdNM29LcTN0RThUTjZYMW16WHpQM09jY3RIeGVWS0NNaHA4TnVFeUFQ?= =?utf-8?B?a0Z0cHlmeEx5SEpvcmpJeDZYR3hVWk1qM2xpNUYxLzZWQ2ZPZEtrVWlwTDha?= =?utf-8?B?Z1dXQ3ZBV2xOUDlpNGc1eGlidloycWVSL1ozeS9ZUjJVYTBqNGFsKy9TRGx6?= =?utf-8?B?ODAxRUZVNmxSWG1abjV0L3NOdjI0aFlPN0NCNStvbGh3V0czNnV6VmNMQTcv?= =?utf-8?B?WDdJa3JTOEZ5UUl6RHg4MlcvaDV2cFltN1BUL045VzY1YUNQdDkvUFhUR3Na?= =?utf-8?B?QWVpZTh6blRLS1BkTHAxVjVXYWhpVlk3TnFQS0RxU1hITTVaZVgvMHdXeVZ4?= =?utf-8?B?MUJsZ1pjdDhERFZJYzFsa1NYT3QwQ2k4ZkRJWlFqOFdkeXl5ZFR2MlE1aXFL?= =?utf-8?B?SjBaZDJPSEgyenlFbnZXbzA1MTU1WU5vcVRMZXUwVjlYMTBCcUU2Y3ZlMHZo?= =?utf-8?B?WGo4UVc4dkNsU0tEcEtFWVBuQlJJNU5vKytGekdLcko1Z1NKRENzcHR1YjVO?= =?utf-8?B?akhyMnVreU5TNDFhQldRRE5OVGUyMHBnbFY4QUlRQ2lrb2N2ZzBTWjZSRjZt?= =?utf-8?B?NjA3S3kvYnhaNi9yWTlrRjdsRU5HWnh6Y1RRTDBrS1R4TFpxdmxLYUJ0UnhM?= =?utf-8?B?ZDVaaVl6U0ZlSWRlWWpuLzBYcnNtb1pvTTRKZjRkczNtVlBuMVoxWlZLZ1dn?= =?utf-8?B?R096WHZUblJaN2t1aExpMU1YNHFBdDVqV01LT2o4N0c4bklGUlZUa0lsZVgy?= =?utf-8?B?am8wN05tYVV5QXpsc204eU9zcjU1N20vYm8xcVBRZ0ZKN3JEcVNmWC9aYXV3?= =?utf-8?B?VHFVUzVOMWoyTi9Rb1BCSm9tUTYwN3Z5Z3BFdjFud0JXbzJ3ZzJ2ODVlMjNE?= =?utf-8?B?WUczRlA0UTBFNE8xVThTNmJJQlU5Y3hrQ2JzWWI1UnVkbnRwVEtyMlJXQkZB?= =?utf-8?B?Qnl0a3JZYVkycm1QRlZ3ZWJnUkd3czFlWldnZFBOV3gzZDdhaEM1NkNmYVZH?= =?utf-8?B?U3BoNStyRmVCSEUwSGpqdzdWV0tvbEkraHVKaDdtRkRGbG1Za3lBV3ZUWTVi?= =?utf-8?B?aVhBd2xmd1RCQXpXM2tLSmtUd3NrMHlFTDNLOFU2YmdKellqVno4YlJmTzc2?= =?utf-8?B?UzV2R0dMb2ppRzU4US9TQ2YzMnRZK1Z0Vmd2c2xrOU92Z1hhOFQrRTVLR2kw?= =?utf-8?B?akNTcC92Z0ZlODNBVWlxTEkyTnRrT0dqSFlwTkMrY3dQWVNROVJwMVVnWWFr?= =?utf-8?B?TlVzMnZSWDIzV2g1NmpISG5BclVXYXV5ZExFVFFRYUF3N1l2SmFQT2NWcHdm?= =?utf-8?B?dnAyZVZjRm5GK0hqOTBpdnZFa0c5dWZGNVJDUFpDYmpXZnlOa0w4YnRyLzRX?= =?utf-8?B?L2JXSVlMSGpFTDNudTFZZ0RsdWYxZnQ3VkI2OWdQRitGUjlTUCs0ZmRqYmlS?= =?utf-8?B?M3YwOEZZMzBXTnpCZTFsd2F4MmxyckdoY1lpekRnVG9nMU55WkZRaGNqVHFV?= =?utf-8?B?UDRETUJzWWlRWTA5UXlxN1VNWUx5N1l2ZlQ3ZXJtL2pFQnhrY1hNbFdtL2pR?= =?utf-8?B?d0pSaDM5VU9CKzJXQ0YvZEkrY1JDcHpKTjliU1RmdVRZU2xhZGNrdE01dEdS?= =?utf-8?B?Vzhub001c1ZlV2x4c1J5QUpsenJCbS80QnMzWkdDKy93ZVR0dk52QzllNGQ3?= =?utf-8?B?QlZXTDI3NGJ6Z3lwNGNZRUxWUTYyMUZjeXowTWxxRUpIK1lzczVub09XS1RE?= =?utf-8?B?bnlOWFRwbE9yRk1BYlVDOFlSc2NkQlMyRjl3eUZBM2hNRTIrK1R6RE93QTdS?= =?utf-8?B?S2gxSW1wTm9MUnZkOEhGYnJsQ2FrdzRHdjB3UFN1L005RWVhT2dSRmM5d2Y5?= =?utf-8?B?bFcwMkRacGJxU3ZaaFNzT1RrNWs3OVRWQWtjN1V0b0g1MWU1NHhqYVRTemxy?= =?utf-8?B?anl4VnlXeGR5TWthSnFTWUo1U2tRaGs2cS9QUG03U2JXVGdEdzBQMTBVeG9k?= =?utf-8?Q?d+3IZI+/s2XMs732J4s29wI=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0ded9c28-0c00-4e56-995b-08d9ebd0b791 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 13:33:11.8101 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D/0P1jfhuzaYzPo4D1hLiLU+AZ7uCjchTaREp1BseJwOfZkKQI2bl471PqXR8HBv5a4lBQVmMrRggeKXWFCHPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3414 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2022 4:00 AM, Wang, Haiyue wrote: >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Tuesday, February 8, 2022 22:52 >> To: Daly, Jeff ; Wang, Haiyue ; Stephen Douthit >> ; Morten Brørup ; Lu, Wenzhuo >> ; Zhang, Helin ; Zhang, Qi Z >> Cc: dev@dpdk.org; Wang, Wen ; stable@dpdk.org >> Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write >> >> On 2/8/2022 1:50 PM, Jeff Daly wrote: >> >> moved response down, please don't top post. >> >>> -----Original Message----- >>> From: Ferruh Yigit >>> Sent: Monday, February 7, 2022 11:04 AM >>> To: Wang, Haiyue ; Stephen Douthit ; Morten Brørup >> ; Lu, Wenzhuo ; Zhang, Helin ; >> Zhang, Qi Z >>> Cc: dev@dpdk.org; Wen Wang ; stable@dpdk.org >>> Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before >> write >>> >>> Caution: This is an external email. Please take care when clicking links or opening attachments. >>> >>> >>> On 1/19/2022 12:31 AM, Wang, Haiyue wrote: >>>>> -----Original Message----- >>>>> From: Stephen Douthit >>>>> Sent: Wednesday, January 19, 2022 05:06 >>>>> To: Wang, Haiyue ; Morten Brørup >>>>> ; Lu, Wenzhuo ; >>>>> Zhang, Helin ; Zhang, Qi Z >>>>> >>>>> Cc: dev@dpdk.org; Wang, Wen ; stable@dpdk.org >>>>> Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate >>>>> select is supported before write >>>>> >>>>> On 12/22/21 19:55, Wang, Haiyue wrote: >>>>>> OK, let's see in 2022, happy holidays. ;-) >>>>> >>>>> A bit of a slower start to 2022 than I had hoped, but I have a v3 of >>>>> the hotplug fix in progress. It's now working for the 82599 and >>>>> C3000 ixgbe devices under Linux, and I'm in the process of getting >>>>> this built and tested under FreeBSD. >>>>> >>>>> Assuming the FreeBSD testing comes together smoothly my plan is to >>>>> split these patches into three series: >>>>> >>>>> 1) The SFP hotplug fix >>>>> 2) Refactor SDP3 TX_DISABLE 82599 link check stuff >>>>> 3) Support of additional SFP types under ixgbe >>>>> >>>>> My focus right now is on the SFP hotplug fix, so please let me know >>>>> if there's any additional feedback on that portion of the original series. >>>>> >>>>> Right now the feedback I have that impacts the hotplug fix is a >>>>> cleanup for patch 1, and the general comment that changes to files >>>>> under ixgbe/base are usually backported from Linux, and so I should >>>>> refactor my changes to live in ixgbe_ethdev.c >>>> >>>> Yeah, just put the change in base code to *separate patch*, so that >>>> they are easily to be reviewed, thanks. >>>> >>> >>> Hi Steve, Wen, Haiyue, >>> >>> Can you please clarify the above change request? >>> >>> I though it is related to splitting base code updates into their own patches, but that already seems >> the case in set (except from a few minor mix). >>> >>> And what is the status, is there a new version worked on? Or is the set waiting for more review? >>> >>> Ferruh, >>> Stephen has passed on support of his patches to me, I will be the main point of contact going >> forward. I'm still ramping up on the code, expect patch updates to come from me in the future. >>> >> >> Hi Jeff, >> >> What is the planned changes in the next version? >> >> I just want to be sure that we are on same page with the change request, >> to not waste effort/time. >> >> Haiyue, perhaps can you articulate the request again? > > Just put the change in base directory into separate patch (es), so that we can ask > different experts to review the patchset easily. > That seems already the case, only two patch has mix and that is a little (and related), can you please highlight the patches that requires split?