From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9BBEA0032; Fri, 1 Oct 2021 16:50:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41B1A4118A; Fri, 1 Oct 2021 16:50:41 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 2D5444067A for ; Fri, 1 Oct 2021 16:50:40 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10124"; a="225111721" X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="225111721" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 07:45:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="521130312" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga008.fm.intel.com with ESMTP; 01 Oct 2021 07:45:31 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 1 Oct 2021 07:45:31 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 1 Oct 2021 07:45:31 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 1 Oct 2021 07:45:31 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 1 Oct 2021 07:45:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SCjqi0Szh1PtfYWaC3UywdOmL3Rbdft02ku/vmq348qLMlQ27CVs3CF7mW5DUvSBty+Z9ViThSzjuhq3MaTzSuI3vzCNm+WTGK0vaDen5NojUUxOE5mHqAaQDWToYIDXiHMiU+Vd8DnurlwPwsEKW5IzUiNSGBJ1J6m/PgINwN/KPZunXOsdP9OAYbRK672FrpEGMbp12BxQTSKefNea/mEV+9vKXa5Zc2oIkw+voyQg1OGTzYCI9ZCrDxo9mMYO32ziap5tLcRe/ng2nFggZh7ZTtcXMEv8Zh23LlRc8ApIe8xH3oD/7iayz7r5Ofm09+RwllZRheCypaWGyzcRjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m9vb9Zu68cgqpSlGAVJCvecX51Kic11HgUA7W4J333o=; b=Owp03uRkF4Qc9gZ3GBxEb6vehf+rT5vnKMny86yGyNAUWb85FQj+b4gj1H9t/ZBFrWuzu9LRqCiqz1+YlHQlwDoBENlvAegn1iDwrQsF2Jy704SoaaU6KdGlN7pezPTJA+e7YmakSvOHOmXEuN5qkFtuom4EYBWtryBaNBF+kc9uQdMbIQYChjn0YynhE9AyVSmEUU8uBPHSy7yBo6zZcsYh0ys63uGeBuYME4+SVhVSEBd+n5aR96yCDy8F31U2VbQyQ3KpxBNnHSIn+oOnxw+U7VxnEcIllocEiGPNpAsCfSD3PqO34Jfivf5nFy+MKe5kWhX+YenEtacRqRrIEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9vb9Zu68cgqpSlGAVJCvecX51Kic11HgUA7W4J333o=; b=BIQKBeA6vnnm5dktodVw21/TKTC//WUJbnWUIhyriTo6FyLypUb68DWmRLnKAEaYpJhS6xVWnbWup6n9Fh6MYesVlP0sRD4mWHxuOExBjpSU0FOokn2dKVP4U4i29TS7vQY58jjfQ/elmAApVFPwwbNR7uQDtXlFchQ2kA++mLY= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5144.namprd11.prod.outlook.com (2603:10b6:510:3e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Fri, 1 Oct 2021 14:45:30 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.019; Fri, 1 Oct 2021 14:45:30 +0000 To: Apeksha Gupta , "david.marchand@redhat.com" , "andrew.rybchenko@oktetlabs.ru" CC: "dev@dpdk.org" , Sachin Saxena , Hemant Agrawal References: <20210909204314.1826-1-apeksha.gupta@nxp.com> <20210909204314.1826-2-apeksha.gupta@nxp.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 1 Oct 2021 15:45:23 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0301CA0102.eurprd03.prod.outlook.com (2603:10a6:6:30::49) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0102.eurprd03.prod.outlook.com (2603:10a6:6:30::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 14:45:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec4d0927-cbf1-4f27-1eb2-08d984ea1d4f X-MS-TrafficTypeDiagnostic: PH0PR11MB5144: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qlu1us67Z5mppDypPhz/8Wrn+iX3Kp+nZlbeKchZNKu1qU5k5m2+w/bpGRTPIMEjIRuxoedpAEtos+A2Qxbq71ajhynU0nxNgQxj4caqPwM0K6CAfD13WbtYgK12r2Ym8FsP8OpF5Cvfh9xZyDAF+id26cJ3mMBw5WpRdiTkYtyEhlUhH+wEoXVwu7/adNbKAqB4s+/IHd7vhEmK+QPo0untoqkcYZFf93v0u2bKeaFYyNct0uVOJU0+eVzvkKo14HvW0y3QaySWTG4QiXDof8D9beIPFbPDEujM3M62ksh1nSvw7CrbyLQWhHdYyLomApB32kNarwqBv0pxszPdJ3pWrnvQcXuXgFwmveINHVmRSjVxVdIIfIR7qDfXBNyKm9Z6Tbepfa8eg1Y7LmR3O30MMNQbtVdjILSn/geO/1jsNU1eIrk0bCVjjrVXlzpSrnXKs13v0kDrvLThV2Te0CF+SMjwmF9mgO47nOr4lruY3wYVAvZLGMKoCZ9UiYHzzanMyiApUVvynVfBDuh8z5U8FnA4t9h8ZQvIdzBIEoJYbWfM508hmRvZdekETa2PgrZ5CiD8tzVKKUgzoLeUbPFGJgpLEueHeoHV7HQox72oN2kZmr8A+wfdpuSWPnClEFDQJoDHK02NAgI1X2Svn4n6s6FpBN6OipY4YO5hwnBFCTaO5kgXI5RWuZLgteylwkAXMYJb0p7bjxWeikrxU2VPfIGs1oqn8weBhlav3RKv/9C0fyeVAtGsJoHIxcAm3vJZ4d4Q/bUdtiTyuYAbFRSpfpgstuJcvU/6uK8RgiA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(8936002)(66476007)(66556008)(83380400001)(110136005)(6486002)(16576012)(4326008)(44832011)(45080400002)(8676002)(6666004)(508600001)(5660300002)(36756003)(316002)(54906003)(31686004)(2906002)(66946007)(2616005)(956004)(38100700002)(186003)(26005)(86362001)(31696002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmN5WnFXYmhaVTE1OFJidjY4d0dlWG9GR2VCMEpNS0I4YXVsQUwzOXQ4djRl?= =?utf-8?B?L0xOSTdXK3p6c0wvRFZVQ01adGtYUFRUNElTNmdpbDJ0bmE4aTR4TmdCK1pY?= =?utf-8?B?OEJYd2tab1JrK3dQaTNOenB3d0R1bHN4R2RaemtQdVJISWVhNUxwVWpQajQr?= =?utf-8?B?dFZZQm9uNzlXdWc0S3k5bHcxZFo3SGRmR1ZCaTNwY1JUT1kzMTMzcUxKbi9w?= =?utf-8?B?Wmh2M0kzUkFONFg3UVdZQzA2RVpwZ2xEZERwSS92cE5yclNPTEh5RGV1SlpL?= =?utf-8?B?TTNDWkJvRFdwemtWLzJYbkVhRFE3VnZxbE5MVXorVmNRSkhJYTRqUHB4Uk1u?= =?utf-8?B?SytBdEVvZ0lweS9PbXQwckJzaXhTdjZEeHZOSHdlQm92L0lOSmFHN1EyaGkv?= =?utf-8?B?MlU3WUxPOExBK0pETEJjWGVYRkNKQVFBc1ZMZVBHczhuaHhHRGJGRFRSMHo1?= =?utf-8?B?bEpLNGFqTGFoaFJRbGVqMlM5RW1jY2cwN0FxSExpOS9pZlBzU1ZMRTA5U1p4?= =?utf-8?B?alVDanBmbW41eTZHYnphZVdjVGhiZHViUEY3alAwaS9RNWVPcXk3VXBCOXBX?= =?utf-8?B?TStoZHhQVGUwVHRuVEhlbEJITzI0OFZHbkV3UmZXYWRaWnVXTC9Rak95dmg1?= =?utf-8?B?RHFJWFFoY25HWWREeFBYUGFCcDVpbTJHUDRMNmFTcVdhK09yNGtLVThHOE9B?= =?utf-8?B?ZFh2NUt4eWg2NXM0cDNhT2IrY09EaVZReDYxbUR6dUcwS0xxdEtCZVQ4bTZF?= =?utf-8?B?YUZqeGFVcE4zSHpDdTFUUWdITDdoajNjeUpmQ0MreG1tejQxMWtZcGxyZU9m?= =?utf-8?B?angrZnBMN3JMYkhHL3RqVm0xYm1uQkdseVpXaitXejVnMjZlT2NpeDZ3b3Zj?= =?utf-8?B?QjBaV0Y0T0RVK1BYaDBGOEZ6Q0lQMTFmVnJscDdVZzNJSUJCa250czNxeU53?= =?utf-8?B?THdnZ1p5Q3hWOVZvWGRKUFBDNVlKZlJxUVlKQURkK1JzWXRwYmU1bldaU1pz?= =?utf-8?B?OTNhQ1VhMHF1YVRlbFlxYXRYOTczNjBGL00xSndZbzNFN0pXMHBQSDg5MC9T?= =?utf-8?B?QlJGRDliZnUzNlhkc3h6WmVNNWpZbGZIandyYTVEZkE1dnBhNC9TdWdianpJ?= =?utf-8?B?MlB6by95WGFYZjlLK2IxZ0hWM2x1NEJNSnB2bU9XeDgwMGJYSTArNkxNNUhG?= =?utf-8?B?QUlBelhpM2VUTkV1dmJWTnJ0NXJpYytJSWZxZlB1cVB4TzNTR1haMkpJNUw3?= =?utf-8?B?d01nekpWUUJwMERkZVpGYXhNV1dhT0luaVBqcE14SW4vNGJOdk5EV1dwNzdk?= =?utf-8?B?Mk8zY05mQjh3ZmhVbUI3enBrVTlWcjBndzRML0FTcGJUZHh2SXR2eS9kTzQr?= =?utf-8?B?SE1RUzZxcy95VXBVSnZ2SkY5M1JQZG1nUFhwdDk3RVNuTExPRjZMa3djUVNJ?= =?utf-8?B?b29ObUhyWjR4RS84RDhlenJLZkJCU044SSt3VFFkeFMrb2JiWkdSWmFRVHJ1?= =?utf-8?B?a3BaTE9sQXd1bDRQWXFxeXNLeDJCY1BoekJYNllCUHR3U1dJV1B5amE3dVk4?= =?utf-8?B?dFBJdVY3b2Y1L2tQbHpYQ21RL3loTHc3aEFUYmtpY2VVS00reVl1QzcvK2ZO?= =?utf-8?B?Mm5yR2xXNFlYK0xRa1RuUXVKWGk3aWFEY0hNMkd6RitueUY0V21Held2Qm92?= =?utf-8?B?eWtMcnZ3eDF5dm9iaE5VVDdrQ1Z2TjhSSmlMZ1NZN0xHMEhBczhEcDBKdnVG?= =?utf-8?Q?XV8ah4QhXifuMjrFGYpeVZCfeT085ohRHcxMfoi?= X-MS-Exchange-CrossTenant-Network-Message-Id: ec4d0927-cbf1-4f27-1eb2-08d984ea1d4f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 14:45:30.1690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W7EcJY2L/JXbOneEaXUxejZRDsiihhAiH8CB1borGe/uLDVGyydMToiunK1u3WJwXgNmNVK44O5cNb++xfxUNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5144 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/1/2021 11:22 AM, Apeksha Gupta wrote: >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, September 23, 2021 3:40 PM >> To: Apeksha Gupta ; >> david.marchand@redhat.com; andrew.rybchenko@oktetlabs.ru; >> ferruh.yigit@intel.com >> Cc: dev@dpdk.org; Sachin Saxena ; Hemant >> Agrawal >> Subject: [EXT] Re: [dpdk-dev] [PATCH v3 1/5] net/enetfec: introduce NXP >> ENETFEC driver >> >> Caution: EXT Email >> >> On 9/9/2021 9:43 PM, Apeksha Gupta wrote: >>> ENETFEC (Fast Ethernet Controller) is a network poll mode driver >>> for NXP SoC i.MX 8M Mini. >>> >> >> Hi Apeksha, >> >> Before going into details, I have some high level comments to start with, >> please >> find comments below. >> >>> This patch adds skeleton for enetfec driver with probe function. >>> >>> Signed-off-by: Sachin Saxena >>> Signed-off-by: Apeksha Gupta >> >> <...> >> >>> +++ b/doc/guides/nics/enetfec.rst >>> @@ -0,0 +1,122 @@ >>> +.. SPDX-License-Identifier: BSD-3-Clause >>> + Copyright 2021 NXP >>> + >>> +ENETFEC Poll Mode Driver >>> +======================== >>> + >>> +The ENETFEC NIC PMD (**librte_net_enetfec**) provides poll mode >> driver >>> +support for the inbuilt NIC found in the ** NXP i.MX 8M Mini** SoC. >>> + >>> +More information can be found at NXP Official Website >>> >> +> ww.nxp.com%2Fproducts%2Fprocessors-and-microcontrollers%2Farm- >> processors%2Fi-mx-applications-processors%2Fi-mx-8-processors%2Fi-mx- >> 8m-mini-arm-cortex-a53-cortex-m4-audio-voice- >> video%3Ai.MX8MMINI&data=04%7C01%7Capeksha.gupta%40nxp.com >> %7C74fdc59c47574d828f7608d97e7a4df3%7C686ea1d3bc2b4c6fa92cd99c5c30 >> 1635%7C0%7C1%7C637679886024819097%7CUnknown%7CTWFpbGZsb3d8ey >> JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% >> 7C3000&sdata=TjuqIfC8yXwBa3DLCgA7djItfV0UmZ6lA3uLDQ7TFwY%3D >> &reserved=0> >>> + >>> +ENETFEC >>> +------- >>> + >>> +This section provides an overview of the NXP ENETFEC and how it is >>> +integrated into the DPDK. >>> + >>> +Contents summary >>> + >>> +- ENETFEC overview >>> +- ENETFEC features >>> +- Supported ENETFEC SoCs >>> +- Prerequisites >>> +- Driver compilation and testing >>> +- Limitations >>> + >>> +ENETFEC Overview >>> +~~~~~~~~~~~~~~~~ >>> +The i.MX 8M Mini Media Applications Processor is built to achieve both >> high >>> +performance and low power consumption. ENETFEC is a hardware >> programmable >>> +packet forwarding engine to provide high performance Ethernet interface. >> >> It has 1Gbps interface, right? It can be good to give more details on the >> Ethernet interface. > [Apeksha] Okay. >> >>> +The diagram below shows a system level overview of ENETFEC: >>> + >>> + >> ====================================================+===== >> ========== >>> + US +-----------------------------------------+ | Kernel Space >>> + | | | >>> + | ENETFEC Driver | | >>> + +-----------------------------------------+ | >>> + ^ | | >>> + ENETFEC RXQ | | TXQ | >>> + PMD | | | >>> + | v | +----------+ >>> + +-------------+ | | fec-uio | >>> + | net_enetfec | | +----------+ >>> + +-------------+ | >>> + ^ | | >>> + TXQ | | RXQ | >>> + | | | >>> + | v | >>> + >> ===================================================+====== >> ========= >>> + +----------------------------------------+ >>> + | | HW >>> + | i.MX 8M MINI EVK | >>> + | +-----+ | >>> + | | MAC | | >>> + +---------------+-----+------------------+ >>> + | PHY | >>> + +-----+ >>> + >>> +ENETFEC Ethernet driver is traditional DPDK PMD driver running in the >> userspace. >>> +The MAC and PHY are the hardware blocks. 'fec-uio' is the UIO driver, >> ENETFEC PMD >>> +uses UIO interface to interact with kernel for PHY initialisation and for >> mapping >>> +the allocated memory of register & BD in kernel with DPDK which gives >> access to >>> +non-cacheable memory for BD. >> >> Why a specific uio driver, 'fec-uio', is required? I think this is the major >> issue to clarify to proceed. >> >> In DPDK we have full framework to support uio, to do the all memory >> mapping, >> interrupt configuration etc..., common to all drivers. >> But in this case driver is implemented as virtual driver and it handles its own >> uoi handling itself. Why the driver can't use existing support and >> implemented >> as physical driver? > [Apeksha] Yes you are correct. As per our knowledge, UIO framework is there for VM & PCI bus devices and not for vdev bus devices. That is part of the comment, why driver implemented as vdev instead of physical device? What is the actual device bus?