From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C74E42DF8; Fri, 7 Jul 2023 14:47:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E3BA406B5; Fri, 7 Jul 2023 14:47:16 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2054.outbound.protection.outlook.com [40.107.92.54]) by mails.dpdk.org (Postfix) with ESMTP id 3F0E040685 for ; Fri, 7 Jul 2023 14:47:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHCjzEWAbYFyMKAYYKVAunwcYa7LXMe2/GyaAJDw9mGsE0VE01Y9ODRR8rNqezS5FRX+WFWcaz9rF4SiiYo05H2tjvuoDCnI6mgE3XEfTEdIBq12AzoTZSiRMwbKXZ96+eLftXXaP1eQviCVpTU+kdWEz28irmS8XqCiaAyBAFw/t/C3Y6/XvYMyuGtucgK87pspLBGnZAoqHr+Ky85FE0u3ddLRjvXQROTCHCtRUsPRqpPRj116JzB6q3gm3mI5MhbZuKqmyzNTYffb5u0E/q42KQ+hLWpF+I8ORmCNCIqHtT6wGpnnCzZI0e/Aop7CMXvALuMZV44twna6eDufnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lhUJwMILUH+wr8wWV3ac6lnP8k/5xerZ23pySHusjAA=; b=BFdB9hr18lh5qjPnWewUrMAh/GdzEUPbijILgLYJQ7r2SQTuK9Eb8ph29w+0tz+wl+qP0m6xXXwJIqlubrSAYwT7xxTXDITLsBAZKYn8DtM0FE/XBKz3/RAEai6fb/XcA9waK247zsgn7w/A7C2uWn1HZyUosvNO4oHevpecChkqftYZM9mCOiZPL9okjPI2KmT5KhIG9160BQJEQd+Ze+VnwMFdEHBFHKZglgY+quI1DX9hnF0gSXmcUwdhSfRVL5wgTfXMlkJVB8+dpeViTpluedHJp9ZdOh8gsOlJP2xqcIVelF52UL9+DW/BqS9Kb4R1IM4Haazvqkz1hbaxxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lhUJwMILUH+wr8wWV3ac6lnP8k/5xerZ23pySHusjAA=; b=z+oVfKIi1eHJoa69rqujb3hj7tI1+sKCAkt1yxe9U3oIOmMXygzjTNbRytegfEFdsoHJCZvfCtlzyBe4JQi3Vr/rg1ZcF/DmEoEb+2wGVKYMcYulkQT0TzZlKIS+7jAueGGEl/MhRA9bXUjlxxQt4/TBPUogtD/Wwd/kGj6fFqU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5255.namprd12.prod.outlook.com (2603:10b6:208:315::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.25; Fri, 7 Jul 2023 12:47:13 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6565.019; Fri, 7 Jul 2023 12:47:13 +0000 Message-ID: Date: Fri, 7 Jul 2023 13:47:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Stephen Hemminger References: <20230505174813.133894-1-stephen@networkplumber.org> <20230706175938.62721-1-stephen@networkplumber.org> From: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH v3 00/14] Use rte_pktmbuf_mtod_offset() where possible In-Reply-To: <20230706175938.62721-1-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0175.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5255:EE_ X-MS-Office365-Filtering-Correlation-Id: 6583c97b-0abf-4c31-b183-08db7ee8495d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9QUNXewWCufoePzwGMaW9MC+gjiFIZq/Q/KlAFC0sQ16r2B/FFoe9RY3cxtxoiL1vh2vUQFrpXuYhDfYHLdYLEJPijVjBP0qk9yJ9sN0U2cm1od/aNQtJ4nBkno3V2RKcWtZFx6I+BxsLVkMiBkaP+eVKSdCM9Es0ZC9HEibT6r1Au4R+yyOVtg9a25BkKfSCRZfr441955c5cmhd+6abaxcTK5MInQmGFAXjOs8XyU4ZzINaAGr57dnlJkJVJ3KzM1XWaXwsUAce3I2eKKyFugCPnphtMZJedmJEtw8cCep+kxpW72JpEpL2mggypDdaeV42RdiKwtg0fAG19QYEqoXi7WNtJ87rWPpj/30K+gIFiHHFXBwiTeCLotYHpVYDXJgbDkjJ2uErrha+eg7h5ultauvSsXuGaU31nLVaFiqN972HzPz4LKKVqLMWvoOluaVMorXsldlU25cr1TOIODf2OBVsb9CocEc1PMntk7z3P+qj03LlKMLt8VDWopnhgWVL3R9M/+iN6mfZDo+TR0FQgNL2H4/Tc5C4htMGO1JV5qaXOXealeRBNNr+ZjONcu4Lm2JvoaAyw6J1+7a43TndJR6BWC98ykxjgobe4BKZkkJ1UVGiXU5JjI1fIwr651a6zad+aXuj3a9JogMtA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(136003)(396003)(366004)(39860400002)(451199021)(316002)(38100700002)(31696002)(36756003)(86362001)(31686004)(8936002)(41300700001)(26005)(6512007)(5660300002)(6506007)(44832011)(53546011)(186003)(8676002)(2906002)(2616005)(6666004)(66946007)(478600001)(6486002)(4326008)(66476007)(66556008)(6916009)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejVoNjhqRXVlYVNDcm0xWmFlbThOOU5GcGFoMWpDQUlCVmZaQXRXVFYxcTFK?= =?utf-8?B?b0F1OEpXdE50Z1hFU1FNUU9uajlTU1lhcnl4OGN6TU92VExjVm93RFhHcTlD?= =?utf-8?B?dE51bHo5UmplaE81NU1YQk01VVgxL3FPQkxxVlR6OENNc0crUElnaENTZEkz?= =?utf-8?B?ZXVvbG5ybXFvcVl1b0picG5SRjNoVU5MZS8wbVBacnhJMzdCU2RPSXJPU21s?= =?utf-8?B?bitrSWpBUkpTNjhKVmRFSFQrUG5HQzMxMW1CWTRIdk5BdWxXVUVrQ1JsaTdS?= =?utf-8?B?Q1EzRVc5aWhCWWEvd1V2eFlWdzVySTRvU0hJakEzRDMvd201OWtpV29WL2M3?= =?utf-8?B?cHhlUllKSDJSQTdGOGc5bnhwWjN1MEFoNVJzdExNZU9wSGZ5RFN6M0ZJL0ZQ?= =?utf-8?B?UGpPbUNEY3NmeDJLM0JoMGxwVFpxN1ZnS05Yc1o5ZThKa0tpdWFTVWs3THNn?= =?utf-8?B?MDNyUk1XditGNUY5d3FhYzVVMkI4ZTVBaTFIYTJHVHo5VDNjNFYzY2ZGYnVH?= =?utf-8?B?SlZRQ3JlWStIZ2dlcnBpbU93YlBRNXVTS3NPMXRGUTdyUnkvL09QREFrR29Q?= =?utf-8?B?NXNSU284cm5iVWF0L2ZjU3RHbEhrVDlyZU5ORjM5UzQ4NmpZRXRUMWJJWHJH?= =?utf-8?B?ZlJTT016U3EzaGh6TVExMlExMm9LMTZldTNHeWIxRjF5UXd2T3hpcTFUWllI?= =?utf-8?B?TDEzR0lnUDhyWktQYlgzdGxWalhPbzlESkRzMUs2ajh6TVBnWXRlU25NSHJV?= =?utf-8?B?ZGVHandVdDlTNGN4cWZYekZoanIyMVR6MitaMU42SlJXUUQ4TXlySmtOR3Vv?= =?utf-8?B?Mm1oSGFFYU1XUWNBb1oyUnAzcUF5T2tqMEVvZFd3M0V6ZlVWVFB3d0o1bkxL?= =?utf-8?B?SmNiMHQvMXdYK1ZUa3o3eGdLSXZsZkZTUEhyYVk4b241M2VIZXlabFphTng1?= =?utf-8?B?TW1WOC9hemdScEhEVkpwampXMzdzV1AyWU5xdVNGSFNoRVJnU0wyeEcrVG5p?= =?utf-8?B?cmtLeFdGNFY0d0ZRS2VscjRrc3VOalJoeXZhZk9zd2FNaFZyaEZ2YTY1blJn?= =?utf-8?B?K2dCemZXQ3dkV1B2czdubG4vUy9Wc2dTU2F6aVhwV3d3Wk1sSUI4SURMQVhU?= =?utf-8?B?cjgvTFFtbWtDbmgydEF4REVZZHFHYVBFTlM3MSszMDFseUlrek5Oc0F5WDUw?= =?utf-8?B?MS8xTlVIU3orL0YrME1LbzkvSTJraHYyVkI5aXFMQmdEYXRmWGsxcE93YlVu?= =?utf-8?B?SmRYeWZwM2gybWlRUjhvY2tOb2hyaUNieG13TjRwMXZvSkRGN3RDbnFvUExR?= =?utf-8?B?dGR2Z01WWmQvaGlaMUl6QTBDZGdSWUdaWC83aW9QUmt5bXFxaWk0TkR6dDQ4?= =?utf-8?B?Uk9pN1JKT0dhRUVxSjdCR0lXUWMzbWk3cExyKzBnNmRxYlR6MmRHMWRnS2Yz?= =?utf-8?B?TUtEcEErNUh2VDk4dk1ZcG9hblFLMWtOZjRzRFhwdmJpZElNdUdiM3g5NXFH?= =?utf-8?B?NkhOVys3K3VLSC9qUWFmTjJUdWxabXlBSU0yMHgrMm5IV1hMSEFkeUEzTXBm?= =?utf-8?B?disvNm4xWmpJdmV4dTExM3VoVG1LWCtYL2JGT1ROeGJPTEUrTk84UFlVL0tT?= =?utf-8?B?WlFoQVNGUzZJL1lvZ2preW9EaVpIb0NVR1dvdFpyNzFKaFRYclNtZlN6MXA1?= =?utf-8?B?VWw5ZG5NSzJDRERqdzFQQWQ4UE51RW02OXZac0dXUTNLdmhYQlUxWmd6dzcx?= =?utf-8?B?aURmSkdJaEg0dHQ3bTlVazVPbXdZVkZsL1BYQUNWZWwrYTNPcFdlMkJtbVd0?= =?utf-8?B?SmFpVTl4S0dBRWhzWUNkWkZOcTZCUUV3MGU0TEdIRzNEa25OVVUrZUtnTUhw?= =?utf-8?B?T2pJM0ZaeXNxQWFGZG12dnFhcElxUjkyNW1KeXRqcEdyOHRQL0lUdWlncENW?= =?utf-8?B?eFNCaTFvTUd3TjlKWE5iNWx0Q1VMaWFNcFdZRHF4Qm5oWTRMSm5kYjRUYTM5?= =?utf-8?B?V3BlYlNYSDBBUWFHVWxxYjlzM3BteS9lQUl3VXRVa2YzSVFzbmtTMy8ySDcw?= =?utf-8?B?Nm5hRVlMZHpHRjBqL1h4b29UZXF1UWRodlh6TmZwRUtlRjJUN093WXdCQ255?= =?utf-8?Q?ZBPdNm95vpywIlkVTLRhZUuZh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6583c97b-0abf-4c31-b183-08db7ee8495d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 12:47:13.3359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j4XBmQMkXTqz18EkmApYyx5IlB7+OT6wNsz/c3D3EMA9TO8xOSskiPed9wCCxg4B X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5255 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/6/2023 6:59 PM, Stephen Hemminger wrote: > Run the coccinelle script for rte_pktmbuf_mtod_offset > against current main branch. > > v3 - rebase to cover gro changes > There is one more instance in 'gro_tcp6.c' ``` $ ag -s 'rte_pktmbuf_mtod\(.*\).*\+' lib/ lib/gro/gro_tcp6.c 121: ipv6_hdr = (struct rte_ipv6_hdr *)(rte_pktmbuf_mtod(pkt, char *) + ``` > Stephen Hemminger (14): > gro: use rte_pktmbuf_mtod_offset > gso: use rte_pktmbuf_mtod_offset > testpmd: use rte_pktmbuf_mtod_offset > test: cryptodev use rte_pktmbuf_mtod_offset > examples: use rte_pktmbuf_mtod_offset > net/tap: use rte_pktmbuf_mtod_offset > net/nfp: use rte_pktmbuf_mtod_offset > crypto/ipsec_mb: use rte_pktmbuf_mtod_offset > crypto/qat: use rte_pktmbuf_mtod_offset > crypto/cnxk: use rte_ptkmbuf_mtod_offset > common/cpt: use rte_pktmbuf_mtod_offset > crypto/caam_jr: use rte_pktmbuf_mtod_offset > net/mlx4: use rte_pktmbuf_mtod_offset > baseband/fpga_5gnr: use rte_pktmbu_mtod_offset For series, Reviewed-by: Ferruh Yigit There are a few minor issues commented on individual patches.