From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6933F1B44F for ; Tue, 26 Jun 2018 11:05:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 02:05:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,274,1526367600"; d="scan'208";a="67333550" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.28]) ([10.237.220.28]) by fmsmga001.fm.intel.com with ESMTP; 26 Jun 2018 02:05:01 -0700 To: Kevin Wilson Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, david.hunt@intel.com, mohammad.abdul.awal@intel.com References: <02efa4a4e6fab105ae883a855ae1985afc208a31.1529940601.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 26 Jun 2018 10:05:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 9/9] usertools/lib: add GRUB utility library for hugepage config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 09:05:04 -0000 On 26-Jun-18 2:09 AM, Kevin Wilson wrote: > Hi, Anatoly, > > Thanks for these patches, good work. > Regarding "update-grub": IIRC, this is Ubuntu specific command (and > also used in Debian/Debian based flavors). > In Fedora (RedHat based) recent distros, you use grub2-mkconfig > instead (and there is no "update-grub", IIRC). > If this is true, I would consider adding a comment in the commit log > saying something like "it is for Ubuntu/Debian-based distros". > So maybe in the future someone will add the python code which detects > the OS (using lsb-release, etc) and, in case it is Fedora/RedHat > distro, the grub2-mkconfig util > will be invoked instead. > Regards, > KW > Hi Kevin, It wasn't intended to be Ubuntu-specific - that's just what i developed this patchset on :) Of course, if we get to a v1 stage, this will be properly implemented to work on all distributions supported by DPDK. Thanks for your feedback! -- Thanks, Anatoly