From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F99BA0C49; Wed, 7 Jul 2021 14:02:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CD21406FF; Wed, 7 Jul 2021 14:02:17 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id E44CE406B4 for ; Wed, 7 Jul 2021 14:02:15 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="188969700" X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="188969700" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2021 05:01:31 -0700 X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="482144667" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.24.114]) ([10.252.24.114]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2021 05:01:28 -0700 To: Anatoly Burakov , dev@dpdk.org, Jan Viktorin , Ruifeng Wang , Jerin Jacob , David Christensen , Ray Kinsella , Neil Horman , Bruce Richardson , Konstantin Ananyev Cc: ciara.loftus@intel.com References: <35fe15c47c0c904c181f381ea0c448449f5e7004.1625654882.git.anatoly.burakov@intel.com> From: David Hunt Message-ID: Date: Wed, 7 Jul 2021 13:01:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <35fe15c47c0c904c181f381ea0c448449f5e7004.1625654882.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v7 3/7] eal: add power monitor for multiple events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/7/2021 11:48 AM, Anatoly Burakov wrote: > Use RTM and WAITPKG instructions to perform a wait-for-writes similar to > what UMWAIT does, but without the limitation of having to listen for > just one event. This works because the optimized power state used by the > TPAUSE instruction will cause a wake up on RTM transaction abort, so if > we add the addresses we're interested in to the read-set, any write to > those addresses will wake us up. > > Signed-off-by: Konstantin Ananyev > Signed-off-by: Anatoly Burakov > --- > > Notes: > v4: > - Fixed bugs in accessing the monitor condition > - Abort on any monitor condition not having a defined callback > > v2: > - Adapt to callback mechanism > Initially I had issues running this as I couldn't see the "rtm" flag in /proc/cpuinfo, but adding "tsx=on" to the kernel parameters resolved this, and rtm was then available to use. Once this was done, I was then able to successfully see power saving when a core was configuired with multiple queues. Tested-by: David Hunt