From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/4] vhost: fix potential use-after-free for zero copy mbuf
Date: Tue, 26 Feb 2019 15:42:08 +0100 [thread overview]
Message-ID: <f3ff6b34-70e2-ceee-08a7-2d4b29265fd0@redhat.com> (raw)
In-Reply-To: <20190222024209.30879-3-tiwei.bie@intel.com>
On 2/22/19 3:42 AM, Tiwei Bie wrote:
> Don't free the zero copy mbufs before they have been consumed,
> otherwise there could be use-after-free.
>
> Fixes: b0a985d1f340 ("vhost: add dequeue zero copy")
> Cc:stable@dpdk.org
>
> Signed-off-by: Tiwei Bie<tiwei.bie@intel.com>
> ---
> lib/librte_vhost/vhost.h | 12 ++++++++++++
> lib/librte_vhost/vhost_user.c | 3 +++
> lib/librte_vhost/virtio_net.c | 12 ------------
> 3 files changed, 15 insertions(+), 12 deletions(-)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2019-02-26 14:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 2:42 [dpdk-dev] [PATCH 0/4] Some fixes for vhost zero copy Tiwei Bie
2019-02-22 2:42 ` [dpdk-dev] [PATCH 1/4] vhost: restore mbuf first when freeing zmbuf Tiwei Bie
2019-02-26 14:41 ` Maxime Coquelin
2019-02-22 2:42 ` [dpdk-dev] [PATCH 2/4] vhost: fix potential use-after-free for zero copy mbuf Tiwei Bie
2019-02-26 14:42 ` Maxime Coquelin [this message]
2019-02-22 2:42 ` [dpdk-dev] [PATCH 3/4] vhost: fix potential use-after-free for memory region Tiwei Bie
2019-02-26 14:42 ` Maxime Coquelin
2019-02-22 2:42 ` [dpdk-dev] [PATCH 4/4] doc: improve vhost zero copy guide Tiwei Bie
2019-02-26 14:44 ` Maxime Coquelin
2019-02-26 14:46 ` [dpdk-dev] [PATCH 0/4] Some fixes for vhost zero copy Maxime Coquelin
2019-02-27 1:52 ` Tiwei Bie
2019-02-27 8:32 ` Maxime Coquelin
2019-02-27 8:31 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3ff6b34-70e2-ceee-08a7-2d4b29265fd0@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).