From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 48F02376C for ; Fri, 24 Feb 2017 15:26:17 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2017 06:26:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,201,1484035200"; d="scan'208";a="52338446" Received: from dwdohert-mobl.ger.corp.intel.com (HELO [163.33.228.190]) ([163.33.228.190]) by orsmga002.jf.intel.com with ESMTP; 24 Feb 2017 06:26:15 -0800 To: Fan Zhang , dev@dpdk.org References: <1487677386-130017-1-git-send-email-roy.fan.zhang@intel.com> Cc: pablo.de.lara.guarch@intel.com From: "Doherty, Declan" Message-ID: Date: Fri, 24 Feb 2017 14:26:15 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1487677386-130017-1-git-send-email-roy.fan.zhang@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: add enqueue and dequeue operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 14:26:18 -0000 On 21/02/2017 11:43 AM, Fan Zhang wrote: > This patch adds enqueue and dequeue operations to > rte_cryptodev_scheduler_ops structure. This helps improving > the performance by reducing unnecessary function calls. > > Signed-off-by: Fan Zhang > --- ... > > rte_cryptodev_scheduler_create_private_ctx create_private_ctx; > + > + enqueue_pkt_burst_t enqueue; > + enqueue_pkt_burst_t enqueue_ordering; > + dequeue_pkt_burst_t dequeue; > + dequeue_pkt_burst_t dequeue_ordering; > }; ... > I think we should be able to achieve the desired functionality without the need for these new function pointers in rte_cryptodev_scheduler structure.