From: Remy Horton <remy.horton@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Markos Chandras <mchandras@suse.de>
Cc: dev@dpdk.org, Nirmoy Das <ndas@suse.de>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary
Date: Tue, 4 Apr 2017 12:12:16 +0100 [thread overview]
Message-ID: <f4191fb8-a440-959d-ae78-7b314cad214e@intel.com> (raw)
In-Reply-To: <2310633.U6SXsHI9VC@xps13>
On 04/04/2017 11:15, Thomas Monjalon wrote:
> Ping
[..]
>>> --- a/examples/ethtool/ethtool-app/Makefile
>>> +++ b/examples/ethtool/ethtool-app/Makefile
>>> +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
>>> +LDLIBS += -lrte_pmd_ixgbe
>>> +endif
>>
>> Please, could you confirm we can remove the same LDLIBS line from
>> examples/ethtool/lib/Makefile ?
Did a quick smoke test and looks like it needs to be in lib/Makefile as
well, at least for shared builds on Fedora. Not sure why though..
[ ethtool]$ make
== lib
LD librte_ethtool.so.1
rte_ethtool.o: In function `rte_ethtool_net_set_rx_mode':
rte_ethtool.c:(.text+0x667): undefined reference to
`rte_pmd_ixgbe_set_vf_rxmode'
collect2: error: ld returned 1 exit status
next prev parent reply other threads:[~2017-04-04 11:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 16:17 Markos Chandras
2017-02-17 16:11 ` Remy Horton
2017-02-17 16:27 ` Markos Chandras
2017-02-20 14:06 ` Remy Horton
2017-04-07 13:15 ` Timothy M. Redaelli
2017-02-20 14:06 ` Remy Horton
2017-03-09 20:13 ` Thomas Monjalon
2017-04-04 10:15 ` Thomas Monjalon
2017-04-04 11:12 ` Remy Horton [this message]
2017-05-01 20:10 ` [dpdk-dev] [PATCH v2] examples/ethtool: fix link with ixgbe shared lib Thomas Monjalon
2017-05-01 20:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4191fb8-a440-959d-ae78-7b314cad214e@intel.com \
--to=remy.horton@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=mchandras@suse.de \
--cc=ndas@suse.de \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).