From: Chengchang Tang <tangchengchang@huawei.com> To: Andrew Rybchenko <arybchenko@solarflare.com>, <dev@dpdk.org> Cc: <linuxarm@huawei.com>, <thomas@monjalon.net>, <ferruh.yigit@intel.com> Subject: Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info Date: Wed, 24 Jun 2020 11:48:10 +0800 Message-ID: <f430e304-c35c-54d9-68bb-6f12ee2c1f44@huawei.com> (raw) In-Reply-To: <566d8162-7550-6812-bf62-e0fb55e8e500@solarflare.com> On 2020/6/23 17:30, Andrew Rybchenko wrote: > On 6/23/20 9:48 AM, Chengchang Tang wrote: >> In common practice, PMD configure the rx_buf_size according to the data >> room size of the object in mempool. But in fact the final value is related >> to the specifications of hw, and its values will affect the number of >> fragments in recieving pkts. >> >> At present, we seem to have no way to espose relevant information to upper >> layer users. >> >> Add a field named rx_bufsize in rte_eth_rxq_info to indicate the buffer >> size used in recieving pkts for hw. >> > > I'm OK with the change in general. > I'm unsure which name to use: 'rx_buf_size' or 'rx_bursize', > since I found both 'min_rx_buf_size' and 'min_rx_bufsize' in > ethdev. > > I think it is important to update PMDs which provides the > information to fill the field in. My plan is to divide the subsequent series into two patches, one to modify rte_eth_rxq_info, and one to add our hns3 PMD implementation of rxq_info_get. Should i update all the PMDs that provide this information and test programs such as testpmd at the same time? > >> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> > > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com> > >> --- >> lib/librte_ethdev/rte_ethdev.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h >> index 0f6d053..82b7e98 100644 >> --- a/lib/librte_ethdev/rte_ethdev.h >> +++ b/lib/librte_ethdev/rte_ethdev.h >> @@ -1306,6 +1306,7 @@ struct rte_eth_rxq_info { >> struct rte_eth_rxconf conf; /**< queue config parameters. */ >> uint8_t scattered_rx; /**< scattered packets RX supported. */ >> uint16_t nb_desc; /**< configured number of RXDs. */ >> + uint16_t rx_bufsize; /**< size of RX buffer. */ >> } __rte_cache_min_aligned; >> >> /** >> -- >> 2.7.4 >> > > > . >
next prev parent reply other threads:[~2020-06-24 3:48 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-23 6:48 Chengchang Tang 2020-06-23 9:30 ` Andrew Rybchenko 2020-06-24 3:48 ` Chengchang Tang [this message] 2020-06-24 8:52 ` Ferruh Yigit 2020-06-24 18:32 ` Ferruh Yigit 2020-06-25 9:06 ` Andrew Rybchenko 2020-06-23 14:48 ` Stephen Hemminger 2020-06-23 15:22 ` Andrew Rybchenko 2020-07-22 6:38 ` [dpdk-dev] [RFC v2 0/3] add rx buffer size " Chengchang Tang 2020-07-22 6:38 ` [dpdk-dev] [RFC v2 1/3] ethdev: add a field " Chengchang Tang 2020-07-22 6:38 ` [dpdk-dev] [RFC v2 2/3] net/hns3: add support for query of rx/tx queue info Chengchang Tang 2020-07-22 6:38 ` [dpdk-dev] [RFC v2 3/3] app/testpmd: Add RX buffer size dispaly in queue info querry Chengchang Tang 2020-07-28 6:29 ` [dpdk-dev] [RFC v2 0/3] add rx buffer size for rte_eth_rxq_info Chengchang Tang 2020-07-28 9:30 ` Ferruh Yigit 2020-07-28 11:39 ` Chengchang Tang 2020-07-28 15:27 ` Thomas Monjalon -- strict thread matches above, loose matches on Subject: below -- 2020-06-18 12:35 [dpdk-dev] [RFC] ethdev: add a field " Chengchang Tang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f430e304-c35c-54d9-68bb-6f12ee2c1f44@huawei.com \ --to=tangchengchang@huawei.com \ --cc=arybchenko@solarflare.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=linuxarm@huawei.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git