From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 8ACD137AA;
 Fri,  3 Feb 2017 23:52:09 +0100 (CET)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga101.fm.intel.com with ESMTP; 03 Feb 2017 14:52:07 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,331,1477983600"; d="scan'208";a="60968487"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.49.173])
 ([10.254.49.173])
 by fmsmga005.fm.intel.com with ESMTP; 03 Feb 2017 14:52:07 -0800
To: John Daley <johndale@cisco.com>
References: <20170203011840.9715-1-johndale@cisco.com>
Cc: dev@dpdk.org, stable@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <f452caef-7535-f769-4b81-3454c273510e@intel.com>
Date: Fri, 3 Feb 2017 22:52:06 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170203011840.9715-1-johndale@cisco.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/enic: fix memory leak with oversized Tx
	packets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Feb 2017 22:52:10 -0000

On 2/3/2017 1:18 AM, John Daley wrote:
> If a packet send is attempted with a packet larger than the NIC
> is capabile of processing (9208) it will be dropped with no
> completion descriptor returned or completion index update, which
> will lead to an mbuf leak and eventual hang.
> 
> Drop and count oversized Tx packets in the Tx burst function and
> dereference/free the mbuf without sending it to the NIC.
> 
> Since the maximum Rx and Tx packet sizes are different on enic
> and are now both being used, make the define ENIC_DEFAULT_MAX_PKT_SIZE
> be 2 defines, one for Rx and one for Tx.
> 
> Fixes: fefed3d1e62c ("enic: new driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: John Daley <johndale@cisco.com>

Applied to dpdk-next-net/master, thanks.