DPDK patches and discussions
 help / color / mirror / Atom feed
From: fengchengwen <fengchengwen@huawei.com>
To: Bhagyada Modali <bhagyada.modali@amd.com>, <dev@dpdk.org>
Cc: <ssebasti@amd.com>, <rningoji@amd.com>
Subject: Re: [PATCH] dma\ae4dma: added AMD user space DMA driver
Date: Mon, 10 Mar 2025 10:33:46 +0800	[thread overview]
Message-ID: <f4637840-110f-4680-9c22-7b2c07241e27@huawei.com> (raw)
In-Reply-To: <20250309084526.972512-1-bhagyada.modali@amd.com>

Hi,

This commit modify the test-dma-perf and rte_mempool.h, but I can't get useful info
from the commit log.

So I recommend you split it to multiple commits, each commit implements a small function,
and well doc in commit log, this will help reviewer better understand.

Thanks

On 2025/3/9 16:45, Bhagyada Modali wrote:
> Added a user-space driver with support for the AMD EPYC
> 4th Generation DMA (AE4DMA) offload engine.
> 
> Implementation of new user-space driver supporting
> DMA memory copy offload on AMD EYPC 9004 & 8004 systems
> (Genoa and Siena processors).
> 
> Signed-off-by: Bhagyada Modali <bhagyada.modali@amd.com>
> ---
>  app/test-dma-perf/benchmark.c        |  24 +-
>  app/test-dma-perf/config.ini         | 134 ++++--
>  app/test-dma-perf/main.c             |   2 -
>  app/test/test_dmadev.c               |  43 +-
>  drivers/dma/ae4dma/ae4dma_dmadev.c   | 656 +++++++++++++++++++++++++++
>  drivers/dma/ae4dma/ae4dma_hw_defs.h  | 225 +++++++++
>  drivers/dma/ae4dma/ae4dma_internal.h | 125 +++++
>  drivers/dma/ae4dma/meson.build       |   7 +
>  drivers/dma/meson.build              |   1 +
>  lib/mempool/rte_mempool.h            |   2 +-
>  usertools/dpdk-devbind.py            |   5 +-
>  11 files changed, 1146 insertions(+), 78 deletions(-)
>  create mode 100644 drivers/dma/ae4dma/ae4dma_dmadev.c
>  create mode 100644 drivers/dma/ae4dma/ae4dma_hw_defs.h
>  create mode 100644 drivers/dma/ae4dma/ae4dma_internal.h
>  create mode 100644 drivers/dma/ae4dma/meson.build


  reply	other threads:[~2025-03-10  2:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-09  8:45 Bhagyada Modali
2025-03-10  2:33 ` fengchengwen [this message]
2025-03-10  9:35 ` Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4637840-110f-4680-9c22-7b2c07241e27@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=bhagyada.modali@amd.com \
    --cc=dev@dpdk.org \
    --cc=rningoji@amd.com \
    --cc=ssebasti@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).