* [dpdk-dev] small error in rte_eth_bond_api.c
@ 2020-06-19 18:12 Анатолий Дубинский
2020-06-22 8:42 ` Wei Hu (Xavier)
2020-07-14 15:14 ` Анатолий Дубинский
0 siblings, 2 replies; 3+ messages in thread
From: Анатолий Дубинский @ 2020-06-19 18:12 UTC (permalink / raw)
To: dev
Hello!
I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c :
Func rte_eth_bond_create:
ret = rte_vdev_init(name, devargs);
if (ret)
return -ENOMEM;
So, we get ENOMEM error regardless of the actual error code.
This code would be more applicable.
ret = rte_vdev_init(name, devargs);
if (ret)
return ret;
Yours sincerely, Anatoly Dubinsky.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] small error in rte_eth_bond_api.c
2020-06-19 18:12 [dpdk-dev] small error in rte_eth_bond_api.c Анатолий Дубинский
@ 2020-06-22 8:42 ` Wei Hu (Xavier)
2020-07-14 15:14 ` Анатолий Дубинский
1 sibling, 0 replies; 3+ messages in thread
From: Wei Hu (Xavier) @ 2020-06-22 8:42 UTC (permalink / raw)
To: Анатолий
Дубинский
Cc: dev, Chas Williams
Hi, Anatoly Dubinsky
it looks you are right. Maybe you can send a patch to fix it.
Thanks, Xavier
On 2020/6/20 2:12, Анатолий Дубинский wrote:
> Hello!
>
> I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c :
>
> Func rte_eth_bond_create:
> ret = rte_vdev_init(name, devargs);
> if (ret)
> return -ENOMEM;
>
> So, we get ENOMEM error regardless of the actual error code.
>
> This code would be more applicable.
> ret = rte_vdev_init(name, devargs);
> if (ret)
> return ret;
>
>
> Yours sincerely, Anatoly Dubinsky.
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] small error in rte_eth_bond_api.c
2020-06-19 18:12 [dpdk-dev] small error in rte_eth_bond_api.c Анатолий Дубинский
2020-06-22 8:42 ` Wei Hu (Xavier)
@ 2020-07-14 15:14 ` Анатолий Дубинский
1 sibling, 0 replies; 3+ messages in thread
From: Анатолий Дубинский @ 2020-07-14 15:14 UTC (permalink / raw)
To: dev; +Cc: xavier.huwei
Hello!
I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c :
Func rte_eth_bond_create:
ret = rte_vdev_init(name, devargs);
if (ret)
return -ENOMEM;
So, we get ENOMEM error regardless of the actual error code.
This code would be more applicable.
ret = rte_vdev_init(name, devargs);
if (ret)
return ret;
Reported-by: Anatoly Dubinsky, ard@amicon.ru
________________________________
От: Анатолий Дубинский
Отправлено: 19 июня 2020 г. 21:12
Кому: dev@dpdk.org
Тема: small error in rte_eth_bond_api.c
Hello!
I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c :
Func rte_eth_bond_create:
ret = rte_vdev_init(name, devargs);
if (ret)
return -ENOMEM;
So, we get ENOMEM error regardless of the actual error code.
This code would be more applicable.
ret = rte_vdev_init(name, devargs);
if (ret)
return ret;
Yours sincerely, Anatoly Dubinsky.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-17 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19 18:12 [dpdk-dev] small error in rte_eth_bond_api.c Анатолий Дубинский
2020-06-22 8:42 ` Wei Hu (Xavier)
2020-07-14 15:14 ` Анатолий Дубинский
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).