From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C3D84326D; Thu, 2 Nov 2023 11:34:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7719140EAB; Thu, 2 Nov 2023 11:34:51 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id BB95440E68 for ; Thu, 2 Nov 2023 11:34:49 +0100 (CET) Received: from dggpeml100021.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SLgH96TD0zvQQW; Thu, 2 Nov 2023 18:34:45 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by dggpeml100021.china.huawei.com (7.185.36.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 2 Nov 2023 18:34:47 +0800 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.031; Thu, 2 Nov 2023 11:34:45 +0100 From: Konstantin Ananyev To: Fengchengwen , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , "ajit.khaparde@broadcom.com" , Somnath Kotur CC: "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "kalesh-anakkur.purayil@broadcom.com" , "Honnappa.Nagarahalli@arm.com" Subject: RE: [PATCH v2 4/7] net/bnxt: use fp ops setup function Thread-Topic: [PATCH v2 4/7] net/bnxt: use fp ops setup function Thread-Index: AQHaAz25PtP4UuFdgUeMvWUWjFiBkbBm6dNw Date: Thu, 2 Nov 2023 10:34:45 +0000 Message-ID: References: <20230301030610.49468-1-fengchengwen@huawei.com> <20231020100746.31520-1-fengchengwen@huawei.com> <20231020100746.31520-5-fengchengwen@huawei.com> In-Reply-To: <20231020100746.31520-5-fengchengwen@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.206.138.42] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Use rte_eth_fp_ops_setup() instead of directly manipulating > rte_eth_fp_ops variable. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengwen Feng > --- > drivers/net/bnxt/bnxt_cpr.c | 5 +---- > drivers/net/bnxt/bnxt_ethdev.c | 5 +---- > 2 files changed, 2 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c > index d8947d5b5f..3a08028331 100644 > --- a/drivers/net/bnxt/bnxt_cpr.c > +++ b/drivers/net/bnxt/bnxt_cpr.c > @@ -416,10 +416,7 @@ void bnxt_stop_rxtx(struct rte_eth_dev *eth_dev) > eth_dev->rx_pkt_burst =3D rte_eth_pkt_burst_dummy; > eth_dev->tx_pkt_burst =3D rte_eth_pkt_burst_dummy; >=20 > - rte_eth_fp_ops[eth_dev->data->port_id].rx_pkt_burst =3D > - eth_dev->rx_pkt_burst; > - rte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst =3D > - eth_dev->tx_pkt_burst; > + rte_eth_fp_ops_setup(eth_dev); > rte_mb(); >=20 > /* Allow time for threads to exit the real burst functions. */ > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethde= v.c > index 003a6eec11..9d9b9ae8cf 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -4428,10 +4428,7 @@ static void bnxt_dev_recover(void *arg) > if (rc) > goto err_start; >=20 > - rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =3D > - bp->eth_dev->rx_pkt_burst; > - rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =3D > - bp->eth_dev->tx_pkt_burst; > + rte_eth_fp_ops_setup(bp->eth_dev); > rte_mb(); >=20 > PMD_DRV_LOG(INFO, "Port: %u Recovered from FW reset\n", > -- Acked-by: Konstantin Ananyev =20 > 2.17.1