From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wu, Wenjun1" <wenjun1.wu@intel.com>,
David Marchand <david.marchand@redhat.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: revert removing IPID from default hash field
Date: Wed, 8 Sep 2021 06:01:49 +0000 [thread overview]
Message-ID: <f4be2bfb0f7d48dc8b0c15d8015ab134@intel.com> (raw)
In-Reply-To: <SA0PR11MB4575CEB0EEB28640C9E4D112DFD39@SA0PR11MB4575.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Sent: Tuesday, September 7, 2021 3:28 PM
> To: David Marchand <david.marchand@redhat.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1] net/ice: revert removing IPID from default
> hash field
>
> Default RSS for outer src/dst IP address field in iavf is not supported before, so
> it does not cause any error.
> However, if it can be dropped, I suggest to do so. It seems to be safer to add
> IPID field here.
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Tuesday, September 7, 2021 3:10 PM
> > To: Wu, Wenjun1 <wenjun1.wu@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>
> > Cc: dev <dev@dpdk.org>; Yang, Qiming <qiming.yang@intel.com>; Zhang,
> > Qi Z <qi.z.zhang@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH v1] net/ice: revert removing IPID from
> > default hash field
> >
> > On Tue, Sep 7, 2021 at 9:05 AM Wenjun Wu <wenjun1.wu@intel.com>
> wrote:
> > >
> > > We try to refine default RSS for IP fragment packets. However, the
> > > change will lead to more serious errors. The scenario that there is
> > > overlap/conflict between the new characteristics and the existing
> > > ones has not been supported, so non-fragment packets and fragment
> > > packets cannot share the same hash fields, or all related profiles
> > > will be removed.
> > >
> > > Therefore, IPID field is necessary for fragment packets.
> > >
> > > Fixes: cf37e1e5e9d2 ("net/ice: fix default RSS hash for IP fragment
> > > packets")
The original fix has no issue, there should be a fix for the real problem, this patch can be rejected after sync with author.
> > >
> > > Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> >
> > - If this is a revert of cf37e1e5e9d2, maybe it is simpler to drop the
> > original change in next-net before it gets pulled in the main repo.
> > - A similar change has been applied to net/iavf? Is it still relevant?
> >
> >
> > --
> > David Marchand
>
prev parent reply other threads:[~2021-09-08 6:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 6:45 Wenjun Wu
2021-09-07 7:09 ` David Marchand
2021-09-07 7:27 ` Wu, Wenjun1
2021-09-08 6:01 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4be2bfb0f7d48dc8b0c15d8015ab134@intel.com \
--to=qi.z.zhang@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qiming.yang@intel.com \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).