From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09B6542B3A; Thu, 18 May 2023 12:13:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC5BE40E25; Thu, 18 May 2023 12:13:45 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 4C67D4014F; Thu, 18 May 2023 12:13:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AcBeJX0AKSu5RX3AHrvKJZNOPJs0uPAPiHGBWfJI3LJFEmtiwNDTreqzgpJCQb6yApwTU1JBPLSUGKufc/P8BT28cYLVe1crQEYm5yH1O7yi6WQUPk0/2u/i66S1x8qzWMtKPuaPCWt7ykIFUvrFdRUXQqSM5JobxpNKTF7kAQX7N5aso7ve2CUGwEZRwhEUPFmCxdU6YVmS223FmoJhT+RQW7cp4zbKyklRpZx2afJbeKn30Lz/Do2JZYw0470lvkPhbOcC7yV8ahrRad6+yEqpqNv5X6c6ZuxAuUh+rQdyfJa4i6dTp2XQ39gikWtGU9NRY0MWZr6mwbybnagWCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WuYj4VW5++yonyRkcWwQdXW0iKSsLsnZp87Onl3I/Tc=; b=faP52shWurLGdPMKIn4rgAMTKtr7mNgak1YZpDCjBhb3Mv3VYSTJXR+zNgsg00ytN4gfgT8WGLIzq05Tm2ICuOoJBhZEpbiK+MxhdzarCjZ79SaFVqvS6IJKWgQaDL05o8PR7Ppc5R+OG1pv1XDwxCt2jbHCEz4s1kU9E+JqslcK4w80ougiDTZ9xLJrWKuDk3wMzshA3bpAq5KsiGPpS4F/QT/ozgFHDnBcFTND45K9Dal9fOvm13DK2EqRaiA9N4gx0veEUMXRpjUAJEG4LlbVihOVMUdlAwmGSLR1YgXN6sS7vr1gMBEObe4bp0CcZA9m/iNFINcay5WICiPHfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WuYj4VW5++yonyRkcWwQdXW0iKSsLsnZp87Onl3I/Tc=; b=s8a/imkCicMTlTpYHiQYKWmnX/drDOAiTYxFcda7vj5Q51lGQKhXqvGP8shXjkYyy533OP1wzbTCrsGh7wj2Yv1cVMNwq9KcRWuLTj5uQ0HnGtkRFwm/JAnnd9ctHDaPjB5Xsh070pFULXSdCtw/ANSZGb9vDTpxq6703uEWzLo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB8971.namprd12.prod.outlook.com (2603:10b6:610:177::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Thu, 18 May 2023 10:13:42 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Thu, 18 May 2023 10:13:42 +0000 Message-ID: Date: Thu, 18 May 2023 11:12:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] net/nfp: fix the VLAN push flow action Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, stable@dpdk.org References: <20230512020346.616180-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230512020346.616180-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0375.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::27) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB8971:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a3d02ca-326e-406d-bb78-08db57888e34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AhAgb5L/M/xndOvEl9+BIQ1S5qxSLPbRo+T0k/YesO76+hi5kaxHB+NkLhqSdNov9BJySGqa6qBHN/sliinSUE5Hc01FLem0OKH1T+HBk+ve4u5PsvucY4FUSz+HvfJTixNEkovHC71G1XaHw40ILEVsKhgHw63oNs7rkzUS3ijzDKxnK4hDO+uaQXj58ft7qXLsSGM+IfpEomeq39KVV3gatv7SUZy7+c1uDPdYM26+j3u/8/LiavKDTkpVCDGs2Gf/7fl0cc9qUUcBmT8Wbe5zk3ZluXJfKeJkp7b7pIecvpYyIBXWx+AQFCjT2jP7l2sXeU+VsXQfKKUDlj2+w/3yeZskno/gQcAjY6eFI3UlpWQfLVO5SQrnkG+B/Kr/ZOR2USrk/e1DiXNlr00BCj4CsiB4Xgi6sRljLmsvDZn6RSFs+JxioHfrtgEM6s/z8chrXqdt0krbG44Vdca0pO8oOEiMos2spR6MtAWbvgvOf+eWgzdybUGPNP3HhIcI7IuZx1WYE/Oe8UGbDD/9U45y2CD7l/chkzFOwNtvVVTGFxQ6fnM6sGx+rOgxPvbo67o0Io1+1sRqTlMye6RSI6narcUX5VXNveHI75TEzU01paKIA3NRKbUp/rxKuJeRL2agIcuSb1JXhy5fZWqpQA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(451199021)(31696002)(36756003)(66556008)(66476007)(478600001)(4326008)(66946007)(316002)(6666004)(4744005)(8936002)(8676002)(44832011)(5660300002)(6486002)(2906002)(38100700002)(41300700001)(186003)(26005)(6506007)(53546011)(2616005)(6512007)(86362001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0g1T0xKVDdSQWZodkNpc1dnazM0d3ZNU0NZcUF1R3dkYitZZk5zdUdPaEtm?= =?utf-8?B?TXoyUUtOaHpnRlBTNXM0bTRSbm9JVDg2bm83S2Via3o5WVB3MGlEWUpLSHFa?= =?utf-8?B?dmdnelU4VE9RVitwOXFLd1RqeElUQ2pSYWxreHRSallWU3RuekVNNnpTd3Fk?= =?utf-8?B?V0dhRnJka3RTdkMxSUQxczdUT0FsMVU3VzZNNnlDR21sZ3ZpREhOeTdmSDMz?= =?utf-8?B?QzNnL29pNEpDQjVMdS9xdXJQMHZ3aDdwVE96WEhXMmZsRy9yRE5HZW1qU2x3?= =?utf-8?B?YlNaT0JlOHNiMlBZUVJWVjBSRnErbVFkdVl3VEdoZmRYMHVyT3pRNzlDanJ5?= =?utf-8?B?TkR3aEJIZFBDeU1qM0cweUVEc2liN1F0cXNBaEZ3SVNScjdoZlIxRnRjWWJV?= =?utf-8?B?MXdjYzBsRFV4OFdxUTdQNU9VeXcvOFpYTlR3NVl5elQxL1UzQXVaYlR5L3Vq?= =?utf-8?B?LzRTVG1tNGQwVGpyejJDVUVITnBrMit0MXF6TThUaitWTUQxcW5BeE9RaXh0?= =?utf-8?B?V1NzMWxlUUdQemxGWDIvVk8zQWtob2t0QXhyTXVMd3RGaFdmY0dTcGVzL3Ru?= =?utf-8?B?TjlUQmIyQXlJY0MxWUlNU0FPNnlwUlFxeFU5TTVuTVdTUkc4bXdtSXBCUk5J?= =?utf-8?B?MG00eWhMNkxRMVhCUFRyNGJZalVMbDBtdmNFNGJkQzM1blRIQ2xSTnp2ZGsz?= =?utf-8?B?QzRkYnFaSGh5WHVReUtkbnpac25zODRSYmxvMkpaQTFTWkdDb0orQmk3eDRy?= =?utf-8?B?RUNRSjBzWXM2YmRqYXZ3SnRTZnljSEdvcG43UkRaaU1JZ0R6MDh6TlpSWnpa?= =?utf-8?B?RFRibFlRMVF0bWtnRDlhOUk4bkM1WTFYbzBOYm1GS3h6WmdDWFhpcGlybTZh?= =?utf-8?B?N1lMdWFNbkxaYWtHUFJ3NS9PNGE3bjZ5OTFKazlRTXVMU3BuY2FaUlhGSDg5?= =?utf-8?B?Uzlpd3dQY2U2Lzk0WDh1eU84NDRnMGVraGFsNUMzaFlqRjZBSndOZ2k3eHpk?= =?utf-8?B?YWZ2aXNWbzkvS0dMQmphTVN2Yy82K3ppdlpHY0FzVWhrTDJmZFlOU0tTcGw2?= =?utf-8?B?QURoY2lkdzVoMFFxZ2tCYlFVeFZYZjA1U3psRklyeEhtYnlUaW9BZ2tDVVQ2?= =?utf-8?B?dVIvLzVoU2JudmpwRjlNS0ZMTy9VMU5tSTF0cDF1ekJSWDB3NldEWlRNMmVJ?= =?utf-8?B?aFUwUlBxbWxtY2czVXltTGdBZ0J0TVJlZ01Bc09xZkJOMFhjWmxSMHpFeXFq?= =?utf-8?B?NGdreXdoVXFkWXN1dGNXanA4dDVhQ2RmdnJZSkpjUzBSWUViTElBTzdCbHp5?= =?utf-8?B?dFB2YitkZEE2MUlOckJpeUxTN1JhQ3JaYXkra2Y2M1RSL012b3Bvc0RHU2E3?= =?utf-8?B?UDU5eTNXY3pwaDhxaXVHRlJpUmZqTkJ3aEZja2pIa1pNbmtUb2JkMStFbnBV?= =?utf-8?B?MWV1R1YvNWt6NjNQc3ZRR2h6cFVOVzRSVm5wc3gvTXhtMXFBNEh4RFN0Y2dE?= =?utf-8?B?akZIU1ZyTlhkL3EvdVRvaFlTYzNTMDZkRVpZbTJxZmhyNW1xdkxBQ1ROS2Fy?= =?utf-8?B?Zlp2L2pTWWRjTmo1eDF0ZmZkWnlaVm5xUkZTdzRBVHFXRE9NUlhJd0VPUXZ1?= =?utf-8?B?aVRmQVdPOTJFblB2NFpOSk5GUzhYWVlVZEJPZmplQVhrTmNxMHNpZ2VXUThQ?= =?utf-8?B?OWt6MWFldElrRnNqN1ZKZml3MXJuOHA0N05JRU1abkxzd3dRYUphVTNXYnFw?= =?utf-8?B?VFFlQ2FvblF0SjYxbzRmc2hKUHVIakUyMHhjWVorMlhYMFRIaWtSNTNmcWth?= =?utf-8?B?ekx2OEl5ZHpMV1Y4d2Nzb2xNYmxaM0x5cC9LRGw2NVV0ZzA1SHNOLzd2ZHpl?= =?utf-8?B?cng3UUQ1S3dHbTF3OVZNdkJhK3RxdGpwL0dhOHBRZEVOK3ZGVUsvYkN6Ti9M?= =?utf-8?B?aVBmSjk4V1VScWpueHc1RFdsT0xuRTQ5aUFiamxaTlNiNk9OMnpCeHFycy9p?= =?utf-8?B?WlgyUGJJcjlJQlVZZzM0NTQ3TnVLa3BMbFpLQnNPdEpCbTUvVGM5V3hqNi91?= =?utf-8?B?cXk2eGRUK0tITGZtb2tKd3oxZ0EzNDBsVWZWdFpkbzRGOWxrbDg1SytVTXB4?= =?utf-8?Q?o2hEq7aXS7G9I8f5A9PrqmXTl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a3d02ca-326e-406d-bb78-08db57888e34 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 10:13:41.8724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J74MT5TEOWqRXOvj1WuoxY3c+UF17Slt9cR15rYKwyKVehuX+hpRm0mu8iLV5//u X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8971 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/12/2023 3:03 AM, Chaoyong He wrote: > When process VLAN push flow action, the former logic perform the > mask and shift operations directly on the big endian data, which > cause both the pcp and VLAN id are not correct for offloaded packets. > > Fix it by convert the data from big endian to CPU endian before > perform the mask and shift operations. > > Fixes: eb9277cb2fd1 ("net/nfp: support VLAN push flow action") > Cc: stable@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund > Applied to dpdk-next-net/main, thanks.