From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 58ED7A48D for ; Wed, 17 Jan 2018 17:06:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2018 08:06:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="10986116" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by fmsmga007.fm.intel.com with ESMTP; 17 Jan 2018 08:06:42 -0800 To: "Wiles, Keith" , "Varghese, Vipin" Cc: "dev@dpdk.org" , "Patel, Amol" , "Hunt, David" , "Jain, Deepak K" , Pascal Mazon References: <1513875200-5061-1-git-send-email-vipin.varghese@intel.com> <2893AEFC-6FD7-4D05-AB5B-F2AC018D1390@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 17 Jan 2018 16:06:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2893AEFC-6FD7-4D05-AB5B-F2AC018D1390@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 16:06:45 -0000 On 12/21/2017 1:38 PM, Wiles, Keith wrote: > > >> On Dec 21, 2017, at 10:53 AM, Vipin Varghese wrote: >> >> TAP speed is passed as user argument, but never set to interface. >> New logic brings speed get and set to LOCAL and REMOTE interfaces. >> >> Updated the default PMD speeed to 10M as per Linux Kernel default >> value. > > The problem in setting the link speed to 10M is that TAP will not limit its traffic to 10M. Applications like pktgen and others use the Link speed to calculate the bit rate, which will be broken now. > > I would suggest making the default value 10G or 40G instead as CPU speeds will continue to increase. Forcing someone to always add the link speed seems a bit much when we know the systems can send/receive much higher then 10M, which is the reason 10G was picked. Please set the default back to 10G or some much higher number. Hi Keith, Vipin, Pascal, Since we really can't set the interface for Linux tap interface, what do you think removing speed arg completely from tap PMD? Thanks, ferruh > >> >> Signed-off-by: Vipin Varghese >> --- >> drivers/net/tap/rte_eth_tap.c | 185 +++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 182 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c >> index 6b27679..7238504 100644 >> --- a/drivers/net/tap/rte_eth_tap.c >> +++ b/drivers/net/tap/rte_eth_tap.c >> @@ -62,6 +62,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> > > Regards, > Keith >