From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E6BEA04C9; Mon, 14 Sep 2020 12:55:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54AA02C36; Mon, 14 Sep 2020 12:55:03 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 468FCFFA for ; Mon, 14 Sep 2020 12:55:01 +0200 (CEST) IronPort-SDR: jF/C8+hnIdN6eb+PFVDzZRyT9nE4rcv7oBfnrjfNqMz8Kr6o4X8hVQ8EmNyDjSuus5BDtAvJrf k0wcDo/SrpwQ== X-IronPort-AV: E=McAfee;i="6000,8403,9743"; a="146749677" X-IronPort-AV: E=Sophos;i="5.76,425,1592895600"; d="scan'208";a="146749677" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 03:55:00 -0700 IronPort-SDR: thqqTA4dnGFxjjhE6USMqnm4mTN2OCPNEQi84nuoKTvXxybUCxmE8ohgsY1DtLX4oD+uKWhTO1 NJOJofn2CIJw== X-IronPort-AV: E=Sophos;i="5.76,425,1592895600"; d="scan'208";a="507093614" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.225]) ([10.213.247.225]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 03:54:58 -0700 To: Zhirun Yan , qi.z.zhang@intel.com, dev@dpdk.org Cc: yahui.cao@intel.com, xiao.w.wang@intel.com, simei.su@intel.com, junfeng.guo@intel.com References: <20200908073939.4099976-1-zhirun.yan@intel.com> <20200914030530.3077904-1-zhirun.yan@intel.com> <20200914030530.3077904-2-zhirun.yan@intel.com> From: Ferruh Yigit Message-ID: Date: Mon, 14 Sep 2020 11:54:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200914030530.3077904-2-zhirun.yan@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ice: refactor FDIR set conf function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/14/2020 4:05 AM, Zhirun Yan wrote: > The original set conf function in FDIR was very long. Refactor to > increase readability to make it clearer and allow for more convenient > further changes. > > No functional change here. > > Signed-off-by: Zhirun Yan > --- > drivers/net/ice/ice_fdir_filter.c | 54 ++++++++++++++++++------------- > 1 file changed, 31 insertions(+), 23 deletions(-) > > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c > index 88c9bb03d..593dfd0e2 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -964,30 +964,10 @@ ice_fdir_input_set_parse(uint64_t inset, enum ice_flow_field *field) > } > } > > -static int > -ice_fdir_input_set_conf(struct ice_pf *pf, enum ice_fltr_ptype flow, > - uint64_t input_set, enum ice_fdir_tunnel_type ttype) > +static void > +ice_fdir_input_set_hdrs(enum ice_fltr_ptype flow, struct ice_flow_seg_info *seg, > + enum ice_fdir_tunnel_type ttype) > { Hi Zhirun, 'ttype' variable is not used in this function at all, what do you think removing it?