From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DADE945C0A; Tue, 29 Oct 2024 13:35:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA0A74014F; Tue, 29 Oct 2024 13:35:44 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id C42F64014F for ; Tue, 29 Oct 2024 13:35:43 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9ED7213D5; Tue, 29 Oct 2024 05:36:12 -0700 (PDT) Received: from [10.57.58.134] (unknown [10.57.58.134]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 367CA3F73B; Tue, 29 Oct 2024 05:35:42 -0700 (PDT) Message-ID: Date: Tue, 29 Oct 2024 12:35:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] doc: update argument options for external DPDK build Content-Language: en-GB To: Patrick Robb Cc: dev@dpdk.org, Paul Szczepanek , =?UTF-8?B?VG9tw6HFoSDEjnVyb3ZlYw==?= References: <20240930160204.19582-1-tomas.durovec@pantheon.tech> <20241021134935.1210500-1-luca.vizzarro@arm.com> <20241021134935.1210500-7-luca.vizzarro@arm.com> From: Luca Vizzarro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 29/10/2024 01:23, Patrick Robb wrote: > On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro > wrote: > > > + > +   DPDK Build Options: > +   Arguments in this group (and subgroup) will be applied to a > DPDKLocation when the DPDK tree, tarball or revision will be > provided, other arguments > +   like remote source and build dir are optional. A DPDKLocation > from settings are used instead of from config if construct successful. > > > Maybe call this "DPDK Source Options?" To me, "DPDK Build Options" > invokes meson options supported in DPDK. Up to you though. > Reviewed-by: Patrick Robb > Perfectly understandable concern to be honest. But it's also somewhat complicated, given this refers to the build whether it's uncompiled or precompiled and the location of the sources. It may require some thought.