From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5052341CA4; Wed, 15 Feb 2023 10:43:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DF7A42670; Wed, 15 Feb 2023 10:43:51 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2057.outbound.protection.outlook.com [40.107.93.57]) by mails.dpdk.org (Postfix) with ESMTP id 235E8410DD for ; Wed, 15 Feb 2023 10:43:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RBCJ4xfdH8qc1au4JTdjQGZrzocBFe764Lpyi22c/lX/m+r4z1FlChQfJ+UDFaWf98p6VhuCgieOPssqq7H8MWjeamRsV9vonfTPTbFsK8uLOfF9H2iBrGs9HKIFlU3yo4UD8YNLmCc5whjbAx/Pk+TkcxvhhxyD0eviFfL/Em3jdUSY5zGDcubKIlgLmp2MwoR8N9g0WmWHVU+WwsT91kGJGHkKKRutA3IgMz3xjMrKToWudRonnQzX5YNm1rbGsEzUWptyyoQLGqCB+P2LAgTGz+903mvminM3RWfwAqaVSp2R3cwlgjDIec/i7iQa3dUrWz7yd2tB2g5MBdf88Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iZwHhoeT5+/yjSqR+LRMuZBy6rjKTiVwZPj7bNKG0ic=; b=X6u0HaK6s1LW67zeHHa741u8n38+oj0qcdT0bVgQr7z6BkMRzEk18amZgwI52/4E17w85AwCm2rythx6X1gR8vkny2N6Uet/81/1FCkUHtc+FsYp+JzNn0UBl8X5/dKIyj/SH42T2dfUU+Yq8/a5Qhyj7rzrtj96DtXOcXx9dsh/cOMXSH9mXqBml8FgLBfq9Ue3COGBo7yvOZ3OGDae2vqWfYRRPKnJrB+1PyzDUxeeKtfttptyMRHmjFB2sN9yQHMg4XFdrqGJX9j95az9TiUBd4hv3YARzhI5vbYV81T/iDlt1o6e3WUZGMvoxgBmzDgRPkbefH2DQR6dr7LIhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iZwHhoeT5+/yjSqR+LRMuZBy6rjKTiVwZPj7bNKG0ic=; b=ee3v+tF9WfER+91b492gUFTlu9+iDOP87DhS7/LGENAnYlTjxksWpr0l9lwHP6J9GLRwg5Ak6o8e70OSXXTPXsRW0C4/OSPjaV8Pj5YNQEYbRQBEnEYI8fwg1x7dFTN9JreAXEq73vL5HDy/ZgKibbqGOcbrR/SMhEkyhpOT0+o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB7123.namprd12.prod.outlook.com (2603:10b6:930:60::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Wed, 15 Feb 2023 09:43:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 09:43:45 +0000 Message-ID: Date: Wed, 15 Feb 2023 09:43:39 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v9 1/3] ethdev: skip congestion management configuration Content-Language: en-US To: Rakesh Kudurumalla , Ori Kam , Thomas Monjalon , Andrew Rybchenko Cc: jerinj@marvell.com, ndabilpuram@marvell.com, dev@dpdk.org References: <20230214130458.1114765-1-rkudurumalla@marvell.com> <20230215062532.1169860-1-rkudurumalla@marvell.com> From: Ferruh Yigit In-Reply-To: <20230215062532.1169860-1-rkudurumalla@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0396.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::24) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB7123:EE_ X-MS-Office365-Filtering-Correlation-Id: e77ba04f-022f-49b8-4263-08db0f3921a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O43t9JKJcE9F3KY3oRGfl9t6GpLZQWhM+3Ao8pFY0OwOOVzicF8r8PAlVOxcBgqEoGXVkEw7XYKu0vr6XZ/rXaXe9fz9d4nzRLROLHbobZTzk3pPlk22pcTiQEevJy3OZSeB12PVftyQy+xb78uosSW2VdpQc0wdXepGHaedpjBBx4zDB3/z/tEJSHG7IvqzSdEuMo9KMEW+Kl8iwipvdNKWg5yTLxI6jJDMj4I86Z94IDYJo03JeO16AO681pwTqdiN2lbPS8Rf91IAMf49B+UxVuAQ7Vl69MOjBJsWvIVV7MVc8yIYfokH1VrPdLRGaUczsXV7BxxIPFrZSsGhoEPNT/yKGXN0ZJinl9yY04KbYLrp5DqMiEdeBDFIFgnw3VBw/r4xQIWCnfvaw3kRprtSGk30h+MbauJtsL3UVBwbkMuPf3ArDBK8xQqUEFPTsVTw4PhwyNpGSHcbHKNGlScswWUG1dqpy7iA1JH1iioIwHYHxV++brQgui8FiC1EE8jNQr1sYofZM/WwQ6k1CWne6dvF95PlbyIhLDuWQQpr7CH7Mi6hiX2VVDcR9UJJCvDdbh+o4SQuNVEl6D63rSOlLk0nBZSGa0r+X7jAFer84ASgMv3/LAjeon72CCsnR4WQnMIZfF46DghoBOWU6AwJp/rXOuSeq4I0Q4BMbNQLtzDph7ZtLziD90q2jundp3+5HG4qrbrnOHSAMlrXOvx3VzCqw/YXNFLk1gWHJKc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199018)(8936002)(41300700001)(36756003)(38100700002)(86362001)(31696002)(83380400001)(5660300002)(2906002)(26005)(44832011)(316002)(186003)(6512007)(110136005)(478600001)(6506007)(53546011)(31686004)(966005)(6486002)(2616005)(8676002)(66476007)(6666004)(66556008)(4326008)(66946007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnVxb3ozNTI4SUpyTVJXUGk1MlZzbHVBaS9tZE0vVXBjUE5yOFVOSkZVcVFv?= =?utf-8?B?djE1NWV5TG9NOUFTSkVmcFJUd0NoOENjLzFodWliSWlZczBneU1JMHVrVFhS?= =?utf-8?B?MmR4TGdNQXFEZ0xhN1cvR0FqRGxnMis0YWkzSDJBcGVVVlgyMzJLT2xwc2Fy?= =?utf-8?B?TVlJZVRsVmI1RTBWR1I3RUhBa04xL2dQS1YvNGk3ZzRqTW9tcExkWXE3dU9E?= =?utf-8?B?OW5IRmgxRVNEYkFxVmRNd2ExcFFvSEd5cUw2RVk2UDdocFJQSmN6cnp3UmZX?= =?utf-8?B?UnIyYXpjK3BhN2hZd3pGWEFvMCsrczd2Wng0b1RxYlMxakYzS3BwRUg4ZW5B?= =?utf-8?B?cXJPWjVnK2dXSC82VW5aeHJvWHQzZDlJMlBRSlRpd1Ewd1plYVM5UVpCOGFp?= =?utf-8?B?Z2NZSGN0Z2tnWTNmWnE5eE5MMkJRWXllL1crckhFQlNlRC9WUTZDZE8rTktK?= =?utf-8?B?em1JdkQ2QWhGS21XUGNpV2IrdzFpaEFnVS9JL3BHQTlNL2JVTWZxRjNhWlg1?= =?utf-8?B?Nk03OFMwMUZVY1E4WmhNZXJ6UmpnYnNqQkJ0RGlDdit5bWR5djdVK0tGQVpM?= =?utf-8?B?V0NST29mRGVqNVYzZVhJQ0xvUms4L0VMK092SzhDcXJ5NFF2Tk11Q0JOVjNv?= =?utf-8?B?T2NFQXovVk9VWEk0cjA0UXpvOWtCYTNyeC9OdU5sK2R5MkJGUU9kbk1xbVV2?= =?utf-8?B?eDV0R29IN29LTGhWY2JIUTJWQmxsY3dVOUVXbHZRRU9rRmJ5NW1KR3ptYXda?= =?utf-8?B?b1BJWW1FM0oxQzNzMklrMkk3amwrbHRkZjlEUm1EclBGaEdXUU95NFZYNTdx?= =?utf-8?B?NW9QQ1YxZWlFRWkyRGw2RUE5UFRMdDA3RHlhR2xKd0JXNWpROWZiMnhtY21t?= =?utf-8?B?WDR1L1dueXRaQ3lWcjh1OElpRTNLc0pQL2pNQ09mam9aL2FGTkpZMm1sblJ6?= =?utf-8?B?a2FmNWFoc0d4bTFCWGhjN0swanV4ejM3VlBUWlU0ZkpzbUNZcEV2bVZyQ1dT?= =?utf-8?B?bXRuclBHQlo2b1doOFh0ZWxZSlJHSU95RWJWUngrSHVZVU9aQ05NeXdxOWdE?= =?utf-8?B?Q0p3ZXBDMGlSaGdtcm00aW1HU2trYzVhRDBSRmpoNjFnTTBVeHFJbmo4S040?= =?utf-8?B?YVVYUFcrWitib2hRSTFPMkdrYTJrNStGUEx1UVdVczNtYldHWnZYSjB1cHRl?= =?utf-8?B?VGVXdmIyT00zdWJwU2J4UFhwZ2tzcUt4c0lkd1ZqWGpwTUVHa2h6a2I1QkU1?= =?utf-8?B?VDh2bUk1T1FvMU03RW1rMkNJR2FzRUxJdlgyUThDb1RJcWNkMnNBa3ZscW9S?= =?utf-8?B?T2w1OUovYk13U2RERlhFdU96SENDSEZwcllQUnE5VFlwZ0ZPY0JoQU1TZVY2?= =?utf-8?B?aE5IR1dIekZUeGVBZjNvR1NkcTJibkMxU3hDWHRYUDF4ZUxyQ3ovUWNjejhF?= =?utf-8?B?dVZmSWVub1ZNSndiaHM3eVA5SUpLRlZlSzBaM25nN2VCNEtlMDdaS0dxa2VU?= =?utf-8?B?cy9HQkJKa1BmazFoSVVsQmNTOGtTVXFienYvdGhyeEplQVA2My9mb2IrZUVN?= =?utf-8?B?cGM0RTBlY3h0cHI5QXNsckZMT3JFcEM0SVFkcVBtYThjdHMyMVROaE9TaTla?= =?utf-8?B?bFRMYmNOd3p3cmJRMUVtbHprbVlZLzExejZPSStFWUdVaUJOQXRLVlhJRjd2?= =?utf-8?B?NlRLSlBkWnh6K0hrZzFwRUQ4TGRURi9hK2FzV1QwVU9MVkpZLy9WN3FmaS8x?= =?utf-8?B?WHFnMHVKWjkvbkRyamVOKzBuaGYwRUgvTk55Q1NGNUFLZXdSeVpFR2l0RE9a?= =?utf-8?B?aDZFWTREOVdCcm1FcnNwVkZLdGkyQW4zNHhXNzdsMGx6clVBcGhPNGQ4dGxv?= =?utf-8?B?NEJwL0F0UHprcHI5MkNBWWtldEI1ek1pNVpHZG9vaGhTZzZjaktZd3RMWis2?= =?utf-8?B?K2RqaDIydHNCbUVJTXRiMGRmeUtWUjFtbnlaTlF1NzlCMzNhOXVxa3lPVWFG?= =?utf-8?B?N3FCUlZ6RWp5T2FIRUVtY1ZtYmdjZEpZclNjR2cwRWk1aEVnU0R4czkyNHFX?= =?utf-8?B?WEhacE02NmpUL2N4Sm52OTBNeEdJa2RWZExhMkd3MkpYbFoxTnhIZGtQcjRx?= =?utf-8?Q?tgkcpEHpTU5yRc/KOeS5iUw93?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e77ba04f-022f-49b8-4263-08db0f3921a3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 09:43:45.7300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OQXy8RyuGEHt1I4SYTYmhuLO60CjUKyrRIb8qiYLQeluoV9x54JYQPLnS6SmslNk X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7123 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2023 6:25 AM, Rakesh Kudurumalla wrote: > Introduce new flow action to skip congestion management configuration > This feature helps to skip the congestion management processing > based on per flow or the packet color identified by > rte_flow meter object. For example, If one Rx queue configured as > RED congestion and application wants tobypass the RED congestion > processing for all GREEN color packet can be expressed though > RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action > > Signed-off-by: Rakesh Kudurumalla > Acked-by: Ori Kam > Acked-by: Jerin Jacob > --- > v9: Distributed doc updates to relevant patches > > doc/guides/nics/features/default.ini | 1 + > doc/guides/prog_guide/rte_flow.rst | 22 ++++++++++++++++++++++ > doc/guides/rel_notes/release_23_03.rst | 6 ++++++ > lib/ethdev/rte_flow.h | 11 +++++++++++ > 4 files changed, 40 insertions(+) > > diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini > index 510cc6679d..b93f053a2b 100644 > --- a/doc/guides/nics/features/default.ini > +++ b/doc/guides/nics/features/default.ini > @@ -198,6 +198,7 @@ set_tag = > set_tp_dst = > set_tp_src = > set_ttl = > +skip_cman = > vf = > vxlan_decap = > vxlan_encap = > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index 3e6242803d..4efadcc87b 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1840,6 +1840,28 @@ Drop packets. > | no properties | > +---------------+ > > + > +Action: ``SKIP_CMAN`` > +^^^^^^^^^^^^^^^^^^^^^ > + > +Skip congestion management on received packets > + > +- Using ``rte_eth_cman_config_set()``, application can configure ethdev Rx > + queue's congestion mechanism.Once applied packets congestion configuration > + is bypassed on that particular ethdev Rx queue for all packets directed > + to that receive queue > + > +.. _table_rte_flow_action_skip_cman: > + > +.. table:: SKIP_CMAN > + > + +---------------+ > + | Field | > + +===============+ > + | no properties | > + +---------------+ > + > + > Action: ``COUNT`` > ^^^^^^^^^^^^^^^^^ > > diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst > index bf90feba68..1dd10e26db 100644 > --- a/doc/guides/rel_notes/release_23_03.rst > +++ b/doc/guides/rel_notes/release_23_03.rst > @@ -60,6 +60,12 @@ New Features > Added lock annotations attributes so that clang can statically analyze lock > correctness. > > +* **Added support to skip congestion management configuration.** > + > + Added a new action ``RTE_FLOW_ACTION_TYPE_SKIP_CMAN`` to skip > + congestion management processing based on per flow or packet color > + identified by rte_flow meter object > + Can you please rebase on next-net [1], there you will see other flow API entries? [1] https://dpdk.org/git/next/dpdk-next-net > * **Updated AMD axgbe driver.** > > * Added multi-process support. > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index b60987db4b..6ab632df9d 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2736,6 +2736,17 @@ enum rte_flow_action_type { > * No associated configuration structure. > */ > RTE_FLOW_ACTION_TYPE_SEND_TO_KERNEL, > + > + /** > + * Skip congestion management configuration > + * > + * Using rte_eth_cman_config_set() API the application > + * can configure ethdev Rx queue's congestion mechanism. > + * Introducing RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action to skip the > + * congestion configuration applied to the given ethdev Rx queue. > + * > + */ > + RTE_FLOW_ACTION_TYPE_SKIP_CMAN, > }; > > /**