Re: [PATCH v5] dmadev: add telemetry support

[Kevin Laatz <kevin.laatz@intel.com>]

On 01/04/2022 16:01, Sean Morrissey wrote:
> Telemetry commands are now registered through the dmadev library
> for the gathering of DSA stats. The corresponding callback
> functions for listing dmadevs and providing info and stats for a
> specific dmadev are implemented in the dmadev library.
>
> An example usage can be seen below:
>
> Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2
> {"version": "DPDK 22.03.0-rc2", "pid": 2956551, "max_output_len": 16384}
> Connected to application: "dpdk-dma"
> --> /
> {"/": ["/", "/dmadev/info", "/dmadev/list", "/dmadev/stats", ...]}
> --> /dmadev/list
> {"/dmadev/list": [0, 1]}
> --> /dmadev/info,0
> {"/dmadev/info": {"name": "0000:00:01.0", "nb_vchans": 1, "numa_node": 0,
> "max_vchans": 1, "max_desc": 4096, "min_desc": 32, "max_sges": 0,
> "capabilities": {"mem2mem": 1, "mem2dev": 0, "dev2mem": 0, ...}}}
> --> /dmadev/stats,0,0
> {"/dmadev/stats": {"submitted": 0, "completed": 0, "errors": 0}}
>
> Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> Tested-by: Sunil Pai G <sunil.pai.g@intel.com>
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
> Reviewed-by: Conor Walsh <conor.walsh@intel.com>
> ---
> V5:
> * move capa_names struct back to function
> V4:
> * get capability name from function
>    instead of hardcoded
> * fix checkpatch warnings
> V3:
> * update docs with correct examples
> * code cleanup and added comments
> V2:
> * add device capabilities to info command
> * no requirement to pass vchan id
>    if the device only has one vchan
> * minor code cleanup
> ---
>   doc/guides/prog_guide/dmadev.rst       |  24 +++++
>   doc/guides/rel_notes/release_22_07.rst |   5 +
>   lib/dmadev/meson.build                 |   2 +
>   lib/dmadev/rte_dmadev.c                | 130 +++++++++++++++++++++++++
>   4 files changed, 161 insertions(+)
>
Thanks for adding this, Sean.

Tested-by: Kevin Laatz <kevin.laatz@intel.com>