From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D8B4A0507; Fri, 1 Apr 2022 17:14:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 091564292D; Fri, 1 Apr 2022 17:14:01 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 9BC924292B for ; Fri, 1 Apr 2022 17:13:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648826039; x=1680362039; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=uwqwSw3Hy3lGbBFaLgxQ5cmBlwR/UgBnGjux4ILW8ps=; b=UQqBO2T6wzaLYdJT/bC9X8LscsPK5KTePEhHQT2MrPHMhE4XdTN2wh/W odsLmmnLVFkSvjkQoH+E8Wxup8BQk0+7RNoPnGc7Af1OMlQSVS0PHe8sC dWZI0Yeym+TBY16pDSmYZtTc61yJb0cYWZA0CNBKLHgsKl2uiDXyLRhXV aaBU1SP9f9Ni0waWzEDKsNP61gFkrICWmkMQjXjkkaElZgromXO7gMNjc tXWe0iYPiO7c4y66JR2Z0AyzLgioVuPgrR669dDf2fMWUSWDh3tr4f3u6 JyeV1hkRIMWBNPWgbCfnCHRuCeNqRJB2w7z4Fg+RnJQYwU+e7Gge3jDyR w==; X-IronPort-AV: E=McAfee;i="6200,9189,10304"; a="247664594" X-IronPort-AV: E=Sophos;i="5.90,228,1643702400"; d="scan'208";a="247664594" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2022 08:13:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,228,1643702400"; d="scan'208";a="720913129" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 01 Apr 2022 08:13:58 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 1 Apr 2022 08:13:56 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 1 Apr 2022 08:13:56 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 1 Apr 2022 08:13:56 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 1 Apr 2022 08:13:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cHhsEVVpvbEPBT7oUd7qldHbhh/6IZ2eaSZWx0lKaeIJctGlU2aEGNygAKlNq/j6sQvW5U2S3Ev37Lup5T4g/1aQdVeuexUOfYm3l35xdxzQv5qB/4pSqgE7YWTpHh5MyGR48poOMe9CPiGZMsmKvNXdpB+wYfEUEWqxoCCBEB8kenjh5zBZSj/dvAXs0HQiWGH0rpcf2cbhfZKZuU+ndEC4VYMe/XsQahU5xL6BxxKdv+7kKx0lfRwpWr0WKap/EevPd63EHM0B5zmjnfGaP7yxdg4kfbUBK5DnmtixN8P1HSZ2XPP1qsCAX9WZGQmBwNtEDLDjp7TqSj8hgI0YWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6X9jJEHdjMrKfvqztenx4+HGM0H2GkMuLV6O7OXPalM=; b=aKFTt0RPLaJ1RdCz2Thgz6lH7DdE83IJHOp5+9o3UuKbQQ2WjLpipQrPQrf+93xL0mcD9nvNZuDPCP4vHPO5TsM0uHvXUqrEocvvSnBhW9rITiuRzkMDHxCHvLMGVKsHMPOTsE6fjd0Js2H9BTT2DsIIfZdz1lDvsETBCEkAqggBOzy6iccY7mCblMBhOiWyqDQWnOT70IHp94gpKdDH6D0BHjYfv7CYakAUZq/GfSZXkL7m9cGwmMkQyppmgcy5RpvX6qniG2UY8abczuCYBWbg11DfEXFMttbLJ4o0W9E2UaX8nTcvWm7gWajfchgYs/+r3XooARzTbxnfPBfhiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM4PR11MB5376.namprd11.prod.outlook.com (2603:10b6:5:397::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.25; Fri, 1 Apr 2022 15:13:52 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::e188:d844:25ed:e390]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::e188:d844:25ed:e390%4]) with mapi id 15.20.5102.021; Fri, 1 Apr 2022 15:13:52 +0000 Message-ID: Date: Fri, 1 Apr 2022 16:13:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5] dmadev: add telemetry support To: Sean Morrissey , Chengwen Feng , Bruce Richardson CC: , Sunil Pai G , Conor Walsh References: <20220401145359.2285492-1-sean.morrissey@intel.com> <20220401150136.2295085-1-sean.morrissey@intel.com> From: Kevin Laatz In-Reply-To: <20220401150136.2295085-1-sean.morrissey@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0238.eurprd04.prod.outlook.com (2603:10a6:10:2b1::33) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd4728b6-db2c-42e3-d297-08da13f23b05 X-MS-TrafficTypeDiagnostic: DM4PR11MB5376:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dc8bIqDLf8fS5Psu6Z5VXJec+k1vI/MTeFPjNx+4VY8gOLwxJN4JE4k7Ze7adewv6h26b3BK/JrBEZ2pNre4WW0PjrqGcGx3taMEsLc31Yq6VPGic51h73tAqo3nhsgdS6R1Qki2Yav3B8sbLLFCXWtqOZ2rvpFod7N3lRhhzHyzekeQaAknT/sZOXl5UoG1/ScpQX8sJ3o0Rg4/qoWdUxNiLzPC3ooVxWEWxw6bVcRMnFoECMq/6iOAbgH4WnABqNlFAiq/rk7NBILJAsPlbmx/BLiwvt+iZGeOoUcM8EhcwhnspSe7CIZSNTHIdIPz8WYtbh4bFZ3CfkDtT9tZnwHLO48qekw3HUqqbX2dPa7Agksf3hjfNWM8A4ApNbdGaH0JvvV9mYXhz/BggEUo+B/oHhgt68pclmKT1zDESBza2+PlWjV5V5fbnM+P2f+wYQYD++t3Qf6RS7Frh+LueYtZvHlZBXKw1a0joEuFfn4NqaH1EoxZMVbpmSwiNvXjPLbls/KgBbp9e63Gap1yBx89my4gAFhPe9j8UwPVvQ6uUpK6vFPhpyu5uzPLcecRfBxR2kiUGQ9BnEJ8tG8fLmS2Gw3dHsVGinsDYk4hgI+71QY1vIXdlBhG9uZRB5wrsbd5AcFDemlfuzEj7o3yPrMPhVpbJGfP3BK2jO4oQL7Pxm9Xdy3PYRwzADJxI6YzFqeV3pcP2ZnC8vbBdMTxnhrI84MGFY6rPIgG1mna7r+ZaFce8Nce/wApSC/KC6Mn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(107886003)(83380400001)(186003)(38100700002)(2616005)(44832011)(2906002)(4326008)(36756003)(5660300002)(31686004)(8936002)(8676002)(53546011)(31696002)(6506007)(82960400001)(86362001)(66556008)(6636002)(316002)(54906003)(110136005)(66946007)(6666004)(6512007)(66476007)(508600001)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjlmVStqcklTL01kNmJYU0FvZ1I2bTZKL21maUR1M0FnYjF6WHpuaTNTQjVr?= =?utf-8?B?Y3REMFZ1NFpmdmY5VStjN05SUVdLNTR3Kyt2UjhGcmVnMURiVmhTQ2ZBcWJC?= =?utf-8?B?Qkg0amorWnczK0NhekpjckJweXRGcDhZcmhUOVo0a2JKOGtrRWUzemlpVC9j?= =?utf-8?B?NC9ST1k2c2hpSDZzeFBjZEN3b1VWYytlK1F1Z3NubFk4RjJDcGFNTUEzRU9l?= =?utf-8?B?Q2lPQnN4eFh0RmR2UEpuRmpYY3NSb01WU0R5M25weDdRSFlaNGhVLzloSytR?= =?utf-8?B?QXVFTVMzRHM4WFBOWFY4ZlhWRzR4cW00Wlc0WHpkWHE1bmZST2hhNlUya1RR?= =?utf-8?B?ME43elRIcXVMRUU2NjRFaDZOeGlTekROcUtBOVUwSjlHaHJzdWN3Zjd1cnVW?= =?utf-8?B?bnFLdDE1UEFkclVKeTFERDJTOUxQMkVyZzJWa2xNZ1JjQTRQNTcxTkE2ME50?= =?utf-8?B?a3RpV3FlVFhpOGtqMnlHbjFMaDRhVGpQYy9BRm8rTXJnVlk4TXVhdkJxcnZU?= =?utf-8?B?aFZiY0lqUkdBYkJ5UjRGR2dVK1Fna0xsK0VwN1dqWTFFZlJoVWhpSVZGZGIy?= =?utf-8?B?MzVOemYyUjFkVldLNG9jZ3ltMVc1aVBkNk1EVGVsYThHSmF2THMvOEJ5YlI2?= =?utf-8?B?VDRhaGlicXZzUTlmcUZQTUtEN1BPMktQcnVrZGNZT2dlMTFSY3MxNUtoNzFO?= =?utf-8?B?WVVXSVgxOUVlc2RHakV3RGh2M2JldGRTSnRidnJGOTFFTFlxTzcvaG9FWDU4?= =?utf-8?B?TU1LMFdiQzlBWWRzMExqUDJkMGlOVGIwaXl3Vm1sQ0FSckhPbVJZZXoybnNH?= =?utf-8?B?WktrNHluNk9YRjFqV2xvNFBFRmw3emkvM2RMbXdDVGZpMmtndk8vNmFaYUp3?= =?utf-8?B?cFFlcEpibjdZUHJqTStwS0twYzBuRVEzRUk2cEN2d0crbU9Hc2dRdE9lWmlD?= =?utf-8?B?VVhjNVBjSWIrUTF0R2FtekRtZVFPVFM0UHNNZENSNmJaakpoK08wNnNOV0dS?= =?utf-8?B?ektCa2lZM2dtK1pqNytONGlpZW5KS3JsVVI5VFpCRk9lSGNoWTNhQ3k4VWIw?= =?utf-8?B?b29veFNjZUUvaGhBdVd0V2trS3lzNFNiN3U2TDByUUlhRGJGanJGNkY5RHJl?= =?utf-8?B?WlpGbjg3SnJGYnZjQmNNMXk1Vlp5OHVSL05yY3FiUVZxclo4Q3hCVXRzaEQ5?= =?utf-8?B?eGdhQVhwQVkyNXEzSlIrc3pmSDV2V2F6WE9DUW1nMzdLVFBGNlBobjNnUk1h?= =?utf-8?B?cGlyZjZjMGZ2Y0t2N2xJallqVlY2bVJFZGt6akhselFNaHhmSzI0VTVWTFBi?= =?utf-8?B?SlFUbDA3SHZVUisvRlZ5UlhyZkhWek1LN3U3eWhWNEp6S3FocHJzQ3hwVVVL?= =?utf-8?B?UkNTdktjeEd4OVJHdTQ0THUxc01uUjBDdmxMRks2NE5DZW5NQUZmeEx1QXRl?= =?utf-8?B?Qkc2T1BQOE5TU3BISVQxaGdxd3l2eHZVNVR0MnVZbzBQN0p1SGVjc1VlQ2JK?= =?utf-8?B?Mlp4V0ZLMEpDenVLbHE3UnlHdjlVSTV5QVpMTWZQZjZnRlYxMGdSMlBXVWt6?= =?utf-8?B?U0lheDkzRm56UWp3MVp5MXI1OFpIc2lUcWRwZGFiZ0FmMUMycTVvNjhER2dy?= =?utf-8?B?ZVhzUHF1REplS0hiRW4vTHJGeC9LRmpRWmJYNFBnY3M0VVhiUTVyckZueXhC?= =?utf-8?B?Nk50bG1NMFp3MlZOeDFycm1WcFVIYUZMcDJGbE1keEFhSVQrL3gvaHBkbE9Y?= =?utf-8?B?UTRIRHhiZFR4bzNjVDREK2h1U1JhTVNlS1VqU1I0YXBPelJQMyt6RWhybWRP?= =?utf-8?B?WmxEQVdTWHFMajFZcjUxbXFxNk9uWC9ZMEZ6OHpNRTBPcXR4bVBZWEVqVjIx?= =?utf-8?B?WEd2RG1KcWpHMVFXSVlkRlFacGl6T0lwK1VqeXpNTVdESFpleGR2bnRvZGdL?= =?utf-8?B?TURPejBnQWxpMXpnZ2dBWUZ1ZG1qalhPcDRFME56Q05uUSsvTDdwZ3kxZFBj?= =?utf-8?B?RnJEazVUZFJkbG9vQS9OTVlFalM0enliNnpJTkhxcmRZZUV1R3BCM3d6NzVQ?= =?utf-8?B?aG1VbUdHWGQ1WEpVajZOQ1cvMENYSmNsUS92L3c0V2VBMWdpQVFkaVhXYk1a?= =?utf-8?B?enZtbXZBNm0zbW42VWRhSUxGVGJocklNTXJNd2pDdVJqaWNrRmxGUU9qYU9o?= =?utf-8?B?dTVmR3hTU3RHVTJqVzZBVng1UUJVdWxJOXMxZTMvekFyRXNIRlRuNHdQODRs?= =?utf-8?B?SzFzS0NvMFozSFNMQ3FWaVFiMVN0emx1VDYzRVpNOGk0ZThQSjQzQ1kxQ3Uz?= =?utf-8?B?WEVUakNabGF5cW83SzA2OFhONHpMRGErUmwzRHZUT3ZidGpsUDFDemd4OWI4?= =?utf-8?Q?o4QCGjstVuaIJ788=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bd4728b6-db2c-42e3-d297-08da13f23b05 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 15:13:52.2252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SQhbvI6YonYedJi7U0THy/PuPrEdhvXSqaaBoRaKw18ty5RtPGD1rVLGfwgfICOehpRDPaLlI3+fMd2rq9YP8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5376 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 01/04/2022 16:01, Sean Morrissey wrote: > Telemetry commands are now registered through the dmadev library > for the gathering of DSA stats. The corresponding callback > functions for listing dmadevs and providing info and stats for a > specific dmadev are implemented in the dmadev library. > > An example usage can be seen below: > > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > {"version": "DPDK 22.03.0-rc2", "pid": 2956551, "max_output_len": 16384} > Connected to application: "dpdk-dma" > --> / > {"/": ["/", "/dmadev/info", "/dmadev/list", "/dmadev/stats", ...]} > --> /dmadev/list > {"/dmadev/list": [0, 1]} > --> /dmadev/info,0 > {"/dmadev/info": {"name": "0000:00:01.0", "nb_vchans": 1, "numa_node": 0, > "max_vchans": 1, "max_desc": 4096, "min_desc": 32, "max_sges": 0, > "capabilities": {"mem2mem": 1, "mem2dev": 0, "dev2mem": 0, ...}}} > --> /dmadev/stats,0,0 > {"/dmadev/stats": {"submitted": 0, "completed": 0, "errors": 0}} > > Signed-off-by: Sean Morrissey > Tested-by: Sunil Pai G > Reviewed-by: Bruce Richardson > Reviewed-by: Conor Walsh > --- > V5: > * move capa_names struct back to function > V4: > * get capability name from function > instead of hardcoded > * fix checkpatch warnings > V3: > * update docs with correct examples > * code cleanup and added comments > V2: > * add device capabilities to info command > * no requirement to pass vchan id > if the device only has one vchan > * minor code cleanup > --- > doc/guides/prog_guide/dmadev.rst | 24 +++++ > doc/guides/rel_notes/release_22_07.rst | 5 + > lib/dmadev/meson.build | 2 + > lib/dmadev/rte_dmadev.c | 130 +++++++++++++++++++++++++ > 4 files changed, 161 insertions(+) > Thanks for adding this, Sean. Tested-by: Kevin Laatz