From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78292A04BA; Thu, 17 Sep 2020 11:58:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 062511C135; Thu, 17 Sep 2020 11:58:23 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 5A6ED1C10E for ; Thu, 17 Sep 2020 11:58:22 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.137]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id E333620069; Thu, 17 Sep 2020 09:58:21 +0000 (UTC) Received: from us4-mdac16-22.at1.mdlocal (unknown [10.110.49.204]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id E3FEA6009B; Thu, 17 Sep 2020 09:58:21 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.30]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 6D5AA22004D; Thu, 17 Sep 2020 09:58:21 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 02AF514005D; Thu, 17 Sep 2020 09:58:21 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 17 Sep 2020 10:58:15 +0100 To: "Min Hu (Connor)" , CC: , , , References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1600332730-44952-1-git-send-email-humin29@huawei.com> <1600332730-44952-2-git-send-email-humin29@huawei.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: Date: Thu, 17 Sep 2020 12:58:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1600332730-44952-2-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25670.003 X-TM-AS-Result: No-20.720100-8.000000-10 X-TMASE-MatchedRID: Ync95tbzDRnmLzc6AOD8DfHkpkyUphL9APiR4btCEeYMrRrnLCZEmmlp muYgAcs4dOoPdC4yUWizRs6JvWq9DAXjSpVHn22DUCKhNQpxDxdc8r3LfPzYa5GhAvBSa2i/kR8 +7XSOlVl1fTPbQWW/W+BPwjUi5QqfJi1UeopbkRWInASnzB5VfFJAsn89ih94Bph69XjMbdlAHO g8qEtqyMxZVy5VE4SVrbzO2egx+l1OXYgmvJXVIbBZAi3nrnzbiwylHMputSTHkH7uosEn7CBhQ 6yz+UaYbMNF9ka96Ejjl6MHj3MNM25Y5G74YU3HfjUCBXbhed/kY2blxNFpR2KuDy0kKGx0D2ny mbg6iZKkpvq+WFYWjrObYQOf3NbKZFnOBL1vNaZZMZ6MZ0H1UvzHfjr1UU/5VI7KaIl9Nhcz/f5 O4Oppd48Rt++x9hGOs8R70MBUB2c21ZMkjYN/kkhwlOfYeSqxB4Id7CiQcz+7ZzoEEZwujLJnPh 8w+R5oPnSC6OpmKvMVVop8MCWBYF5UNxzJViZjFEiDvEGKJxYx/k92L7R8thlLPW+8b7SaNaRgQ 20sMyKDnkF+97zxYrugj/Kk54fOHEsuFokV5zeqNnzrkU+2mt2Emh5Z2S/NUCgEErrUGFwAu02E q+/J6UKW569qkbFJyZoeBwcV2uU4lC5Kv9wUbn9EwA0OW8Ql1JP9NndNOkXpHGdqGkDFZodaYX5 m6/4YlHVH/UHDB9Gdl2t7D5Swff9ehdaP6yTu52cbj4/WmPuNhgPVdWNTApsoi2XrUn/JyeMtMD 9QOgChMIDkR/KfwI2j49Ftap9EkGUtrowrXLg= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--20.720100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25670.003 X-MDID: 1600336701-v3qNxO3a-C9c Subject: Re: [dpdk-dev] [V5 1/3] ethdev: introduce FEC API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/17/20 11:52 AM, Min Hu (Connor) wrote: > This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed-by: Chengchang Tang > --- > v4->v5: > Modifies FEC capa definitions using macros. > Add RTE_ prefix for public FEC mode enum. > add release notes about FEC for dpdk20_11. > > --- > v2->v3: > add function return value "-ENOTSUP" for API > > --- > doc/guides/rel_notes/release_20_11.rst | 13 +++++ > lib/librte_ethdev/rte_ethdev.c | 50 +++++++++++++++++++ > lib/librte_ethdev/rte_ethdev.h | 83 ++++++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_core.h | 77 +++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_version.map | 5 ++ > 5 files changed, 228 insertions(+) > > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index cc72609..e4f0587 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -55,6 +55,19 @@ New Features > Also, make sure to start the actual text at the margin. > ======================================================= > > +* **Added the FEC Library, a generic FEC query and config library.** > + > + Added the FEC library which provides an API for query FEC capabilities and > + FEC mode from device. Also, API for configuring FEC mode is also provided. The patch does not add a library. It adds an API get FEC capabilities, get current configuration and allows to set a new configuration. > + > + Added hns3 FEC PMD, for supporting query and config FEC mode. If required, it should be later in release notes in accordance with defined order. > + > +* **Updated testpmd with a command for FEC.** > + > + Added a FEC command to testpmd app, > + ``show port fec capabilities`` which queries FEC capabilities device supports. > + ``show port fec_mode`` which queries FEC mode from device. > + ``set port fec_mode `` which configures FEC mode to device. IMHO, it is not much details for release notes. As I understand it is assumed that testpmd must be updated for any new ethdev feature, so, the information about testpmd is not really required. > > Removed Items > ------------- > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index 7858ad5..fde77c1 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -3642,6 +3642,56 @@ rte_eth_led_off(uint16_t port_id) > return eth_err(port_id, (*dev->dev_ops->dev_led_off)(dev)); > } > > +int > +rte_eth_fec_get_capability(uint16_t port_id, uint32_t *fec_cap) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get_capability, -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->fec_get_capability)(dev, > + fec_cap)); > +} > + > +int > +rte_eth_fec_get(uint16_t port_id, enum rte_fec_mode *mode) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get, -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->fec_get)(dev, mode)); > +} > + > +int > +rte_eth_fec_set(uint16_t port_id, enum rte_fec_mode mode) > +{ > + struct rte_eth_dev *dev; > + uint32_t fec_mode_mask; > + int ret; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); Basically the check is duplicated since get_capabilities does it. However, there is no much harm to keep. If so, I'd move it below just before port_id usage as an index in rte_eth_devices array. > + > + ret = rte_eth_fec_get_capability(port_id, &fec_mode_mask); > + if (ret) Please, compare with 0 explicitly as specified in DPDK coding style. > + return ret; > + > + /* > + * Check whether the configured mode is within the FEC capability. > + * If not, the configured mode will not be supported. > + */ > + if (!(fec_mode_mask & (1U << (uint32_t)mode))) { > + RTE_ETHDEV_LOG(ERR, "unsupported fec mode=%d\n", mode); I'd use "FEC" (in capitals) in log message as well. Also I think it would be useful to log port_id. . > + return -EINVAL; > + } > + > + dev = &rte_eth_devices[port_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_set, -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->fec_set)(dev, mode)); > +} > + > /* > * Returns index into MAC address array of addr. Use 00:00:00:00:00:00 to find > * an empty spot. > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 70295d7..aa79326 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1511,6 +1511,25 @@ struct rte_eth_dcb_info { > struct rte_eth_dcb_tc_queue_mapping tc_queue; > }; > > +/** > + * This enum indicates the possible (forward error correction)FEC modes > + * of an ethdev port. > + */ > +enum rte_fec_mode { enum rte_eth_fec_mode to be consistent with other enums and to have library prefix. > + RTE_ETH_FEC_NOFEC = 0, /**< FEC is off */ > + RTE_ETH_FEC_BASER, /**< FEC using common algorithm */ > + RTE_ETH_FEC_RS, /**< FEC using RS algorithm */ > + RTE_ETH_FEC_AUTO, /**< FEC autonegotiation modes */ May I suggest to put AUTO just after NOFEC. It would look move logical in the future when more FEC modes are added. It would look strange with AUTO in the middle of the list. > + RTE_ETH_FEC_NUM I'm not about about current policy for such items. Is it really required? Addition of more FEC modes will be ABI breakage. > +}; > + > +/* This indicates FEC capabilities */ > +#define RTE_ETH_FEC_CAPA_NOFEC (1U << RTE_ETH_FEC_NOFEC) > +#define RTE_ETH_FEC_CAPA_BASER (1U << RTE_ETH_FEC_BASER) > +#define RTE_ETH_FEC_CAPA_RS (1U << RTE_ETH_FEC_RS) > +#define RTE_ETH_FEC_CAPA_AUTO (1U << RTE_ETH_FEC_AUTO) > + > + > #define RTE_ETH_ALL RTE_MAX_ETHPORTS > > /* Macros to check for valid port */ > @@ -3328,6 +3347,70 @@ int rte_eth_led_on(uint16_t port_id); > int rte_eth_led_off(uint16_t port_id); > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Get Forward Error Correction(FEC) capability. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param fec_cap > + * returns the FEC capability from the device, as follows: > + * RTE_ETH_FEC_CAPA_NOFEC > + * RTE_ETH_FEC_CAPA_BASER > + * RTE_ETH_FEC_CAPA_RS > + * RTE_ETH_FEC_CAPA_AUTO I'd like to see thoughts about different FEC modes for different link speed. How to report it? (sorry if I missed it before) > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support. > + * that operation. > + * - (-EIO) if device is removed. > + * - (-ENODEV) if *port_id* invalid. > + */ > +__rte_experimental > +int rte_eth_fec_get_capability(uint16_t port_id, uint32_t *fec_cap); [snip]