From: Maryam Tahhan <mtahhan@redhat.com>
To: dev@dpdk.org
Subject: Re: [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf
Date: Fri, 10 May 2024 13:20:43 +0100 [thread overview]
Message-ID: <f5276f66-2d71-4662-88d3-26abb8f483c8@redhat.com> (raw)
In-Reply-To: <20240510100358.18815-1-ciara.loftus@intel.com>
On 10/05/2024 11:03, Ciara Loftus wrote:
> Record the port id in the af_xdp rx queue structure and use it
> to set the port id of the mbuf of a received packed.
>
> Bugzilla ID: 1428
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
> cc: stable@dpdk.og
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
Acked-by:Maryam Tahhan <mtahhan@redhat.com>
> ---
> drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index 268a130c49..fee0d5d5f3 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -131,6 +131,7 @@ struct pkt_rx_queue {
> struct xsk_umem_info *umem;
> struct xsk_socket *xsk;
> struct rte_mempool *mb_pool;
> + uint16_t port;
>
> struct rx_stats stats;
>
> @@ -360,6 +361,7 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> bufs[i]->data_off = offset - sizeof(struct rte_mbuf) -
> rte_pktmbuf_priv_size(umem->mb_pool) -
> umem->mb_pool->header_size;
> + bufs[i]->port = rxq->port;
>
> rte_pktmbuf_pkt_len(bufs[i]) = len;
> rte_pktmbuf_data_len(bufs[i]) = len;
> @@ -426,6 +428,7 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> rte_pktmbuf_data_len(mbufs[i]) = len;
> rx_bytes += len;
> bufs[i] = mbufs[i];
> + bufs[i]->port = rxq->port;
> }
>
> xsk_ring_cons__release(rx, nb_pkts);
> @@ -1779,6 +1782,8 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
>
> process_private->rxq_xsk_fds[rx_queue_id] = rxq->fds[0].fd;
>
> + rxq->port = dev->data->port_id;
> +
> dev->data->rx_queues[rx_queue_id] = rxq;
> return 0;
>
next prev parent reply other threads:[~2024-05-10 12:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:03 Ciara Loftus
2024-05-10 10:03 ` [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic Ciara Loftus
2024-05-10 12:35 ` Maryam Tahhan
2024-05-10 15:06 ` Stephen Hemminger
2024-05-13 8:23 ` Maryam Tahhan
2024-05-13 15:53 ` Stephen Hemminger
2024-05-14 8:37 ` Loftus, Ciara
2024-05-10 10:03 ` [PATCH 3/3] net/af_xdp: Fix stats reset Ciara Loftus
2024-05-10 12:36 ` Maryam Tahhan
2024-05-10 12:20 ` Maryam Tahhan [this message]
2024-05-10 14:58 ` [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5276f66-2d71-4662-88d3-26abb8f483c8@redhat.com \
--to=mtahhan@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).