DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v1 1/1] iavf: document limitation on MTU
@ 2024-03-13 15:43 Anatoly Burakov
  2024-03-19 12:14 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Anatoly Burakov @ 2024-03-13 15:43 UTC (permalink / raw)
  To: dev, Yuying Zhang; +Cc: john.mcnamara, bruce.richardson

When configuring a port, the configured MTU will
not include VLAN tag size, but the physical
function driver will add it automatically if the
port has VLAN filtering configured, which may
result in seemingly valid MTU to be rejected by
the PF.

Document the limitation.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 doc/guides/nics/intel_vf.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst
index ce2bd88cbe..78fd25bad4 100644
--- a/doc/guides/nics/intel_vf.rst
+++ b/doc/guides/nics/intel_vf.rst
@@ -730,3 +730,13 @@ and has this issue.
 
 Set the parameter `--force-max-simd-bitwidth` as 64/128/256
 to avoid selecting AVX-512 Tx path.
+
+ice: VLAN tag length not included in MTU
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+When configuring MTU for a VF, MTU must not include VLAN tag length. In
+practice, when kernel driver configures VLAN filtering for a VF, the VLAN
+header tag length will be automatically added to MTU when configuring queues.
+As a consequence, when attempting to configure a VF port with MTU that, together
+with a VLAN tag header, exceeds maximum supported MTU, port configuration will
+fail if kernel driver has configured VLAN filtering on that VF.
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] iavf: document limitation on MTU
  2024-03-13 15:43 [PATCH v1 1/1] iavf: document limitation on MTU Anatoly Burakov
@ 2024-03-19 12:14 ` Bruce Richardson
  2024-03-19 15:15   ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2024-03-19 12:14 UTC (permalink / raw)
  To: Anatoly Burakov; +Cc: dev, Yuying Zhang, john.mcnamara

On Wed, Mar 13, 2024 at 03:43:35PM +0000, Anatoly Burakov wrote:
> When configuring a port, the configured MTU will
> not include VLAN tag size, but the physical
> function driver will add it automatically if the
> port has VLAN filtering configured, which may
> result in seemingly valid MTU to be rejected by
> the PF.
> 
> Document the limitation.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] iavf: document limitation on MTU
  2024-03-19 12:14 ` Bruce Richardson
@ 2024-03-19 15:15   ` Bruce Richardson
  0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2024-03-19 15:15 UTC (permalink / raw)
  To: Anatoly Burakov; +Cc: dev, Yuying Zhang, john.mcnamara

On Tue, Mar 19, 2024 at 12:14:53PM +0000, Bruce Richardson wrote:
> On Wed, Mar 13, 2024 at 03:43:35PM +0000, Anatoly Burakov wrote:
> > When configuring a port, the configured MTU will
> > not include VLAN tag size, but the physical
> > function driver will add it automatically if the
> > port has VLAN filtering configured, which may
> > result in seemingly valid MTU to be rejected by
> > the PF.
> > 
> > Document the limitation.
> > 
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied to dpdk-next-net-intel

Thanks,
/Bruce

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-19 15:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-13 15:43 [PATCH v1 1/1] iavf: document limitation on MTU Anatoly Burakov
2024-03-19 12:14 ` Bruce Richardson
2024-03-19 15:15   ` Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).