From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: xiaoyun.li@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix bitmap of link speeds when force speed
Date: Wed, 14 Apr 2021 12:55:39 +0100 [thread overview]
Message-ID: <f55ae34b-3864-aad1-d14e-f0b794168b06@intel.com> (raw)
In-Reply-To: <1618369325-32797-1-git-send-email-humin29@huawei.com>
On 4/14/2021 4:02 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
>
> Currently, when the user sets force link speed through 'link_speeds',
> bit(0) of 'link_speeds' is not set to 1(ETH_LINK_SPEED_FIXED),
> which conflicts with the definition.
>
> Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function")
> Cc: stable@dpdk.org
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v2:
> * When users set 10M and 100M speed, fixed bit is still set.
> v2 fix the bug.
Moving acks from previous version
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-04-14 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 10:22 [dpdk-dev] [PATCH] " Min Hu (Connor)
2021-04-13 17:08 ` Ferruh Yigit
2021-04-13 17:10 ` Ajit Khaparde
2021-04-14 3:02 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-04-14 11:55 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f55ae34b-3864-aad1-d14e-f0b794168b06@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).