DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix bitmap of link speeds when force speed
@ 2021-04-08 10:22 Min Hu (Connor)
  2021-04-13 17:08 ` Ferruh Yigit
  2021-04-14  3:02 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
  0 siblings, 2 replies; 5+ messages in thread
From: Min Hu (Connor) @ 2021-04-08 10:22 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, xiaoyun.li

From: Huisong Li <lihuisong@huawei.com>

Currently, when the user sets force link speed through 'link_speeds',
bit(0) of 'link_speeds' is not set to 1(ETH_LINK_SPEED_FIXED),
which conflicts with the definition.

Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 app/test-pmd/cmdline.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f44116b..8c36de2 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1523,6 +1523,9 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed)
 			printf("Unknown speed parameter\n");
 			return -1;
 		}
+
+		if (*speed != ETH_LINK_SPEED_AUTONEG)
+			*speed |= ETH_LINK_SPEED_FIXED;
 	}
 
 	return 0;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-14 11:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 10:22 [dpdk-dev] [PATCH] app/testpmd: fix bitmap of link speeds when force speed Min Hu (Connor)
2021-04-13 17:08 ` Ferruh Yigit
2021-04-13 17:10   ` Ajit Khaparde
2021-04-14  3:02 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-04-14 11:55   ` Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git