From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 54893A04FD;
	Wed,  8 Jun 2022 14:06:35 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 461F742BBE;
	Wed,  8 Jun 2022 14:06:35 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 4242940687
 for <dev@dpdk.org>; Wed,  8 Jun 2022 14:06:34 +0200 (CEST)
Received: from [192.168.1.40] (unknown [188.170.81.145])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B691A306;
 Wed,  8 Jun 2022 15:06:33 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B691A306
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1654689994;
 bh=6oIKAneDQ7QZ7ca6f/1mo7VPpD736TlcTx8R7xACL6g=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=YZQDuVHoxavBUEIdOnZcccVt4t/yyv1W8jAumhcP/jHKESYUyMMIuUcOAn9rthW6M
 hZIPHjqMarW3V9Eb7hinKUYKZeSDjEpkRBqbffFzNmRvHTKvfVgDErldwXuJfDWt1+
 F59RJBlCAncAp/isFVqQq2z0uyb4J7XZyzqbxhUg=
Message-ID: <f577a418-8d24-fe89-f765-d26a1ee49d36@oktetlabs.ru>
Date: Wed, 8 Jun 2022 15:06:33 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v3 1/1] app/testpmd: support different input color method
Content-Language: en-US
To: skori@marvell.com, Xiaoyun Li <xiaoyun.li@intel.com>,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang
 <yuying.zhang@intel.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org
References: <20220525143716.996398-1-skori@marvell.com>
 <20220603130627.149785-1-skori@marvell.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20220603130627.149785-1-skori@marvell.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 6/3/22 16:06, skori@marvell.com wrote:
> From: Sunil Kumar Kori <skori@marvell.com>
> 
> To enable input coloring, based on VLAN or DSCP, patch adds
> command line interface to configure the following:
> 
>   - configuring input coloring using VLAN or DSCP while creating
>     meter i.e. during rte_mtr_create()
> 
>   - Update VLAN input coloring table at runtime.
> 
>   - configures protocol priorities.
> 
>   - retrieve protocol and priority information
> 
> Depends-on: patch-22751 ("ethdev: mtr: support protocol based input color selection")
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

[snip]

> +		if (strcmp(token, "G") == 0 || strcmp(token, "g") == 0)

strcasecmp() will help to make it a bit simpler.
Here and in many similar cases below.