From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0066.outbound.protection.outlook.com [104.47.36.66]) by dpdk.org (Postfix) with ESMTP id 07E1B1B710 for ; Fri, 13 Oct 2017 16:43:40 +0200 (CEST) Received: from BN3PR03CA0092.namprd03.prod.outlook.com (10.167.1.180) by BN6PR03MB2692.namprd03.prod.outlook.com (10.173.144.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 14:43:39 +0000 Received: from BL2FFO11OLC001.protection.gbl (2a01:111:f400:7c09::135) by BN3PR03CA0092.outlook.office365.com (2a01:111:e400:7a4d::52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.56.11 via Frontend Transport; Fri, 13 Oct 2017 14:43:39 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC001.mail.protection.outlook.com (10.173.161.185) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 13 Oct 2017 14:43:39 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v9DEhabh010956; Fri, 13 Oct 2017 07:43:37 -0700 To: , CC: , References: <20171012130726.4332-1-alok.makhariya@nxp.com> From: Akhil Goyal Message-ID: Date: Fri, 13 Oct 2017 20:13:36 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171012130726.4332-1-alok.makhariya@nxp.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523794197105768; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(346002)(39860400002)(39380400002)(376002)(2980300002)(1110001)(1109001)(339900001)(377454003)(199003)(24454002)(189002)(356003)(5660300001)(106466001)(68736007)(8936002)(65826007)(50466002)(305945005)(105606002)(54356999)(50986999)(76176999)(316002)(47776003)(4326008)(53936002)(23676002)(58126008)(65956001)(65806001)(97736004)(6246003)(104016004)(83506001)(2906002)(85426001)(110136005)(81166006)(2950100002)(31686004)(8676002)(33646002)(31696002)(77096006)(36756003)(53546010)(8656003)(498600001)(81156014)(229853002)(54906003)(64126003)(230700001)(86362001)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2692; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC001; 1:NxRL/243k3FWgBeOdE2cT6lABeCXCMwxUNK0x56+rNYA3sfucuca9SgO1WXEVqtgt8pwXuwL1qb+J2Zgcm9ad+0VfRTQ61TpGDtr022P/IhUK3xk4h3AWj5qIrE+q7KV X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 151adf03-9ace-4343-eb0a-08d51248cb15 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:BN6PR03MB2692; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2692; 3:qYHv4rngC4lquJDehIRTtnbyTrj6fjofLW4hLehzbj5zauLAzcVLuXUzqmUc7YmiQXB76WxsrrxZ2fP9w5xF9MzN6/bCW4++Wc1WRxy9fX/on8K+v7QZ3RcjtZNwADTrOOdWisdZxrZt6q7yq0RtiX5qGv4ZSWEwVEqE9L99LDbfK7yo6NRDUSoITV7BZgIJS4M2nuArkCtc0lthsacxpTqKh7NSfLHpsIkWFKQrZ9nZtgpdb4CEEQfd7b2n9OIgjBvdjFVOcgig8iFDMA8ZYyuGpvdAZOSp/14/Y0oJ0B79jrOAPZ3kvxHrF4H1mjARC6dUFOSwU+LTsmTiIABOgcW4keGiPRhJFkiO0a8dc3k=; 25:oSGtqAyWQw1jEGjTwKxLjp0LDTOl9spXnVVHHj2oMr8MyeNJrSEKaGzVMp6LfJrZBQp7hLeQYjQrWsh+1GQBw57HJZwIF7pKzHU6LUhnwLqe6llbJwlw6QFrohxiqtOfzlVxv1Hwo7MXgOVkq4ODvEnaiCDIGr2ewBcUe16Wcwk2C1qy2Rqh89sbUiv0OeileNW7iIntrYEfXEecrNT95c/AuU1jtqOoZxr2BHTtGGRcNhunkOn0bAhDgl1LG9uVyGg3V1Q7WBtiFrdKBPJO5q6fObFHPD8pgjKoNmJLGWFMYuTqGwAB+Pi3xNj4g5LD6HUHUbm8vZE4XywNdO58EQ== X-MS-TrafficTypeDiagnostic: BN6PR03MB2692: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2692; 31:eSZFREB4qf9Hx7AJLaQeU1vql4pUt/Pdmtdnkx5WymvEmdrLAzKngKM/18SqdUO0RVEJZ/jaxqB7h7WDZJwvRa3PTXoPwFe9rJWbUNsU7BRt354kY7ZuVVxPoaQrErluenI1T9vSuBXMBeIWqtuUv7wyPcPa0NVNiuUso9oCgGxCcLi7FWpvUoHsHsAvcjEcZSQYH/K0w046RF95Ei8OinYEh9qB21g9S7Utxq66HLI=; 4:UCGEeKTiUjYFIpfCCZ9FgbyCPmVZ0TiFs5G+fRUdOIN3v6zmkNAv164RwORZE8Med+g8PMhiVZHH4RDgY0waP0UdP2Qb+BjNxEKzhpcMz1QjSSZPteD8OqlToDtLVG5Kuzr0XBWutAu9UKghk8imKUwg5o2yDXNpMo/keNC44itlJib8q5TvsCcjpcp2V03sf7z/UyOAvWbfucUU6qVv1QDr4olFD23nfPTxcJ0yeYyXj/SAKmepwVOJ/CqP3MSunHkIgJtu91Lrlwb/ibxtbSNCIL5n+QYWaZgVB0CHrng= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123556025)(20161123561025)(20161123559100)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR03MB2692; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR03MB2692; X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyNjkyOzIzOkJFQTVXQ1BIdjExY2FudTRQYy9GOUtjeU03?= =?utf-8?B?ZnlKeGxYNE8rYVJEbWV3VUIwUnpsQjlnR1FwZWw1ajNDRlRGREo3c3FJcTU5?= =?utf-8?B?M3FaRSttbUVEUW4zeTNaU3hBcHoxTDZzZS9ocjNGNk9yTVM0UGlsU0x0c0x3?= =?utf-8?B?eEJnWGw4VDBnaHBBQm9CZnpGM2YzUGxLdEwza3FzVXdPMTNrZDQ1RlgyYTVh?= =?utf-8?B?NDJjZk4rZ2l0eGp5VWM2bDdlVzNZT2pOLzRnbUlNZmNteFhESUJDNVBxcm5J?= =?utf-8?B?blByYkpibWNCUkllcXAvb0pTekQzeEUzNFpWOHNpNkdWMm1TRWRLWW5GcnZL?= =?utf-8?B?ZjdkWXBTZWh1K1hmekxYZWlRQUI5VG5HZUxZbnRJZnIxV2RNT3hST0p4Tytj?= =?utf-8?B?OWdvZDZOdnlPdXdmRis3blBBbVpDeFcxanBvOTNSNUdkekVtRzM1M25CTmJt?= =?utf-8?B?RUV1SjhDd2VhbVRobk00b2N3bm9wd2pKdWVSVkxRdUZ2cGQ4UC9vaEFlNWtB?= =?utf-8?B?b01YUy9FWkZ1bG5LUVJhY205ODA5cy9sUThEcGZHTEkwZFZldVdTbThINWIw?= =?utf-8?B?QlRnd3VlMHVuTSs0aUwyb0hVUSt3QVVjT3YyT2tOOHY3aFliSlpkUklUaFl3?= =?utf-8?B?N2U3cnl0TmRkbk5sL1FaekpGN0Uzc1p1dkNPU2NVYjhLWG1vaVRhdHJLZlZy?= =?utf-8?B?NUdsNG05RnFCQW90ZHN1ZzNWek5BV0ljVFZxV3JYdTRJQnZucm42V0NvVHNV?= =?utf-8?B?SUR2U2lWeFM5SCtzZkJVbldxRkZmd1hTRXFsS2g4dm50R2N1VmoyRzFFTHZI?= =?utf-8?B?YzdqcVhuR1c4QkV4ZVNTend5THN5K08yTFUwWURLNEdPOXJBS1lHV0g1d29p?= =?utf-8?B?Y09yb0QrNUkrOVNGL1JNeS9tbWxUNnlYUkp0bFRQNDN0Y09UZ0VBenBmalNZ?= =?utf-8?B?a2JXWElNcVlmYkFxOGtOdTZrZEljWGg2R0kxN3RnMXlSSnRUMDgwai93Rm4r?= =?utf-8?B?dGt2NnpUZGZFNFpvNVc4ZWNCU2pTWDEwTW9EMGYvaXNzbmdXbWdUeW1EQmFm?= =?utf-8?B?Ny9PbEp5VTdjaGdyUDhsQmZmTWQ2SkxUb0tSQzNyTVNVRlVhSjRHdGZuYUIy?= =?utf-8?B?eXFTVll4aXVMcFUxZ3hyMkhnYVN6NCtzT0wrV285RDlkZDdMSHFwVTMwcTdO?= =?utf-8?B?VVQ4eWhDdEtSd2JueGpnUzlWYm12aW5KTDNwU29oTlNETTVDNThxbFlIaStW?= =?utf-8?B?Y0phajVNR0lPazNoeGJhaG9GaEhCWE0wQXFoNlpMeDE5cFlQVUxzYXptU3Iz?= =?utf-8?B?UUM0UHVLemtORXJOZ01qTm1GREhSRmFaRTdLZWRZMmpsN2xpN1M2c3ZVNFhJ?= =?utf-8?B?N2Y3M3RkK0ltSUhnYW1mMXA3azVmT252Y2NMRlUxQTJrc2lkSjI1MHJJekp5?= =?utf-8?B?UXVpZlcxVVlqLzdSSTNsZmVnMmUvdzFiczJmQjhsay9tZnRxUGdWd1p3Y0xn?= =?utf-8?B?WExUTkllTHlSclZpdklJZjZSUW5YbktwcVI3ZW00alNqRm9BMTlQM1YwN050?= =?utf-8?B?NndHeTBuL3d0NG9abVZtSlFtdk9rZzYxLzlNa3JMQS9HQkhCVXkralFlUU1p?= =?utf-8?B?OEtZOXJ1ZHBPR1ZSTDJ1ZW5hQWNJc3h0clNjMEsxblZmM25OTUt0RGxxb1BL?= =?utf-8?B?Wm9yc1VxZWV4VytFTmJnZW1ZQmhpQys3eEFWdnhtTCtoeElnaStQeXFPbEtN?= =?utf-8?B?dWpEeTJ5NWF2b29ERmhpb3N2Y1J1QjhMRUdlREV2NFBwV2tSUWZjYkFONTV0?= =?utf-8?B?OVZNeWxlZVpubHhZTVpvZHRSalhXdXFmNU9yMDQ2ZzJEL2dZWlZOcWNHd1Ni?= =?utf-8?Q?a90jijOE97Ldhganqe6rj8glvkGgHqRt?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2692; 6:TM+qMt6ZAN8HgUZ5Inat5Di7uIxNjfl3AsRKYcC3haHi0eIR/gGNMUTRFrQa2B2Q/JDub4YUGdfPy2yi7RLule2IPbwXmuGYAOgfn8GhUJDAtIhyS4qvMylibh1UrLI7Aexx4MgqowE+b7+HPWDxF5T3aUouYg6RiboPP7PW9WWHaVvZ+GA8ycJ7zrzng8oG7yurol+EVHQYzA/GzG/kB5JTz+LK2TKrIR4GlWzxsGSNLA6kLnEA9DniJxxUoHe/fJqHWHr1R68a5sqmcDbNWk4+eCgTskYS4i2N72EL/JUNESB6zG6vrx+GRWOiMfKY9wMeVg3xOgENu69ihs28ig==; 5:BiM6PR6kPiDJmcrQYOAwtQeTKo8q4HHi1pucxZ0hpM0J2uWY026wnF9PfcJhvAZUkTgnJ6pMDW7oMK7QgG86JIcfuJmL1+LRMe3r1ApVNpy5LL8kTisdQ+GBgW0ipNKjaq0y8nx2loR7v5/Oaplw2Q==; 24:bfqwUPOqP11m0H3uf8pTy8xeFTnwe8t0WN7EtPUKq3/5HXhfvv3Bs2u5OqwOkIbWBcAyk+C29oB9o3veYI6TjiVJu0bOSyvmB5nYMM3N3qw=; 7:At283DBpf/Aatcwuzg2XlIh4/Cc0m9sz+ZRDwVD6Yygddy7BAbIoY3CfVogu2FpWl+osQx9ixmAfLwIl6scwG8ROTb+E18bl31yIf1nDK9yOos1saqGMy13KlLXBkFONB11kuuzw33LEDGgPojM8mRTjir3fvHLOod5CGhkp6eoWxgoq2BMHK0RsVt8bebTEdktxl6ghRDi/DG2ZuWUM823fTblCBG8+ViwI4p2TGW0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 14:43:39.5233 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2692 Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: add check for segmented buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 14:43:41 -0000 On 10/12/2017 6:37 PM, alok.makhariya@nxp.com wrote: > From: Alok Makhariya > > The code would crash in case of segmented buffer if no check > > Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") > > Signed-off-by: Alok Makhariya > --- > drivers/crypto/dpaa_sec/dpaa_sec.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c > index 7b9a683..8a57b96 100644 > --- a/drivers/crypto/dpaa_sec/dpaa_sec.c > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c > @@ -893,6 +893,13 @@ dpaa_sec_enqueue_op(struct rte_crypto_op *op, struct dpaa_sec_qp *qp) > return ret; > } > > + /* > + * Segmented buffer is not supported. > + */ > + if (!rte_pktmbuf_is_contiguous(op->sym->m_src)) { > + op->status = RTE_CRYPTO_OP_STATUS_ERROR; > + return -ENOTSUP; > + } > if (is_auth_only(ses)) { > cf = build_auth_only(op, ses); > } else if (is_cipher_only(ses)) { > It looks there are some checkpatch errors.