DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jens Freimann <jfreimann@redhat.com>, dev@dpdk.org
Cc: tiwei.bie@intel.com
Subject: Re: [dpdk-dev] [PATCH v5] net/virtio: set offload flag for jumbo frames
Date: Fri, 8 Feb 2019 19:05:50 +0100	[thread overview]
Message-ID: <f581d002-5818-48b1-ae08-1d5d76299021@redhat.com> (raw)
In-Reply-To: <20190205111702.14782-1-jfreimann@redhat.com>



On 2/5/19 12:17 PM, Jens Freimann wrote:
> Port configuration fails because offload flags don't match the expected
> value when max-pkt-len is set to a value that should enable receive port
> offloading but doesn't.
> 
> The .dev_infos_get callback can be called before the configure callback.
> At that time we don't know the maximum packet size yet because it is
> only set up when ports are started. So in virtio_dev_info_get() just
> always set the jumbo packet offload flag.
> 
> Check the maximum packet length at device configure time, because then we
> have access to the max-pkt-len value provided by the user. If the
> max-pkt-len exceeds the maximum MTU supported by the device we remove
> the VIRTIO_NET_F_MTU flag from requested features.
> 
> Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 

Applied to dpdk-next-virtio/master.

Thanks,
Maxime

      parent reply	other threads:[~2019-02-08 18:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 11:17 Jens Freimann
2019-02-08  9:51 ` Maxime Coquelin
2019-02-08 18:05 ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f581d002-5818-48b1-ae08-1d5d76299021@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jfreimann@redhat.com \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).