From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by dpdk.org (Postfix) with ESMTP id 5135837B4 for ; Mon, 26 Mar 2018 20:05:20 +0200 (CEST) Received: by mail-qt0-f195.google.com with SMTP id f8so20513236qtg.12 for ; Mon, 26 Mar 2018 11:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Az1/mJT3lkE90jRsNHMgzkBm9mSZSAcXOhcoKtFzJ9Q=; b=LE3GcMV41eyX8D6NFnfT1mfxr2l5seNvVZpjfcc9itiq+/LTE33JSyW5TKL0NAuPTl zI87LFkErlBaYZ4w+3OqvmXvn7JGn4jrN1gsI+71JlZ/FHSqTNT/mHhJt0vIptEo6UKM t1QkXn+JCdh+ydpETawlJRP38YgHo0E1ROY+8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Az1/mJT3lkE90jRsNHMgzkBm9mSZSAcXOhcoKtFzJ9Q=; b=XCNDZmX8uBfzZnJJ+t+MsVHEqeZKKDdOiduXffMLlkJgIJEV1U55x8YO70v7lJJ2SX aDQ11qmGnkbw+XUTOpP5WRUVchKnACPr5+Wa/UEjI1hxKe5nyNx3mMRW3hihZUsl/cek aIpY9sfdpHxg97kjE6jpQwbqprBO9iYobFp7eKNXVGIeBiI+Qez3thw/UTgWHe6h0A2j gG1QKSmRQgpcTAwqbru8rbx7KhTTnsguQkmBT5T5FJ00ZMwI7Vwy6T3vJnyqbFVrE4Id g0D3YACTNRfCSor6wWg7ZnE1W+SXylIjwwHgeo/bAcQcnHt3L/Vh50DrZN34Ys2LZ9cR wNRw== X-Gm-Message-State: AElRT7HhI7Xwg2afUHGakUNUt/Wu961RVOYT3kxsC+DRYlNX5hA6C80r 5u48703ha0Tb5usPzlFocuSAsrT9 X-Google-Smtp-Source: AG47ELtJ7IRydnpkz4GHwwkPXvppDm5XQ6Djwdw7G6w1qHjJYApHyJUsZHY/A4xDioKRVVUS89vdVA== X-Received: by 10.200.48.247 with SMTP id w52mr57378270qta.226.1522087519227; Mon, 26 Mar 2018 11:05:19 -0700 (PDT) Received: from [10.136.13.65] ([192.19.224.250]) by smtp.gmail.com with ESMTPSA id w63sm1403551qtd.4.2018.03.26.11.05.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 11:05:17 -0700 (PDT) To: Ferruh Yigit , Ajit Khaparde , dev@dpdk.org Cc: Darren Edamura , Rahul Gupta References: <20180321180629.58318-1-ajit.khaparde@broadcom.com> <20180321180629.58318-5-ajit.khaparde@broadcom.com> <9c01c36e-b2a3-db28-f9b8-ccae8f33e71d@intel.com> From: Scott Branden Message-ID: Date: Mon, 26 Mar 2018 11:05:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <9c01c36e-b2a3-db28-f9b8-ccae8f33e71d@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 4/4] igb_uio: bind error if pcie bridge X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 18:05:20 -0000 Hi Ferruh, On 18-03-26 10:24 AM, Ferruh Yigit wrote: > On 3/21/2018 6:06 PM, Ajit Khaparde wrote: >> From: Darren Edamura >> >> Probe function should exit immediately if pcie bridge detected >> >> Signed-off-by: Darren Edamura >> Signed-off-by: Rahul Gupta >> Signed-off-by: Scott Branden >> Signed-off-by: Ajit Khaparde >> --- >> lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> index 4cae4dd27..3fabbfc4d 100644 >> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> @@ -473,6 +473,9 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) >> void *map_addr; >> int err; >> >> + if (pci_is_bridge(dev)) >> + return -ENODEV; > What do you think printing a log here? I think it brings little value.  ENODEV is already returned? > >> + >> udev = kzalloc(sizeof(struct rte_uio_pci_dev), GFP_KERNEL); >> if (!udev) >> return -ENOMEM; >> Regards,  Scott