DPDK patches and discussions
 help / color / mirror / Atom feed
From: Timothy Redaelli <tredaelli@redhat.com>
To: dev@dpdk.org
Cc: vladimir.medvedkin@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 2/3] app/test: fix building with GCC 10
Date: Wed,  5 Feb 2020 13:50:42 +0100	[thread overview]
Message-ID: <f59f8c92d3d478a5f71c0ec017d4ea16d3c16c59.1580906522.git.tredaelli@redhat.com> (raw)
In-Reply-To: <cover.1580906522.git.tredaelli@redhat.com>

GCC 10 defaults to -fno-common, this means a linker error will now be
reported if the same global variable is defined in more than one
compilation unit.

Fixes: 08e0c7581468 ("test/fib: add performance autotests")
Cc: vladimir.medvedkin@intel.com
Cc: stable@dpdk.org
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
 app/test/test_fib_perf.c | 2 +-
 app/test/test_lpm_perf.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_fib_perf.c b/app/test/test_fib_perf.c
index 573087c3c..dd2e54db8 100644
--- a/app/test/test_fib_perf.c
+++ b/app/test/test_fib_perf.c
@@ -35,7 +35,7 @@ struct route_rule {
 	uint8_t depth;
 };
 
-struct route_rule large_route_table[MAX_RULE_NUM];
+static struct route_rule large_route_table[MAX_RULE_NUM];
 
 static uint32_t num_route_entries;
 #define NUM_ROUTE_ENTRIES num_route_entries
diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index a2578fe90..489719c40 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -34,7 +34,7 @@ struct route_rule {
 	uint8_t depth;
 };
 
-struct route_rule large_route_table[MAX_RULE_NUM];
+static struct route_rule large_route_table[MAX_RULE_NUM];
 
 static uint32_t num_route_entries;
 #define NUM_ROUTE_ENTRIES num_route_entries
-- 
2.24.1


  parent reply	other threads:[~2020-02-05 12:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 12:50 [dpdk-dev] [PATCH 0/3] " Timothy Redaelli
2020-02-05 12:50 ` [dpdk-dev] [PATCH 1/3] crypto/octeontx2: " Timothy Redaelli
2020-02-05 12:59   ` [dpdk-dev] [EXT] " Anoob Joseph
2020-02-05 12:50 ` Timothy Redaelli [this message]
2020-02-05 13:41   ` [dpdk-dev] [PATCH 2/3] app/test: " Medvedkin, Vladimir
2020-02-05 12:50 ` [dpdk-dev] [PATCH 3/3] app/test-pipeline: " Timothy Redaelli
2020-02-05 13:26   ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-03-04 10:09 ` [dpdk-dev] [PATCH 0/3] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f59f8c92d3d478a5f71c0ec017d4ea16d3c16c59.1580906522.git.tredaelli@redhat.com \
    --to=tredaelli@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).