From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4D0A016E for ; Thu, 29 Mar 2018 12:06:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 03:06:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208,217";a="215923111" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.81]) ([10.237.221.81]) by fmsmga005.fm.intel.com with ESMTP; 29 Mar 2018 03:06:10 -0700 To: Anoob Joseph , Akhil Goyal Cc: Declan Doherty , Jerin Jacob , Narayana Prasad , dev@dpdk.org References: <1521784251-14820-1-git-send-email-anoob.joseph@caviumnetworks.com> <186665b3-c687-33af-d61f-bfcd28ccd76e@caviumnetworks.com> From: Radu Nicolau Message-ID: Date: Thu, 29 Mar 2018 11:06:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <186665b3-c687-33af-d61f-bfcd28ccd76e@caviumnetworks.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 10:06:14 -0000 On 3/28/2018 3:28 PM, Anoob Joseph wrote: > Hi Akhil, Radu, > > Did you get time to review the patch? > > Thanks, > Anoob > > On 23/03/18 11:20, Anoob Joseph wrote: >> Removing redundant strncmp in parsing long arguments. The getopt library >> provides means to identify long options using the "val" field of >> structure option. The existing code gets 0 as "val" for all long >> arguments and then uses strncmp to figure out which long option was >> being referred to. Fixing this. >> >> In addition, the macros and enums used for long arguments have been >> renamed and repositioned adhering to the general convention followed in >> various other apps, like l3fwd. >> >> Signed-off-by: Anoob Joseph >> --- Acked-by: Radu Nicolau