From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5FD5E2A5D for ; Wed, 9 Aug 2017 14:52:37 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2017 05:52:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,347,1498546800"; d="scan'208";a="117256280" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 09 Aug 2017 05:52:35 -0700 To: Zhiyong Yang , dev@dpdk.org Cc: thomas@monjalon.net References: <20170809084203.17562-1-zhiyong.yang@intel.com> <20170809084203.17562-2-zhiyong.yang@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 9 Aug 2017 13:52:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170809084203.17562-2-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: increase port_id range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Aug 2017 12:52:38 -0000 On 8/9/2017 9:42 AM, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib > ethdev data structures, specifically rte_eth_dev_data and > modify the APIs using port_id at the same time. > > Signed-off-by: Zhiyong Yang > --- > app/pdump/main.c | 2 +- > app/test-pmd/cmdline.c | 4 +- > app/test-pmd/testpmd.c | 4 +- > app/test-pmd/testpmd.h | 2 +- > drivers/net/bonding/rte_eth_bond.h | 40 ++--- > drivers/net/bonding/rte_eth_bond_8023ad.c | 6 +- > drivers/net/bonding/rte_eth_bond_api.c | 54 +++---- > drivers/net/bonding/rte_eth_bond_pmd.c | 10 +- > drivers/net/bonding/rte_eth_bond_private.h | 36 ++--- > drivers/net/failsafe/failsafe_ether.c | 4 +- > drivers/net/failsafe/failsafe_private.h | 4 +- > drivers/net/ring/rte_eth_ring.c | 2 +- I would expect more drivers would be effected from this, almost all. Most PMDs stores the dev->data->port_in in their private data and use this value while updating mbuf field, those local storage also should be updated to u16 to prevent data loss. Can you please double check drivers, specially data->port_id usages? I quickly checked null and pcap for example, both needs to be updated. Also PMDs with PMD specific API are getting port_id as parameter, so they should be updated too. And I am getting build error for ixgbe and i40e for log type format, - via clang. Thanks, ferruh > lib/librte_ether/rte_ethdev.c | 231 ++++++++++++++-------------- > lib/librte_ether/rte_ethdev.h | 236 ++++++++++++++--------------- > lib/librte_ether/rte_tm.c | 62 ++++---- > lib/librte_ether/rte_tm.h | 60 ++++---- > lib/librte_ether/rte_tm_driver.h | 2 +- > lib/librte_latencystats/rte_latencystats.c | 8 +- > lib/librte_pdump/rte_pdump.c | 16 +- > lib/librte_pdump/rte_pdump.h | 4 +- > lib/librte_port/rte_port_ethdev.c | 6 +- > lib/librte_port/rte_port_ethdev.h | 6 +- > 22 files changed, 404 insertions(+), 395 deletions(-) <...>