From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: <197020236@qq.com>, <chas3@att.com>
Cc: <dev@dpdk.org>, "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Subject: Re: [dpdk-dev] [PATCH] dedicated queues: delete redundant check valid_bonded_port_id has include check_for_bonded_ethdev, no need to check again.
Date: Thu, 2 Jul 2020 09:02:59 +0800 [thread overview]
Message-ID: <f5be671b-a245-02fe-244b-0bdcae6ecc1d@huawei.com> (raw)
In-Reply-To: <20200621133455.6BFC01C0C0@dpdk.org>
Hi, pandongyang
The title is too long, and lack of the commit log.
You can use this script to check your commit when making patch
./devtools/check-git-log.sh -[num]
On 2020/6/21 21:34, 197020236@qq.com wrote:
> From: pandongyang <197020236@qq.com>
>
> Signed-off-by: pandongyang <197020236@qq.com>
> ---
> drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index b77a37d..3393743 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -1675,9 +1675,6 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
> dev = &rte_eth_devices[port];
> internals = dev->data->dev_private;
>
> - if (check_for_bonded_ethdev(dev) != 0)
> - return -1;
> -
> if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
> return -1;
>
Maybe it is better to remove another place as follows
int
rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
{
int retval = 0;
struct rte_eth_dev *dev;
struct bond_dev_private *internals;
if (valid_bonded_port_id(port) != 0)
return -EINVAL;
dev = &rte_eth_devices[port];
internals = dev->data->dev_private;
- if (check_for_bonded_ethdev(dev) != 0)
- return -1;
[snip]
> @@ -1704,9 +1701,6 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
> dev = &rte_eth_devices[port];
> internals = dev->data->dev_private;
>
> - if (check_for_bonded_ethdev(dev) != 0)
> - return -1;
> -
> /* Device must be stopped to set up slow queue */
> if (dev->data->dev_started)
> return -1;
similar to above comment
int
rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
{
int retval = 0;
struct rte_eth_dev *dev;
struct bond_dev_private *internals;
if (valid_bonded_port_id(port) != 0)
return -EINVAL;
dev = &rte_eth_devices[port];
internals = dev->data->dev_private;
- if (check_for_bonded_ethdev(dev) != 0)
- return -1;
[snip]
Thanks, Xavier
next parent reply other threads:[~2020-07-02 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200621133455.6BFC01C0C0@dpdk.org>
2020-07-02 1:02 ` Wei Hu (Xavier) [this message]
2020-07-04 1:22 ` =?gb18030?B?19S/2MXLtqzR8w==?=
2020-06-21 13:34 197020236
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5be671b-a245-02fe-244b-0bdcae6ecc1d@huawei.com \
--to=xavier.huwei@huawei.com \
--cc=197020236@qq.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).