From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C35AA0523; Thu, 2 Jul 2020 03:03:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5DCB1D55E; Thu, 2 Jul 2020 03:03:15 +0200 (CEST) Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id 9CB221D166 for ; Thu, 2 Jul 2020 03:03:11 +0200 (CEST) Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id DA7C9DC65E02D5F83DCE; Thu, 2 Jul 2020 09:03:09 +0800 (CST) Received: from [10.69.31.206] (10.69.31.206) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Thu, 2 Jul 2020 09:02:59 +0800 To: <197020236@qq.com>, References: <20200621133455.6BFC01C0C0@dpdk.org> CC: , "Wei Hu (Xavier)" From: "Wei Hu (Xavier)" Message-ID: Date: Thu, 2 Jul 2020 09:02:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20200621133455.6BFC01C0C0@dpdk.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.31.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] dedicated queues: delete redundant check valid_bonded_port_id has include check_for_bonded_ethdev, no need to check again. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, pandongyang The title is too long, and lack of the commit log. You can use this script to check your commit when making patch ./devtools/check-git-log.sh -[num] On 2020/6/21 21:34, 197020236@qq.com wrote: > From: pandongyang <197020236@qq.com> > > Signed-off-by: pandongyang <197020236@qq.com> > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c > index b77a37d..3393743 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -1675,9 +1675,6 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port) > dev = &rte_eth_devices[port]; > internals = dev->data->dev_private; > > - if (check_for_bonded_ethdev(dev) != 0) > - return -1; > - > if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0) > return -1; > Maybe it is better to remove another place as follows int rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port) { int retval = 0; struct rte_eth_dev *dev; struct bond_dev_private *internals; if (valid_bonded_port_id(port) != 0) return -EINVAL; dev = &rte_eth_devices[port]; internals = dev->data->dev_private; - if (check_for_bonded_ethdev(dev) != 0) - return -1; [snip] > @@ -1704,9 +1701,6 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port) > dev = &rte_eth_devices[port]; > internals = dev->data->dev_private; > > - if (check_for_bonded_ethdev(dev) != 0) > - return -1; > - > /* Device must be stopped to set up slow queue */ > if (dev->data->dev_started) > return -1; similar to above comment int rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port) { int retval = 0; struct rte_eth_dev *dev; struct bond_dev_private *internals; if (valid_bonded_port_id(port) != 0) return -EINVAL; dev = &rte_eth_devices[port]; internals = dev->data->dev_private; - if (check_for_bonded_ethdev(dev) != 0) - return -1; [snip] Thanks, Xavier