From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9205EA04DD; Fri, 30 Oct 2020 09:30:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CFDD6CA9; Fri, 30 Oct 2020 09:30:30 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D0A7A6A1C; Fri, 30 Oct 2020 09:30:27 +0100 (CET) IronPort-SDR: 1rtBMPWJbtGBFFgFm34LtIXxoSOKA/tsK/m+fFNJJ57cxnXu7c8r6w9Lef70F4+aMcINk+js8x HOY1BV2cCthA== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="168707024" X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="168707024" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 01:30:26 -0700 IronPort-SDR: lR+/OMTNrpqPTGCJB+5WjY5em16bbkvQTUhW93mkzFZuTxPXeVda1/8UV8ZGMbRq5hDtb4NWNP qZ5XfO5Psv3g== X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="536990476" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.23.197]) ([10.252.23.197]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 01:30:25 -0700 To: "Zhang, Yuying" , "dev@dpdk.org" , "Zhang, Qi Z" , "Xing, Beilei" Cc: "stable@dpdk.org" References: <20200920152813.674261-1-yuying.zhang@intel.com> <20201019022025.1748497-1-yuying.zhang@intel.com> <1b5954fa-aff1-2694-c205-551b00a7773a@intel.com> From: Ferruh Yigit Message-ID: Date: Fri, 30 Oct 2020 08:30:24 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/30/2020 5:32 AM, Zhang, Yuying wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, October 23, 2020 6:42 PM >> To: Zhang, Yuying ; dev@dpdk.org; Zhang, Qi Z >> ; Xing, Beilei >> Cc: stable@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction issue >> >> On 10/19/2020 3:20 AM, Yuying Zhang wrote: >>> i40evf_execute_vf_cmd() uses _atomic_set_cmd() to execute virtual >>> channel commands safely in multi-process mode and multi-thread mode. >>> However, it returns -1 when one process or thread is pending. Add >>> rte_spinlock_trylock() to handle this issue in concurrent scenarios. >>> >> >> Should '_atomic_set_cmd()' removed, since spinlock it added? >> >>> Fixes: 4861cde46116 ("i40e: new poll mode driver") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Yuying Zhang >> >> <...> > '_atomic_set_cmd()' is also used for sync with i40evf_handle_aq_msg to handle the request <-> response. > It is not just used for multi-task. I prefer to keep the atomic. > OK