From: Remy Horton <remy.horton@intel.com>
To: Qiming Yang <qiming.yang@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/ethtool: fix bug in drvinfo callback
Date: Wed, 23 Nov 2016 09:00:47 +0800 [thread overview]
Message-ID: <f5d536d4-fe53-5ff9-4f6f-add6f102c171@intel.com> (raw)
In-Reply-To: <1479778884-26993-1-git-send-email-qiming.yang@intel.com>
Not sure this is a problem in practice, as the same set if fields is
updated each time...at least for now.
On 22/11/2016 09:41, Qiming Yang wrote:
> Function pcmd_drvinfo_callback uses struct info to get
> the ethtool information of each port. Struct info will
> store the information of previous port until this
> information be updated. This patch fixes this issue.
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Remy Horton <remy.horton@intel.com>
next prev parent reply other threads:[~2016-11-23 1:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 9:40 [dpdk-dev] [PATCH] " Qiming Yang
2016-11-22 1:41 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2016-11-23 1:00 ` Remy Horton [this message]
2016-12-20 17:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5d536d4-fe53-5ff9-4f6f-add6f102c171@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).