From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5810C47D2 for ; Wed, 23 Nov 2016 02:00:49 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 22 Nov 2016 17:00:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,535,1473145200"; d="scan'208";a="34633997" Received: from rhorton-mobl.ger.corp.intel.com (HELO [10.239.204.110]) ([10.239.204.110]) by fmsmga006.fm.intel.com with ESMTP; 22 Nov 2016 17:00:48 -0800 To: Qiming Yang , dev@dpdk.org References: <1479462013-11562-1-git-send-email-qiming.yang@intel.com> <1479778884-26993-1-git-send-email-qiming.yang@intel.com> From: Remy Horton Organization: Intel Shannon Limited Message-ID: Date: Wed, 23 Nov 2016 09:00:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1479778884-26993-1-git-send-email-qiming.yang@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] examples/ethtool: fix bug in drvinfo callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2016 01:00:50 -0000 Not sure this is a problem in practice, as the same set if fields is updated each time...at least for now. On 22/11/2016 09:41, Qiming Yang wrote: > Function pcmd_drvinfo_callback uses struct info to get > the ethtool information of each port. Struct info will > store the information of previous port until this > information be updated. This patch fixes this issue. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") > > Signed-off-by: Qiming Yang Acked-by: Remy Horton