From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id EE53A4F91 for ; Tue, 9 Apr 2019 12:37:35 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id n25so2713213wmk.4 for ; Tue, 09 Apr 2019 03:37:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ij2JWhx6E/tJ26BKIPer8erjbgvDWAdlSm68R7Lwfn4=; b=kYO599RoHbswNXElpWlf15hBcr/WKBjkoQ5vyCBKTn5lAhcRkdaXOaukYSSZ+7ndx8 pDM1nWuzVLJU9nb6kGKM4BgS8rH6vBcgz6jhCU6muvcpu1psE7U2zHwc++Axh0AR5y0V Py80Si/cd2FBKTfyGMyLx1myG3jM81or+S1PiMjc9lPZQukZCWLiNmgCR23wqlf+PbsV DA4CnnfoiGZlT6ARzDjVxQQhx1zAYvPNiyh4YQJiNqrkroeyV3A6NqxGf0Mm2MgjbLuM X9HCAxwl0NuAqXcNPeGA0U5+7Z1nRcd13bxH413wrTxgCkeEdL1ZJrywWhL/bWD9kGiz A+Nw== X-Gm-Message-State: APjAAAUwrPhdK98Gs+ZTm1v5M6WWe6qjPCJLNBpvoTqfNhvaIb9YcWu5 gcIQWrJC+C8Hxix5Dx/LSHg= X-Google-Smtp-Source: APXvYqy/DE0Ah3uYnS4kPgA3u039QKc0Kh5XrNAgRhYA4rop56MdnQylYEVOFaxWfk5VDHlAaSr8EQ== X-Received: by 2002:a7b:c14c:: with SMTP id z12mr20383598wmi.138.1554806255653; Tue, 09 Apr 2019 03:37:35 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id 61sm108728766wre.50.2019.04.09.03.37.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 03:37:34 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Tue, 09 Apr 2019 11:37:34 +0100 In-Reply-To: <20190409092933.55356-6-bruce.richardson@intel.com> References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-6-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 10:37:36 -0000 On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > The pipefile option does not seem to exist on FreeBSD, giving an > error > when running the script. >=20 > Fixes: 5d9176673008 ("devtools: fix meson build test to exit on > failure") >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > devtools/test-meson-builds.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > builds.sh > index b3b5cfbb5..1fd23fac7 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -7,7 +7,10 @@ > # * if a build-directory already exists we assume it was properly > configured > # Run ninja after configuration is done. > =20 > -set -o pipefail > +# this option gives an error on BSD > +if [ "`uname`" =3D=3D "Linux" ] ; then > + set -o pipefail > +fi > =20 > srcdir=3D$(dirname $(readlink -f $0))/.. > MESON=3D${MESON:-meson} With the =3D=3D fix: Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E534AA0096 for ; Tue, 9 Apr 2019 12:37:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9B354F98; Tue, 9 Apr 2019 12:37:37 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id EE53A4F91 for ; Tue, 9 Apr 2019 12:37:35 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id n25so2713213wmk.4 for ; Tue, 09 Apr 2019 03:37:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ij2JWhx6E/tJ26BKIPer8erjbgvDWAdlSm68R7Lwfn4=; b=kYO599RoHbswNXElpWlf15hBcr/WKBjkoQ5vyCBKTn5lAhcRkdaXOaukYSSZ+7ndx8 pDM1nWuzVLJU9nb6kGKM4BgS8rH6vBcgz6jhCU6muvcpu1psE7U2zHwc++Axh0AR5y0V Py80Si/cd2FBKTfyGMyLx1myG3jM81or+S1PiMjc9lPZQukZCWLiNmgCR23wqlf+PbsV DA4CnnfoiGZlT6ARzDjVxQQhx1zAYvPNiyh4YQJiNqrkroeyV3A6NqxGf0Mm2MgjbLuM X9HCAxwl0NuAqXcNPeGA0U5+7Z1nRcd13bxH413wrTxgCkeEdL1ZJrywWhL/bWD9kGiz A+Nw== X-Gm-Message-State: APjAAAUwrPhdK98Gs+ZTm1v5M6WWe6qjPCJLNBpvoTqfNhvaIb9YcWu5 gcIQWrJC+C8Hxix5Dx/LSHg= X-Google-Smtp-Source: APXvYqy/DE0Ah3uYnS4kPgA3u039QKc0Kh5XrNAgRhYA4rop56MdnQylYEVOFaxWfk5VDHlAaSr8EQ== X-Received: by 2002:a7b:c14c:: with SMTP id z12mr20383598wmi.138.1554806255653; Tue, 09 Apr 2019 03:37:35 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id 61sm108728766wre.50.2019.04.09.03.37.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 03:37:34 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Tue, 09 Apr 2019 11:37:34 +0100 In-Reply-To: <20190409092933.55356-6-bruce.richardson@intel.com> References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-6-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409103734.3piLIcXxOwXcfxMAiGDarVX995e5QuqiDSH3uPgNqcY@z> On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > The pipefile option does not seem to exist on FreeBSD, giving an > error > when running the script. >=20 > Fixes: 5d9176673008 ("devtools: fix meson build test to exit on > failure") >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > devtools/test-meson-builds.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > builds.sh > index b3b5cfbb5..1fd23fac7 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -7,7 +7,10 @@ > # * if a build-directory already exists we assume it was properly > configured > # Run ninja after configuration is done. > =20 > -set -o pipefail > +# this option gives an error on BSD > +if [ "`uname`" =3D=3D "Linux" ] ; then > + set -o pipefail > +fi > =20 > srcdir=3D$(dirname $(readlink -f $0))/.. > MESON=3D${MESON:-meson} With the =3D=3D fix: Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi