From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB67041B85; Mon, 30 Jan 2023 23:13:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B601740C35; Mon, 30 Jan 2023 23:13:54 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2053.outbound.protection.outlook.com [40.107.94.53]) by mails.dpdk.org (Postfix) with ESMTP id 4996A40698 for <dev@dpdk.org>; Mon, 30 Jan 2023 23:13:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SMMeiJyS5GeQ06Xrx3mlE/4PmIxc722pUcbT2PUUEBy3mbhCVyQWL5f+l6iftDVTIE9AyCM1mNFHzg55j28Wuw8NKgqlCcQiWZ+YUyd8kHubMZFxn9wzuIoprRfz0fCiYo0fh77C2ylMwAF87UG+aT16yd76n2TZshFp61xkWRkTJdSW+I0RUepN9Ep5DMvb58hOvO+3tV4HxxhVyb5H8FV/KtPlMVm+oMN+ba+WhsMwQKPExRDDa90s5a9hlRLrDfAolJTipx8XhytOAvMUjsRsOQ07sTHrsgBAUdViSHvHvgEgrWgRFhQJuqlTL6iXiojlYx4vNAl2mmSJi0+DvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i076+zpL1F9453l1OpLtwt1k0MzM7lTR20czqUdcJpc=; b=HfzymzDTiWE3pKJCIxEX78vry/3XENh6JSkocsUaOqEWTNWy1VIS8Uh2MYhXBY7x310pxGRvVhOkakRpBXV0DoDEwl1GEKhf+vIUCJ+P3U8xCMjQQD3vqa1G9h3wcvzPdQT1Us83M1Ee+MukHqHB7vsrB3MXeRSWqCRcN7lEDmMlFuVkDFeswPen9/iNjLi/NQjL50e9edbl0jyDSFkA+Ly4tA/iIVmNT+U9wOFmnMmto8bcxq9B3WyoRVSvIfc71+ymEt80j7JgSM+DiL/z+i4MZWdnA85ZuNN5oYmm3WUMSKhw3yMWZmkZcDZQeKzjuuwQsm90HYMqIXtPkJp/Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i076+zpL1F9453l1OpLtwt1k0MzM7lTR20czqUdcJpc=; b=bUFTe7ZHFRarKapwvGimzdtH+5NhaiWfg6O128y4aYKUgaY8utzhibVniT4UciuiNVyyDzTGIihF9ppGYgnSlCN9MgCGf5DG3rzDrspga6mP3rqsCIMwyThkoGpSMSavjPyDqpF+mlYbTa+8pKcWiEURGf7Qybj8/tvrY4O4kHw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB8095.namprd12.prod.outlook.com (2603:10b6:806:33f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 22:13:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6043.036; Mon, 30 Jan 2023 22:13:51 +0000 Message-ID: <f5f2d454-9e67-9761-21d9-0d0402b4eba8@amd.com> Date: Mon, 30 Jan 2023 22:13:46 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v10 0/2] testpmd: handle signals safely Content-Language: en-US To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org References: <20221014172328.185219-1-stephen@networkplumber.org> <20230130200914.22049-1-stephen@networkplumber.org> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <20230130200914.22049-1-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0007.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB8095:EE_ X-MS-Office365-Filtering-Correlation-Id: 19760f65-15c5-4756-7e9f-08db030f4451 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZznSal2F/zKoMBfJyWsbXB8iUs/GH3WpCYre+1G74wrDWK3gQO9O5UJN4XQRwS2h8zQBSpEq0qsjEWHkfOyxKNQjAp9xTsyh2C25hKgfXWxlbyz8hiI964xP+RNy/pAyjGO9cpe4QB+jiBEyXVKVVKi8i+Vs7jq5hum0en7l2erMW/77IHxhpP2LxNU2JMfjGnocFuSS9OD9JYkNgzgUJuGsotHXNnOO4dr6YfoaYiOgfDGR5Ui8is1nTT8gjUyjcIwdDFwSnrfF7W5nP3K+Bc9VHa18BS8LGffyk0SvMRTZzg+ij0Re4ySEIWmOtz0WkJf2TYkRodw3lOKtA+j3dByi0E6Mg2CLNPKAUaMWk/W5kR2HM/lxuSN9DV1BQ6ChTR+UxleTT5RM/8EBIPOl9M6iPWvCrNhbdjvjh1c58m1WpstGBJcqCpEpV8RaFZ+62Uel7LysvxmuYHJpS7TP+0xAVGYiVXW8ilRFbdOoCdeOqDFU6q61H3cT8ppU+q+wxY2t13i1F9ZORdK/rD7CKzb015KZgMSGmYdIerKGa/qu8Y5Cn7wk8L9fhYJ/nwhjqsIejxCkFYzsequhyFMcs5fSULrLj0lKp5mteSUuhwzwLEKLoImjVy64/HNbc0n8qZ1XBdzTW3y8JWTXsObYYOoRN73Gv8gnhdq/PQhnYlEvHuDwOvgpXHiqKMsu5RpmtwzBUDjLi/B1pQdBZyetU6z7Lzrgx9PANdfaaQc1T24= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(451199018)(31686004)(36756003)(66476007)(8676002)(66556008)(8936002)(66946007)(316002)(5660300002)(38100700002)(86362001)(31696002)(53546011)(26005)(6506007)(6512007)(6666004)(186003)(44832011)(4744005)(2906002)(6486002)(478600001)(41300700001)(83380400001)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVVzQlNGcGdmWG5IeEcxUkhic1hiODRzbTY4Nm92M3VySnFid0NFUnpRYnBz?= =?utf-8?B?WDE3eFpOTVdYeEhKMlBJOXh4bzQ2eGhsTndFRS9pNzBHUWZwUS83Zld1SXRp?= =?utf-8?B?VWJjV0tKNGdWQnQxeFBjcFhMVEdoQXZSTmRFMEJwZlZLdW1la0dIOTlVb213?= =?utf-8?B?WlpZL2VWTEg3U25DRXpJR2lqWkp1cnloSEtQaVIyeURXcVdreDRqUy9DcDRn?= =?utf-8?B?WGNOVyswOXRqRFh4dE1NUFNCYmwvNnZ1Wi9pMEQ5M3YyQ3VuTS9Ha2QxTW1H?= =?utf-8?B?Wk9pR0RpYUw4b2hlKzNYUmpHYUJaeTRocFlURXdGRnBUV0U5bW8vM3hXL1o2?= =?utf-8?B?c0c1V2JIRlBLaE1XalUrUTFDRys0K21HQytTaVRjL3F3TFJ0MFpqTTN4UjU3?= =?utf-8?B?NktIbkZsK25VUG1FblU4VkVENjRrdFU5eFNwcHJpVHhyNGhlUTgvazJRSm85?= =?utf-8?B?T0NYbXZxQkI4M0R3clBMbW5YQit5dTErQUlLa1ZUbVVhenBjQUFvVjE5Tnc4?= =?utf-8?B?YkVwSVBEeDZRbDNYWnhsSVdTQUVEanJjZDhUWFcvZlp6Wk1wd3hZOUNZTXNB?= =?utf-8?B?Znk0L3ROOWgrQkI4VkpBcU5NMWRQaXIxcERkT0swVFVWVTF3VExLUVdyYjQ3?= =?utf-8?B?VTgyQTVLYWZpOUp0T1V2bWJtUVRXUThtZ0xzaVBZOUFJTC9BYVBFOWhPcjNx?= =?utf-8?B?b29PL1A2aUd3aksrK1g0b1ZTdFFhdkQxQjFGY3pLYmlOOHhGN0tVUTFjaHBo?= =?utf-8?B?aWNaYnJtRDR0UkRXNjh4MHoybFZJUWRra0FUODJZVTJ4cUJIcDNIOTJINkYr?= =?utf-8?B?Ykw2a2ZjcjNFL2J1bmsrYmJxSkl3WlZtMTBaZmF2QkJDV3BNNER4V3NBdVBp?= =?utf-8?B?L21KaDIxR0RpaFdIZ0U0ZmVoQitpUG01dDBSSlBGRkhBYnBoMHowTjdHV2Nm?= =?utf-8?B?UHJSeEVWb1FUU1BleFR0YnUxSjJIaXhPcDVQSGx3SExhY2Z1VVpsZ3Uyamt0?= =?utf-8?B?MWJvSTgvTk9LR0VFY21jcHVobzZ2YVlLcXA1WWo5ZDdaYUplR2J6MEk4NE1V?= =?utf-8?B?dG9PWmEyampkaWNXTVFaeGtiYVFGRjdzU1BkamM2TkhZeFJmYlMwVy8zVUtF?= =?utf-8?B?NUYwK0xGeEpoTHNycFZ0Mi9FdDlXNVZMdnJXTmltWDhXVUJFWWV0SHdvTlVo?= =?utf-8?B?SHFBbEZKZiszK0JrMFE2WDNZdktxekZCeGtiMWRPbmVQaHd1czZpbmtZVnRz?= =?utf-8?B?UEp1ekNyL0htd1drVGxxazVXblEycGx3Q1I3QW1xV084Slc1bm9NcVE2OHNE?= =?utf-8?B?VjI0U2o0NzBkQjcwNHFLNzN3cS9sbGorYXA0YVpBd0dWcndQTkViVHA5NitD?= =?utf-8?B?QnVpUnNURUFDM2NweEZTaElYOFd2ZC95WXh3QWdraTdBV0hON2NISjhyWHNk?= =?utf-8?B?SWJxaEpwb2VSYkJuWmhGb1V2ZXdqeFFpc0tPRWFHdHNwMTM5ZEpKTXhQU0l0?= =?utf-8?B?NGdRRm5EVFhVSHdIWGwzS2pRN0NpWkE4Rk5zT3dmK0xyVTdQejU1MlpnUEZ0?= =?utf-8?B?R0M2d3ppSG5COUpQZWlWY0F0ejM1KzRIQW9nTzUzUzdhUFNaUXNMc0JRdWhF?= =?utf-8?B?bXc3NHQ1TWwxdll3aWhuWlluUG5QdGJPRWZTMzFxYmdrekhzRkMyb2MzeUxJ?= =?utf-8?B?VVhBQ0VMbWwwSXdSeGRLaFVRZjNMQWdtK0hsTE14aG9PLzdSWElLM3FrSWM2?= =?utf-8?B?cTltOHZ2cTJZRTN2aW9SckpmdjJINUM0RjNiVmRlWlpuMUt5UVlzSTFaK3Js?= =?utf-8?B?cVdVQ3pXZ1RMK3dJSjdENlU0NlRWbEdkUFcyMTBuZ29lRmdTVVNUWVF4MFdS?= =?utf-8?B?RnFoTkQ0blJ1N21wVEgzOEpCSGZReGtSZHR4UzRNTHYydlcwMkYzVUE0RE1D?= =?utf-8?B?TTExTWJSRTh1enV0UDVmYTY2OTFCUHB6S3lpZmhhaWxDR0w0Y0FwZnU1N204?= =?utf-8?B?R2xKaysyRjY4cE5LSmNuWkEzWmZjb1gvbDVJalhBMms4N2NGZVdyUkpmaUlE?= =?utf-8?B?a2NUcmdCa01DakJaMnZBL3hadGw2UFBtejdjTi9pNzc2K3JBTUlMNExIK2Q0?= =?utf-8?Q?N7HVQKdPx3fMSWuAAoFNFt10S?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19760f65-15c5-4756-7e9f-08db030f4451 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 22:13:51.1296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xEKG4JrTmQ3Ik9GtOx0T0VpThrW+/1B9czi0R0l255stq9ZRxE/npvRzmBpzYLmh X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8095 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 1/30/2023 8:09 PM, Stephen Hemminger wrote: > Fixing the signal handling in testpmd requires also > fixing EOF handling in cmdline_poll() > > Stephen Hemminger (2): > cmdline: handle EOF in cmdline_poll > testpmd: cleanup cleanly from signal > I confirm this solves the EOF issue, but please check comment on the cmdline library patch (1/2).