From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B289A0A05; Wed, 20 Jan 2021 16:17:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA4E3140D5B; Wed, 20 Jan 2021 16:17:30 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id E5C4B140D1B; Wed, 20 Jan 2021 16:17:28 +0100 (CET) IronPort-SDR: SGgCB0oLjqhpGR/yufz/9n/3wdIlcMV7pyVekZznSUJuHFbxskHGFl3J0rKtcDuCY7WZ7ozMV0 d7J1w0yKywpg== X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="179206938" X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="179206938" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 07:17:14 -0800 IronPort-SDR: AwoRQSCxWfx4O141DNljpAvxdKlN48d1vasC2otiJodS2bOYGrjRchkS+KYmSVj+6jUDtuceh1 R5fw5oIJJ3QA== X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="351082941" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.240.112]) ([10.213.240.112]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 07:17:13 -0800 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson References: <20210108143048.23755-2-david.hunt@intel.com> <20210120135556.33763-1-david.hunt@intel.com> <20210120135556.33763-6-david.hunt@intel.com> <3f6ec5a3-74d5-c2da-3838-31427930088d@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 20 Jan 2021 15:17:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 5/6] power: add new header file to export list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20-Jan-21 3:01 PM, David Hunt wrote: > > On 20/1/2021 2:28 PM, Burakov, Anatoly wrote: >> On 20-Jan-21 1:55 PM, David Hunt wrote: >>> From: Bruce Richardson >>> >>> Adjust meson.build so that 'ninja install' copies the new header >>> file into the installation directory. >>> >>> Fixes: 210c383e247b ("power: packet format for vm power management") >>> Fixes: cd0d5547e873 ("power: vm communication channels in guest") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Bruce Richardson >>> Signed-off-by: David Hunt >>> --- >> >> IMO this should be part of the first patch, otherwise the build could >> (will?) be broken until this patch. >> > Hi Anatoly, > >    It was broken before this patch set. I wanted to have everything in > place, including the correct naming of structs/defines before allowing > builds against the new header file, hence this order in the patch set. > > Rgds, > > Dave. > It's only my opinion obviously, but i rather prefer an approach of fixing build issues first, and then renaming everything, as I like to have each patch build at every step of the way. You probably know better, but from a cursory look, you should be able to keep progressively changing things but also keep everything building correctly every step of the way. -- Thanks, Anatoly