From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 975A8A0561;
Wed, 17 Mar 2021 18:29:40 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 5FABC140F00;
Wed, 17 Mar 2021 18:29:40 +0100 (CET)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by mails.dpdk.org (Postfix) with ESMTP id 5464F140EFD
for <dev@dpdk.org>; Wed, 17 Mar 2021 18:29:38 +0100 (CET)
IronPort-SDR: fTy1j8LbYVMhARbglM+gV50cYGRCNosxbVKhaM2KtCQyscp7sVsL4NuxAiCHVvqNs+Dm8MX7Ea
8eNrHJUU/iRw==
X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="189558568"
X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="189558568"
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
17 Mar 2021 10:29:36 -0700
IronPort-SDR: 5YdN4+Kx60Q1h5NP64Hx/P9lx1Pkm+g41Jw5PYg0lHnwJ+k3JoP+njpOJu/K7ZbE1ck4dvBz0c
TMp1y/98mScw==
X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="406013321"
Received: from mmansoor-mobl.ger.corp.intel.com (HELO [10.252.22.40])
([10.252.22.40])
by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
17 Mar 2021 10:29:35 -0700
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>
References: <20210308222855.823670-1-thomas@monjalon.net>
<20210309094836.988763-1-thomas@monjalon.net>
<20210309094836.988763-2-thomas@monjalon.net>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <f6273e3f-710b-0498-0b68-50ef3fa7ba32@intel.com>
Date: Wed, 17 Mar 2021 17:29:31 +0000
MIME-Version: 1.0
In-Reply-To: <20210309094836.988763-2-thomas@monjalon.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/mlx4: enable debug logs
dynamically
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 3/9/2021 9:48 AM, Thomas Monjalon wrote:
> The macro DEBUG was doing nothing if not compiled with
> RTE_LIBRTE_MLX4_DEBUG.
>
> As it is not used in the data path, it can be always enabled at
> compilation time. Then it can be enabled at runtime with:
> --log-level pmd.net.mlx4:debug
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
+1 to change, but why 'RTE_LIBRTE_MLX4_DEBUG' exists at first place?
It seems is is used both for data and control path, can you extend the patch for:
1- Remove #ifdef from control path
2- Replace with 'RTE_ETHDEV_DEBUG_RX' & 'RTE_ETHDEV_DEBUG_TX' for data path,
please see: https://patches.dpdk.org/project/dpdk/list/?series=15738
3- Remove 'RTE_LIBRTE_MLX4_DEBUG' completely, if not removed document it in the
driver documentation as supported config file