From: Angela Czubak <aczubak@caviumnetworks.com>
To: dev@dpdk.org
Subject: [dpdk-dev] app/testpmd: overriding previous setting of vlan offload when reconfiguring a device
Date: Tue, 18 Apr 2017 17:00:58 +0200 [thread overview]
Message-ID: <f67de9d9-c1ba-176e-3355-590424fbbf2d@caviumnetworks.com> (raw)
Hi,
I think I might have found a bug in test-pmd, but I want to make sure.
One can set VLAN stripping to be on or off with "vlan set strip off/on
all" etc. Let's assume that user stops all ports ("port stop all"), then
modifies max-pkt-len and disbales VLAN stripping ("port config all
max-pkt-len 2048", then "vlan set strip off all"). Next, they start all
ports ("port start all").
User may think that VLAN stripping is off, however, in init_port_config
vlan stripping is enabled (by assignment port->dev_conf.rxmode =
rx_mode), and this setting persists when configuring device once again
in start_port(portid_t) (which is called after issuing "port start all"
if port->need_reconfig is greater than 0). Thus, even though user
disabled VLAN stripping, it is still on.
The question is: should port configuration be updated by adding lines
like "port->dev_conf.rxmode.hw_vlan_strip = 0" in rx_vlan_strip_set
etc.? Or maybe VLAN offload modification should be made only with
reconfiguring whole ports, and there should be no calls to
rte_eth_dev_set_vlan_offload (which does not need the port to be
switched off). Which is the right approach?
Regards,
Angela
reply other threads:[~2017-04-18 15:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f67de9d9-c1ba-176e-3355-590424fbbf2d@caviumnetworks.com \
--to=aczubak@caviumnetworks.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).