From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0058.outbound.protection.outlook.com [104.47.40.58]) by dpdk.org (Postfix) with ESMTP id 9E423F94 for ; Tue, 18 Apr 2017 17:01:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=F5C8pva+4mRjuwyFbad4c5TN95pydRYTRSz7Kj23ZJE=; b=ldkF2rsJo1pJrKRkPP4QwyN48cGYOZLdYkV5iyOWXlk5EuLLYMEqJgNHM645zZdPNrlVKqJR+f/8AsndIa1EqGCfr7kx5h+XJhOz8KjUi6iDXtGNCwqfTvntyVNIudzzm0rFjGWm6tRgesNhrL/8wfBiWJYb6Kss4IZmETCrKGI= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from [10.0.0.11] (31.172.191.173) by SN2PR0701MB813.namprd07.prod.outlook.com (10.160.16.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Tue, 18 Apr 2017 15:01:05 +0000 From: Angela Czubak To: dev@dpdk.org Message-ID: Date: Tue, 18 Apr 2017 17:00:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: DB6PR0601CA0004.eurprd06.prod.outlook.com (10.168.88.142) To SN2PR0701MB813.namprd07.prod.outlook.com (10.160.16.147) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1ecc9d2-9ba2-4d7d-5e3a-08d4866bbd4c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:SN2PR0701MB813; X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB813; 3:TBTAbgu3zNLuwsdL1T2rD1PuWbb2vcn4pSUmJzBkt4zNlcGYF0MjQU6I9lOBnTJOCeFwie4B2rAAyIHgarAGk6QGdSawlEgf2sg+l7xJ82TWJSwcN1qHC+X55crl349RcNo45TurilVtxwwYSKKjuPjc+0+rHJLfAZ9nStRnpeIFRiHcDKJawy9knOj/B0PbVVbh6fkgIQDPH78uhq1BmmhuqFGBR7CWkKE7YoAvpV6G46v4Wp4RO8mkKsxA43tLxSn8ALU18XAw9HgsnkkR5+p652gRei8LSAHv8oeLPm45eMDxTgewan6W/s4X06YExhAITU4TXTtntCQTGaePBw==; 25:+7aCJ3lh2VGrZunM84yLJiw4vkY1Bmz/OxPL3/Knq2TW20Y88YBtW484P/upjt9/WZY5ifK5AVwqBMlRWaOX1oOOkOzjgisqJ8e7+f08Kd7EeYuZGAXpWcMPh2nOPEe/f+8L8TDCJX1t7ChchRKeu0A9M7RQrRgGlMG+B6KsnWTudPHfK5vDbyHGBaigztQ72s47Y5xNvo1UuIuochKI0e6IQ3K1SgvngE+hIdPLzN4S68zrHsz2/wgk/74XNTEvaOg2W0Ui4DJ8SOXEcnRxMnVDbsA7zWE+NVmDnBnJwvQ6z7QVm02oqEo1Knhso2IposA4so9VlTuEIVjVq1nk1zVSmSxIWHBEUfnrkFhxjTB7yg3pBgNsalqgfN1HaDRIxDXeA9/vnvZ4rg7acaETdL5xQ1ALZfpK6G2kn3bO+vp8KZYgCapV2zTE3JI7YmCtEZIXNvomoVK7jhRATMICag== X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB813; 31:ebZquOx9bhIvsNcWqpPpnt+n0KLlxFQbQamqIgDqGmgi6lCtgczkIGOCtLFHU0WSyxXbv8oyPslhwd2Ik7u+62gCzE7tBfRcJfC999T0V5VK3icG54bptiUYdhqBHn8F43l7UJugvN5V96aD1kpM10ZblROQgDA60Jy3xHvb5VwNMxHRDwKDxiu1+ZaRZg/fk106oKXerynhFRD7dv0EvpwlvBtqKyl+S9t/L2CG2D3x8uZ3ynNOJ3WOtwOIGmqEWCMccpbbZ3P1CuwPVkTEug==; 20:DsfSTTpW8ZRQCIWWx4PWQ2gqEpt3iSTlWoI4+5Mk2/Iu7dlSt1cdPhEwYk+YfZQsfM4iC7uvIyBNlfkxogVZHkQQMDovE58sWFWxTtyWiFrkanajusfjpmjyRC9CK+8/UbXnE4LRYYDYUfrDJKTnmPgiL4npRjFHiPsdStaWugJDAV+Nq6hxYZSlztllbh87jS9siTfQE6/ju1pZhv62zrWBwH1NY0iPJmTMfd+BesEoixOvBQHum0CLHKJvFLNoL04Vik9RQGbl2OxEEEj/XnnXfCU2dcw3sujUbX7HiA1vw9zK0/RddqBtw5AenVNGaSDV7Xeu82hLhqrq86mGuiJGeMaGiHjyU2403VDtL3xqikmtnpnHH17oLNl4p5wT7Jcm/ojHrGNsrwE25io8OblypHtNamYca1KdJmPSY2qVs5WbVH5CoCXm+dkRLvTQuWeSYgmO670dSxlhs2YDJ6h+szLEJ/r/BaY3wX5U6SPt43MN3LbecWyDrUVEcQ/XDdzu60/J/okEIgXmWui/UwyO3FTNCYF4cshjW5oqJTuswC7ijPdVC43nGM12w0hk4wq7e690HjEvL2XTPKiES1MOcwtNCKQRTX9aA7nS578= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148); SRVR:SN2PR0701MB813; BCL:0; PCL:0; RULEID:; SRVR:SN2PR0701MB813; X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB813; 4:y/gxGEL9c/2TMMbRAgXGCOPf44QZqFrtDHZDzJkKWp+auCiy+stzxLtiVoeUXFOLM6C4oGx3uvqJgFm3ifR7IdqBgElUv8xk0HiiONjPy7a9u0OPiOp3uawW4FwnEiWU6uF6lszz9SfVJDQs3Y9oJgMQZ6P4DGHfTAh0rfNmBr9iE+OZ3XGTjiC75jfmttCecbZbo4k5qRhi/DxwY702DNOYQkKWf27mULWRop6uhRnzuWC9JxcKJMYkCQHySpdV1T7ERMfTc8cdqj9xiVM0J6ChpUPXG6YzCJGAlV0lnDGDa7wqRGzriQN8HiFgQ/EWuHYyYx5waskE+244BEaiTlTbMGcbvo+6T2AtXIM1guBBSQ8gqWOVaPacEJbKZYIMTxmFCiReh45c1f3VuocfkkLcil1ZQC7Sgenmv66z2jWXiWh1EZerzGIU8uJwIoJmvdKBY3BejGTuV9ozbctuoVSrCp2kiOHWSgP4k4XddsbP/r66jYXl7cnY//WOPYPFe7l/jBae4DP3D1xmrdDwjOdH+DAfj/llbzhzU8yqoZSRZyrv/FRVSk/58tYabyeaxMvsvzZfotbEryWyXzttZMBd3FaBPp0/4AxmY8vqFWDGnc0GBi3rl1L834o/ZK8qw3hEULkQbY4ggPYlXTSTixF0T3LNCBGGHYrnAvU/YFgdulb1CraQtO+ncqB5snPA X-Forefront-PRVS: 028166BF91 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(39450400003)(39410400002)(39840400002)(39850400002)(39400400002)(81166006)(31686004)(50986999)(42186005)(6116002)(189998001)(4001350100001)(2361001)(53936002)(2351001)(33646002)(3846002)(54356999)(42882006)(25786009)(6666003)(6916009)(47776003)(65956001)(64126003)(65806001)(50466002)(66066001)(77096006)(38730400002)(110136004)(31696002)(5660300001)(230700001)(23676002)(2906002)(6486002)(90366009)(8676002)(7736002)(83506001)(305945005)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR0701MB813; H:[10.0.0.11]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjA3MDFNQjgxMzsyMzpZekprdXNTaWI5UEJ1L1VlbGFPYVBTQXB4?= =?utf-8?B?WkVzN0ZZS2ZKY0lGQ2pBN1A0dmVxbzQ1UnZBN1oxL0IvRmdJOEFpc3ZNUEdM?= =?utf-8?B?QjJFcmV1TFdxOU1VSzBEVVM0SnhFc0tyV1ExMHFoa1FmbGZRaWZDM3lyd25w?= =?utf-8?B?b2hvK2h2bEVld0RmN0t4Y1BLbEptMmNkMkJ6N1hDdEtFRjlxczdLNVBLS0dJ?= =?utf-8?B?a1JiMmM2YlU1NnZOMUhDUTdQMEg4MFZ4VkFZRmtHeHV0cUpHY3BRMHpWamNL?= =?utf-8?B?SXJBc0tzWDlJdGtjRkU1M3R5TExZaWpObXhFSnBiQXJydGtyOW1SS2tQS1Vm?= =?utf-8?B?Y0VvbEFQOEJZUzd2ejdkNFpqQnQwRGl2Y1lRc2VrenlQV2Nwc20zamFxcEdj?= =?utf-8?B?ajZBd2tMbGhPbWJ3QUNadzVSUFVEZzNyL3l1RzNRaTB0aXpXVkMrMTkzbVFE?= =?utf-8?B?bWpHbkxJd1c2ZUU5bnU5NGtwWk5BSjJ6UmtsQWNoYmFxM2ZZLysrUGsxaXpa?= =?utf-8?B?Y2xlSDYwUzE5Q0krUVRVQnR3TWxLdExTMVdkVndSL1FlY3c1ZEswSXpLSUN5?= =?utf-8?B?RUlZWXNQa3l5aUVHUnFWYnh5VHNxZW5TYUlHYVB5a3Y3L3J3aEx5d2VYWXhh?= =?utf-8?B?REtRb1ExQzN4a0NGRjZNOGt1MmZqNFpjY1NMVGhpOVV5UGp5azVjRkhUb1Rr?= =?utf-8?B?bExDOSs4L0Z5VWRCRDM2N0tNN0g0bCsxZnhQMXZJcmVCTUhXQUxHc3RVelJZ?= =?utf-8?B?ODJGNHgrRHUwZ085NkllK3gvaDFCYThxRnVJTmlvKzVJdk80ZEZBTzhCSUxU?= =?utf-8?B?K3dQYmFGUGhzMU45Q3d5bGZCRTFObmdkMko2SkpTRkFHTmQ5NUdwZy9Ramt3?= =?utf-8?B?Zm5DdVNJbmIzM1J1ejdNMzViM3R0S004TEhldm1LUE50bFQyUk9PdUV0eXdw?= =?utf-8?B?WkEvdG9EOHlmM0UzTGFEQmlzdThiTGMzRmZxcDYveTJtN2paOFZzSlBDMlRR?= =?utf-8?B?UWNUZHpOL2wzMlRzalFCajJhTDRZOGgrU0RMUFhiVFo4ek1yTXBYNWpLWHpR?= =?utf-8?B?dHEwcGFvSGE2VTNiOC9oUGI1QTM1aXRseHJKaU9GT0x5aWp4bzVxQWREZmY5?= =?utf-8?B?bkptZGxLOXl4SXdoWmRsMUJDdnQwSHJVVFd4RzJHV2tlVTkrMSs5bkJNeDg2?= =?utf-8?B?aEZKVzBILzR5SDRjTHhDMUwxZS9GdzlkNnoxYkJoL2xaRWxIV2FqMHBQVjd6?= =?utf-8?B?TXVucElnN29nREkvSXpLZ1NBYWJHak5Zd2tRTkpzTVpxRUFHL0xncWdNbVMv?= =?utf-8?B?SUNuUXc3YzlJWU1LZzM1VXVPaEhPVkJDdTV5bnpoTkp2L0FoR1NmdW5hT243?= =?utf-8?B?NzMzdFNCZ2pLNy9rVDkybTdXcDFjS2JiV2xHNGdsZjk3eHhSV2dWU24zcy9P?= =?utf-8?B?c1RvSW52QlAvQUljM1AyMzUrWStiOG40T2t0VlErckdGcUxDMW1TWjRJeVVZ?= =?utf-8?Q?LcL2uhM1TVu7KUB5QnWr7N0MIs34RFmh933zrALrUByLp4k?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB813; 6:j+eSNaqytIY1VCE43y+tsynlGKLV1SVyX+MHVNJ2hIOahTxrWDCzc0JKkHCU1FIiphDBrZLjH+5HVN6qGJRjA1eHSgp1o7Kxok0jNm3GgmXEizqJNOMncDZ9qpZPYfl3U0DFk23dfQnEmcapXLbjU3RHHPY5OtQrufv18/LdovA0YPxy52n0Fcfb2KEkOVol0y/4DrdJHo/6b0HwTifexobVzw3WdH9lwZfIpwcdhjyjfOTpvd/vah0nsDGQenwI71vDRbOGynLu1UaUKDDVh9uHmPJsdUviCbXDOrtkT9AqM2XAXumjLgCw5tmFxtiJoAGyTFCz0tDwEka1JTcWzMS43N8NXlfs58jlQs7ZwDqXrY3cWE8VghRadu5T9/XR+lH7u+TGN6IfFNS6AP213/AkurAa5lBizvxG9NuH6qdFFMVRHhV4eQ0KCRpNAJpVsqMJHrcc/rc78ASnomGk6A==; 5:diftBq4XhZ7uU4ux0WsEXmwCfGygWVhac24QPtyn6YTEDOevG1qZo+z2NJPlfyJpnP/oLgynoqsH4th8zjeVydj6ymxdYKODl6QqksM7IixmzYAxmv9fnr/4sRWWdp66LtcS1n6IHzossD9FfAjGhg==; 24:VsD3moTefcA1KAf1uuqyuMYoY37ITJSlit7sb50+63ljcx9WD1nXKwsX/RDL2elWtZAmzXt6g4TOjgMuOtJ0s4GKUqjlbEpomG0VWDFN9A0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB813; 7:a1UfWEPJwL16wcWyHceSTtCKEFncHjzeeCKyWb6PBZw8VccpMRdNViLbgKdxe9qtYz75bQ0zCWKpSXfG/znKdxMhwkJ8wfwF8vM0wuN4FpXR+r97sBpEeYwIQduS2QXecp1Av8iPu5KSRubGR+fdCoe9ARV2x82uMjKUPncWTQ+Q7NAzTrhfozmVgXfdRAjQJX/xaFVdDuBxIZ/SFvsk8q9N3VhFH0Y8uDajBVjhgTRN1tAOrX/00320auSVwfL9p03XwtA3VBxIIyB4SW0f/HL69SU8zNbWQyxyrFY9C1QrXC97v8trD5dDpI65e03OxJRFHKR2V+N50SHZbnfiwA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2017 15:01:05.6399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0701MB813 Subject: [dpdk-dev] app/testpmd: overriding previous setting of vlan offload when reconfiguring a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 15:01:08 -0000 Hi, I think I might have found a bug in test-pmd, but I want to make sure. One can set VLAN stripping to be on or off with "vlan set strip off/on all" etc. Let's assume that user stops all ports ("port stop all"), then modifies max-pkt-len and disbales VLAN stripping ("port config all max-pkt-len 2048", then "vlan set strip off all"). Next, they start all ports ("port start all"). User may think that VLAN stripping is off, however, in init_port_config vlan stripping is enabled (by assignment port->dev_conf.rxmode = rx_mode), and this setting persists when configuring device once again in start_port(portid_t) (which is called after issuing "port start all" if port->need_reconfig is greater than 0). Thus, even though user disabled VLAN stripping, it is still on. The question is: should port configuration be updated by adding lines like "port->dev_conf.rxmode.hw_vlan_strip = 0" in rx_vlan_strip_set etc.? Or maybe VLAN offload modification should be made only with reconfiguring whole ports, and there should be no calls to rte_eth_dev_set_vlan_offload (which does not need the port to be switched off). Which is the right approach? Regards, Angela