From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Maayan Kashani <mkashani@nvidia.com>
Cc: dev@dpdk.org, dsosnowski@nvidia.com, rasland@nvidia.com,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH] app/testpmd: support retrying device stop
Date: Fri, 5 Jul 2024 12:28:59 +0100 [thread overview]
Message-ID: <f680d258-c21f-48ef-a3f2-c7c61e48a355@amd.com> (raw)
In-Reply-To: <20240603100931.5195595b@hermes.local>
On 6/3/2024 6:09 PM, Stephen Hemminger wrote:
> On Sun, 2 Jun 2024 13:30:35 +0300
> Maayan Kashani <mkashani@nvidia.com> wrote:
>
>> From: Dariusz Sosnowski <dsosnowski@nvidia.com>
>>
>> In some cases rte_eth_dev_stop() can fail with EBUSY error code meaning
>> that port cannot be stopped, because of other resources referencing this
>> port and port must be stopped again after these resources are freed.
>>
>> This patch adds handling of EBUSY error code on port stop to testpmd.
>>
>> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
>
> What causes EBUSY. Seems like a driver bug or a test scenario problem.
> You can't expect every DPDK application to retry.
>
'rte_eth_dev_stop()' returning EBUSY anticipates this kind of usage already.
But I also agree we should avoid propagating driver issues to the
application, that is why it is better to clarify motivation of this
patch, why specific driver returns EBUSY on stop.
next prev parent reply other threads:[~2024-07-05 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 10:30 Maayan Kashani
2024-06-03 17:09 ` Stephen Hemminger
2024-07-05 11:28 ` Ferruh Yigit [this message]
2024-07-05 12:01 ` Dariusz Sosnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f680d258-c21f-48ef-a3f2-c7c61e48a355@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).